* [PATCH v2] staging: iio: ad7192: create of_device_id array
@ 2019-06-28 19:49 Bárbara Fernandes
2019-07-14 16:30 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Bárbara Fernandes @ 2019-06-28 19:49 UTC (permalink / raw)
To: lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw, gregkh
Cc: linux-iio, devel, linux-kernel, kernel-usp,
Bárbara Fernandes, Wilson Sales
Create list of compatible device ids to be matched with those stated in
the device tree.
Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Wilson Sales <spoonm@spoonm.org>
Co-developed by: Wilson Sales <spoonm@spoonm.org>
---
drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 3d74da9d37e7..70118db98d94 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
{"ad7195", ID_AD7195},
{}
};
+
MODULE_DEVICE_TABLE(spi, ad7192_id);
+static const struct of_device_id ad7192_of_match[] = {
+ { .compatible = "adi,ad7190" },
+ { .compatible = "adi,ad7192" },
+ { .compatible = "adi,ad7193" },
+ { .compatible = "adi,ad7195" },
+ {}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_match);
+
static struct spi_driver ad7192_driver = {
.driver = {
.name = "ad7192",
+ .of_match_table = ad7192_of_match,
},
.probe = ad7192_probe,
.remove = ad7192_remove,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: iio: ad7192: create of_device_id array
2019-06-28 19:49 [PATCH v2] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
@ 2019-07-14 16:30 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-07-14 16:30 UTC (permalink / raw)
To: Bárbara Fernandes
Cc: lars, Michael.Hennerich, stefan.popa, knaack.h, pmeerw, gregkh,
linux-iio, devel, linux-kernel, kernel-usp, Wilson Sales
On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed by: Wilson Sales <spoonm@spoonm.org>
> ---
Patch is fine and applied to the togreg branch of iio.git.
Only thing to note is that reviewers and maintainers often have
poor memories (or are jet lagged which is my excuse today!)
so it helps to put a change log here under the ---
Thanks,
Jonathan
> drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..70118db98d94 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> {"ad7195", ID_AD7195},
> {}
> };
> +
> MODULE_DEVICE_TABLE(spi, ad7192_id);
>
> +static const struct of_device_id ad7192_of_match[] = {
> + { .compatible = "adi,ad7190" },
> + { .compatible = "adi,ad7192" },
> + { .compatible = "adi,ad7193" },
> + { .compatible = "adi,ad7195" },
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_match);
> +
> static struct spi_driver ad7192_driver = {
> .driver = {
> .name = "ad7192",
> + .of_match_table = ad7192_of_match,
> },
> .probe = ad7192_probe,
> .remove = ad7192_remove,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-14 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 19:49 [PATCH v2] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
2019-07-14 16:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).