From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v3 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt
Date: Thu, 5 Sep 2019 08:39:59 +0200 [thread overview]
Message-ID: <20190905063959.GB31578@localhost.localdomain> (raw)
In-Reply-To: <20190904091732.112281-5-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 3394 bytes --]
> Report iio motion events to iio subsystem
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v1:
> * none
>
> Changes since v2:
> * none
>
> Should we include these new defines in device settings?
nope if are the same for all available chips..have you double checked?
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 53 ++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 513506caa460..2114c3c78888 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -48,6 +48,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/delay.h>
> +#include <linux/iio/events.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/interrupt.h>
> @@ -72,6 +73,12 @@
> #define ST_LSM6DSX_REG_PP_OD_ADDR 0x12
> #define ST_LSM6DSX_REG_PP_OD_MASK BIT(4)
>
> +#define ST_LSM6DSX_REG_WAKE_UP_SRC_ADDR 0x1B
> +#define ST_LSM6DSX_REG_WAKE_UP_SRC_Z_WU_MASK BIT(0)
> +#define ST_LSM6DSX_REG_WAKE_UP_SRC_Y_WU_MASK BIT(1)
> +#define ST_LSM6DSX_REG_WAKE_UP_SRC_X_WU_MASK BIT(2)
> +#define ST_LSM6DSX_REG_WAKE_UP_SRC_WU_MASK BIT(4)
> +
> static const struct iio_chan_spec st_lsm6dsx_acc_channels[] = {
> ST_LSM6DSX_CHANNEL_ACC(IIO_ACCEL, 0x28, IIO_MOD_X, 0),
> ST_LSM6DSX_CHANNEL_ACC(IIO_ACCEL, 0x2a, IIO_MOD_Y, 1),
> @@ -1611,6 +1618,40 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw,
> return iio_dev;
> }
>
> +int st_lsm6dsx_report_motion_event(struct st_lsm6dsx_hw *hw, int data)
void here
> +{
> + s64 timestamp = iio_get_time_ns(hw->iio_devs[ST_LSM6DSX_ID_ACC]);
> +
> + if (data & ST_LSM6DSX_REG_WAKE_UP_SRC_Z_WU_MASK)
> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC],
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Z,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_EITHER),
> + timestamp);
> +
> + if (data & ST_LSM6DSX_REG_WAKE_UP_SRC_Y_WU_MASK)
> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC],
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_Y,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_EITHER),
> + timestamp);
> +
> + if (data & ST_LSM6DSX_REG_WAKE_UP_SRC_X_WU_MASK)
> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC],
> + IIO_MOD_EVENT_CODE(IIO_ACCEL,
> + 0,
> + IIO_MOD_X,
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_EITHER),
> + timestamp);
> +
> + return 0;
> +}
> +
> static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private)
> {
> return IRQ_WAKE_THREAD;
> @@ -1620,7 +1661,19 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private)
> {
> struct st_lsm6dsx_hw *hw = private;
> int count = 0;
> + int data, err;
> +
> + if (hw->enable_event) {
> + err = regmap_read(hw->regmap,
> + ST_LSM6DSX_REG_WAKE_UP_SRC_ADDR, &data);
> + if (err < 0)
> + goto try_fifo;
> +
> + if (data & ST_LSM6DSX_REG_WAKE_UP_SRC_WU_MASK)
> + st_lsm6dsx_report_motion_event(hw, data);
> + }
>
> +try_fifo:
> if (hw->sip > 0) {
> mutex_lock(&hw->fifo_lock);
> count = st_lsm6dsx_read_fifo(hw);
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-09-05 6:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 9:17 [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 2/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-04 17:24 ` Lorenzo Bianconi
2019-09-05 5:29 ` Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 3/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-04 17:27 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-05 6:34 ` Lorenzo Bianconi
2019-09-05 6:37 ` Sean Nyekjaer
2019-09-05 6:47 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-05 6:39 ` Lorenzo Bianconi [this message]
2019-09-05 7:01 ` Sean Nyekjaer
2019-09-05 7:07 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 6/6] iio: imu: st_lsm6dsx: prohibit the use of events and buffered reads simultaneously Sean Nyekjaer
2019-09-04 17:11 ` [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905063959.GB31578@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).