From: Sean Nyekjaer <sean@geanix.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v3 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread
Date: Thu, 5 Sep 2019 08:37:35 +0200 [thread overview]
Message-ID: <a40bef10-8f82-e284-806e-4852abeb6400@geanix.com> (raw)
In-Reply-To: <20190905063441.GA31578@localhost.localdomain>
On 05/09/2019 08.34, Lorenzo Bianconi wrote:
> This chunck is unnecessary since read_fifo() will check number of available
> samples in the FIFO and moreover it is obviously broken since you are running
> st_lsm6dsx_read_fifo directly instead of using fifo_ops pointer.
Thanks for the review :-)
I have missed that, I have spend a lot of time rebasing "iio: imu:
st_lsm6dsx: move interrupt thread to core".
It could be nice if that patch could be applied in the near future :-)
/Sean
next prev parent reply other threads:[~2019-09-05 6:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 9:17 [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 2/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-04 17:24 ` Lorenzo Bianconi
2019-09-05 5:29 ` Sean Nyekjaer
2019-09-04 9:17 ` [PATCH v3 3/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-04 17:27 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-05 6:34 ` Lorenzo Bianconi
2019-09-05 6:37 ` Sean Nyekjaer [this message]
2019-09-05 6:47 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-05 6:39 ` Lorenzo Bianconi
2019-09-05 7:01 ` Sean Nyekjaer
2019-09-05 7:07 ` Lorenzo Bianconi
2019-09-04 9:17 ` [PATCH v3 6/6] iio: imu: st_lsm6dsx: prohibit the use of events and buffered reads simultaneously Sean Nyekjaer
2019-09-04 17:11 ` [PATCH v3 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a40bef10-8f82-e284-806e-4852abeb6400@geanix.com \
--to=sean@geanix.com \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).