linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
@ 2020-03-16  6:52 Mike Looijmans
  2020-03-22 17:37 ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Looijmans @ 2020-03-16  6:52 UTC (permalink / raw)
  To: jic23, devicetree, linux-iio
  Cc: linux-kernel, knaack.h, lars, pmeerw, robh+dt, mark.rutland,
	Mike Looijmans

This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
the accelerometer part.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt

diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
new file mode 100644
index 000000000000..691a47726dbc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
@@ -0,0 +1,23 @@
+* Bosch BMI088 IMU combining accelerometer and gyroscope
+
+https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
+
+Required properties:
+
+  - compatible : should be "bosch,bmi088_accel"
+  - reg : the I2C address of the sensor or the SPI chip select number
+
+Optional properties:
+
+  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
+		 IRQ_TYPE_EDGE_RISING
+
+Example:
+
+bmi088_accel@1 {
+	compatible = "bosch,bmi088_accel";
+	reg = <1>;
+	spi-max-frequency = <10000000>;
+	interrupt-parent = <&gpio>;
+	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
+};
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
  2020-03-16  6:52 [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings Mike Looijmans
@ 2020-03-22 17:37 ` Jonathan Cameron
  2020-03-23  9:56   ` Mike Looijmans
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2020-03-22 17:37 UTC (permalink / raw)
  To: Mike Looijmans
  Cc: devicetree, linux-iio, linux-kernel, knaack.h, lars, pmeerw,
	robh+dt, mark.rutland

On Mon, 16 Mar 2020 07:52:18 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:

> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> the accelerometer part.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++

Sorry.  All new DT bindings need to be in yaml format.

Please put this in the same series as the driver.

Thanks,

Jonathan

>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> new file mode 100644
> index 000000000000..691a47726dbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> @@ -0,0 +1,23 @@
> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> +
> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> +
> +Required properties:
> +
> +  - compatible : should be "bosch,bmi088_accel"
> +  - reg : the I2C address of the sensor or the SPI chip select number
> +
> +Optional properties:
> +
> +  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> +		 IRQ_TYPE_EDGE_RISING
> +
> +Example:
> +
> +bmi088_accel@1 {
> +	compatible = "bosch,bmi088_accel";
> +	reg = <1>;
> +	spi-max-frequency = <10000000>;
> +	interrupt-parent = <&gpio>;
> +	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> +};


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
  2020-03-22 17:37 ` Jonathan Cameron
@ 2020-03-23  9:56   ` Mike Looijmans
  2020-03-23 16:41     ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Mike Looijmans @ 2020-03-23  9:56 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: devicetree, linux-iio, linux-kernel, knaack.h, lars, pmeerw,
	robh+dt, mark.rutland

On 22-03-2020 18:37, Jonathan Cameron wrote:
> On Mon, 16 Mar 2020 07:52:18 +0100
> Mike Looijmans <mike.looijmans@topic.nl> wrote:
> 
>> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
>> the accelerometer part.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>   .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++
> 
> Sorry.  All new DT bindings need to be in yaml format.
> 
> Please put this in the same series as the driver.

sooy, I noticed this too late, patches are underway in separate mails 
now. Hope that isn't a blocking issue?

> 
> Thanks,
> 
> Jonathan
> 
>>   1 file changed, 23 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
>> new file mode 100644
>> index 000000000000..691a47726dbc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
>> @@ -0,0 +1,23 @@
>> +* Bosch BMI088 IMU combining accelerometer and gyroscope
>> +
>> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
>> +
>> +Required properties:
>> +
>> +  - compatible : should be "bosch,bmi088_accel"
>> +  - reg : the I2C address of the sensor or the SPI chip select number
>> +
>> +Optional properties:
>> +
>> +  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
>> +		 IRQ_TYPE_EDGE_RISING
>> +
>> +Example:
>> +
>> +bmi088_accel@1 {
>> +	compatible = "bosch,bmi088_accel";
>> +	reg = <1>;
>> +	spi-max-frequency = <10000000>;
>> +	interrupt-parent = <&gpio>;
>> +	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
>> +};
> 


-- 
Mike Looijmans

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
  2020-03-23  9:56   ` Mike Looijmans
@ 2020-03-23 16:41     ` Jonathan Cameron
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-03-23 16:41 UTC (permalink / raw)
  To: Mike Looijmans
  Cc: Jonathan Cameron, devicetree, linux-iio, linux-kernel, knaack.h,
	lars, pmeerw, robh+dt, mark.rutland

On Mon, 23 Mar 2020 10:56:41 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:

> On 22-03-2020 18:37, Jonathan Cameron wrote:
> > On Mon, 16 Mar 2020 07:52:18 +0100
> > Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >   
> >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> >> the accelerometer part.
> >>
> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> >> ---
> >>   .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++  
> > 
> > Sorry.  All new DT bindings need to be in yaml format.
> > 
> > Please put this in the same series as the driver.  
> 
> sooy, I noticed this too late, patches are underway in separate mails 
> now. Hope that isn't a blocking issue?

For next version of either pull them together.

Jonathan

> 
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> >>   1 file changed, 23 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> new file mode 100644
> >> index 000000000000..691a47726dbc
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> @@ -0,0 +1,23 @@
> >> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> >> +
> >> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> >> +
> >> +Required properties:
> >> +
> >> +  - compatible : should be "bosch,bmi088_accel"
> >> +  - reg : the I2C address of the sensor or the SPI chip select number
> >> +
> >> +Optional properties:
> >> +
> >> +  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> >> +		 IRQ_TYPE_EDGE_RISING
> >> +
> >> +Example:
> >> +
> >> +bmi088_accel@1 {
> >> +	compatible = "bosch,bmi088_accel";
> >> +	reg = <1>;
> >> +	spi-max-frequency = <10000000>;
> >> +	interrupt-parent = <&gpio>;
> >> +	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> >> +};  
> >   
> 
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-23 16:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16  6:52 [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings Mike Looijmans
2020-03-22 17:37 ` Jonathan Cameron
2020-03-23  9:56   ` Mike Looijmans
2020-03-23 16:41     ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).