* [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
@ 2020-05-06 3:52 Christophe JAILLET
2020-05-06 10:38 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Christophe JAILLET @ 2020-05-06 3:52 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, info, gregkh, dan.carpenter, tglx
Cc: linux-iio, linux-kernel, kernel-janitors, Christophe JAILLET
This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
call.
Remove it.
While at it add a missing \n at the end of the message.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is purely speculative.
I've looked a bit arround and see no point for this get_device() but other
eyes are welcomed :)
---
drivers/iio/accel/sca3000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
index 66d768d971e1..6e429072e44a 100644
--- a/drivers/iio/accel/sca3000.c
+++ b/drivers/iio/accel/sca3000.c
@@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
st->tx[0] = SCA3000_READ_REG(reg_address_high);
ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
if (ret) {
- dev_err(get_device(&st->us->dev), "problem reading register");
+ dev_err(&st->us->dev, "problem reading register\n");
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
2020-05-06 3:52 [PATCH] iio: sca3000: Remove an erroneous 'get_device()' Christophe JAILLET
@ 2020-05-06 10:38 ` Andy Shevchenko
2020-05-06 17:31 ` Marion & Christophe JAILLET
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-06 10:38 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Enrico Weigelt, metux IT consult,
Greg Kroah-Hartman, Dan Carpenter, Thomas Gleixner, linux-iio,
Linux Kernel Mailing List, kernel-janitors
On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
> call.
> Remove it.
>
> While at it add a missing \n at the end of the message.
>
It should have Fixes tag because it is a quite an issue (get_device()
breaks reference counting with all problems we may expect).
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is purely speculative.
> I've looked a bit arround and see no point for this get_device() but other
> eyes are welcomed :)
> ---
> drivers/iio/accel/sca3000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index 66d768d971e1..6e429072e44a 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
> st->tx[0] = SCA3000_READ_REG(reg_address_high);
> ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
> if (ret) {
> - dev_err(get_device(&st->us->dev), "problem reading register");
> + dev_err(&st->us->dev, "problem reading register\n");
> return ret;
> }
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
2020-05-06 10:38 ` Andy Shevchenko
@ 2020-05-06 17:31 ` Marion & Christophe JAILLET
2020-05-08 13:02 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Marion & Christophe JAILLET @ 2020-05-06 17:31 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Enrico Weigelt, metux IT consult,
Greg Kroah-Hartman, Dan Carpenter, Thomas Gleixner, linux-iio,
Linux Kernel Mailing List, kernel-janitors
Le 06/05/2020 à 12:38, Andy Shevchenko a écrit :
> On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
>> call.
>> Remove it.
>>
>> While at it add a missing \n at the end of the message.
>>
> It should have Fixes tag because it is a quite an issue (get_device()
> breaks reference counting with all problems we may expect).
Agreed and I usually do, but here, I've lost track when this driver has
gone out of staging.
Based on:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/iio/accel/sca3000.c
The issue was already there on 2016/10/23, but when I try to go one step
further:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/iio/accel/sca3000.c?id=2ccf61442ff142d2dde7c47471c2798a4d78b0ad
^^^^ ^^^^^^^
works but if I try to see the log for that:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000.c
^^^ ^^^^^^^
is empty.
Most of the time, when I do it like that it works just fine, but not on
this file.
Any other way to navigate in history of moved file would be appreciated.
CJ
>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> This patch is purely speculative.
>> I've looked a bit arround and see no point for this get_device() but other
>> eyes are welcomed :)
>> ---
>> drivers/iio/accel/sca3000.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
>> index 66d768d971e1..6e429072e44a 100644
>> --- a/drivers/iio/accel/sca3000.c
>> +++ b/drivers/iio/accel/sca3000.c
>> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
>> st->tx[0] = SCA3000_READ_REG(reg_address_high);
>> ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
>> if (ret) {
>> - dev_err(get_device(&st->us->dev), "problem reading register");
>> + dev_err(&st->us->dev, "problem reading register\n");
>> return ret;
>> }
>>
>> --
>> 2.25.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
2020-05-06 17:31 ` Marion & Christophe JAILLET
@ 2020-05-08 13:02 ` Jonathan Cameron
2020-05-10 9:54 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2020-05-08 13:02 UTC (permalink / raw)
To: Marion & Christophe JAILLET
Cc: Andy Shevchenko, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald, Enrico Weigelt,
metux IT consult, Greg Kroah-Hartman, Dan Carpenter,
Thomas Gleixner, linux-iio, Linux Kernel Mailing List,
kernel-janitors
On Wed, 6 May 2020 19:31:38 +0200
Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Le 06/05/2020 à 12:38, Andy Shevchenko a écrit :
> > On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
> > <christophe.jaillet@wanadoo.fr> wrote:
> >> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
> >> call.
> >> Remove it.
> >>
> >> While at it add a missing \n at the end of the message.
> >>
> > It should have Fixes tag because it is a quite an issue (get_device()
> > breaks reference counting with all problems we may expect).
>
> Agreed and I usually do, but here, I've lost track when this driver has
> gone out of staging.
>
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/iio/accel/sca3000.c
> The issue was already there on 2016/10/23, but when I try to go one step
> further:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/iio/accel/sca3000.c?id=2ccf61442ff142d2dde7c47471c2798a4d78b0ad
> ^^^^ ^^^^^^^
> works but if I try to see the log for that:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000.c
> ^^^ ^^^^^^^
> is empty.
>
> Most of the time, when I do it like that it works just fine, but not on
> this file.
Oddity of the web interface. Edit the url to get a log form a commit
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000.c?id=2ccf61442ff142d2dde7c47471c2798a4d78b0ad
^^^
Then for more fun you have to deal with another rename
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/staging/iio/accel/?id=ced5c03d360aeebaac6faa7dd8d6d0a77733ab16
Next bit of log...
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000_ring.c?id=ced5c03d360aeebaac6faa7dd8d6d0a77733ab16
It goes all the way..
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/staging/iio/accel/sca3000_core.c?id=574fb258d63658e4564c32c1940068a3bad666a0
Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")
Which was in the initial IIO patch set nearly 11 years ago in the merge window for 2.6.32.
What can I say - I was young and just as capable of writing dumb bugs as I am today :)
I'll get this queued up when I'm on the right computer...
Thanks,
Jonathan
>
> Any other way to navigate in history of moved file would be appreciated.
>
> CJ
>
> >
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >> This patch is purely speculative.
> >> I've looked a bit arround and see no point for this get_device() but other
> >> eyes are welcomed :)
> >> ---
> >> drivers/iio/accel/sca3000.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> >> index 66d768d971e1..6e429072e44a 100644
> >> --- a/drivers/iio/accel/sca3000.c
> >> +++ b/drivers/iio/accel/sca3000.c
> >> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
> >> st->tx[0] = SCA3000_READ_REG(reg_address_high);
> >> ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
> >> if (ret) {
> >> - dev_err(get_device(&st->us->dev), "problem reading register");
> >> + dev_err(&st->us->dev, "problem reading register\n");
> >> return ret;
> >> }
> >>
> >> --
> >> 2.25.1
> >>
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
2020-05-08 13:02 ` Jonathan Cameron
@ 2020-05-10 9:54 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2020-05-10 9:54 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Marion & Christophe JAILLET, Andy Shevchenko, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald, Enrico Weigelt,
metux IT consult, Greg Kroah-Hartman, Dan Carpenter,
Thomas Gleixner, linux-iio, Linux Kernel Mailing List,
kernel-janitors
On Fri, 8 May 2020 14:02:21 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Wed, 6 May 2020 19:31:38 +0200
> Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> > Le 06/05/2020 à 12:38, Andy Shevchenko a écrit :
> > > On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
> > > <christophe.jaillet@wanadoo.fr> wrote:
> > >> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
> > >> call.
> > >> Remove it.
> > >>
> > >> While at it add a missing \n at the end of the message.
> > >>
> > > It should have Fixes tag because it is a quite an issue (get_device()
> > > breaks reference counting with all problems we may expect).
> >
> > Agreed and I usually do, but here, I've lost track when this driver has
> > gone out of staging.
> >
> > Based on:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/iio/accel/sca3000.c
> > The issue was already there on 2016/10/23, but when I try to go one step
> > further:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/iio/accel/sca3000.c?id=2ccf61442ff142d2dde7c47471c2798a4d78b0ad
> > ^^^^ ^^^^^^^
> > works but if I try to see the log for that:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000.c
> > ^^^ ^^^^^^^
> > is empty.
> >
> > Most of the time, when I do it like that it works just fine, but not on
> > this file.
>
> Oddity of the web interface. Edit the url to get a log form a commit
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000.c?id=2ccf61442ff142d2dde7c47471c2798a4d78b0ad
> ^^^
> Then for more fun you have to deal with another rename
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/staging/iio/accel/?id=ced5c03d360aeebaac6faa7dd8d6d0a77733ab16
>
> Next bit of log...
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/staging/iio/accel/sca3000_ring.c?id=ced5c03d360aeebaac6faa7dd8d6d0a77733ab16
>
> It goes all the way..
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/staging/iio/accel/sca3000_core.c?id=574fb258d63658e4564c32c1940068a3bad666a0
>
> Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")
>
> Which was in the initial IIO patch set nearly 11 years ago in the merge window for 2.6.32.
>
> What can I say - I was young and just as capable of writing dumb bugs as I am today :)
>
> I'll get this queued up when I'm on the right computer...
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> Thanks,
>
> Jonathan
>
>
> >
> > Any other way to navigate in history of moved file would be appreciated.
> >
> > CJ
> >
> > >
> > >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > >> ---
> > >> This patch is purely speculative.
> > >> I've looked a bit arround and see no point for this get_device() but other
> > >> eyes are welcomed :)
> > >> ---
> > >> drivers/iio/accel/sca3000.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> > >> index 66d768d971e1..6e429072e44a 100644
> > >> --- a/drivers/iio/accel/sca3000.c
> > >> +++ b/drivers/iio/accel/sca3000.c
> > >> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
> > >> st->tx[0] = SCA3000_READ_REG(reg_address_high);
> > >> ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
> > >> if (ret) {
> > >> - dev_err(get_device(&st->us->dev), "problem reading register");
> > >> + dev_err(&st->us->dev, "problem reading register\n");
> > >> return ret;
> > >> }
> > >>
> > >> --
> > >> 2.25.1
> > >>
> > >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-10 9:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 3:52 [PATCH] iio: sca3000: Remove an erroneous 'get_device()' Christophe JAILLET
2020-05-06 10:38 ` Andy Shevchenko
2020-05-06 17:31 ` Marion & Christophe JAILLET
2020-05-08 13:02 ` Jonathan Cameron
2020-05-10 9:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).