linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: health: max30102: update author's email
@ 2020-08-14 13:49 Matt Ranostay
  2020-08-16  8:33 ` Jonathan Cameron
  2020-08-16  9:51 ` Andy Shevchenko
  0 siblings, 2 replies; 4+ messages in thread
From: Matt Ranostay @ 2020-08-14 13:49 UTC (permalink / raw)
  To: jic23; +Cc: linux-iio, Matt Ranostay

Update email to author's current employer

Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
 drivers/iio/health/max30102.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c
index 9b47d9472a4f..bb504e993f19 100644
--- a/drivers/iio/health/max30102.c
+++ b/drivers/iio/health/max30102.c
@@ -2,7 +2,7 @@
 /*
  * max30102.c - Support for MAX30102 heart rate and pulse oximeter sensor
  *
- * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
+ * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
  *
  * Support for MAX30105 optical particle sensor
  * Copyright (C) 2017 Peter Meerwald-Stadler <pmeerw@pmeerw.net>
@@ -632,6 +632,6 @@ static struct i2c_driver max30102_driver = {
 };
 module_i2c_driver(max30102_driver);
 
-MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
+MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
 MODULE_DESCRIPTION("MAX30102 heart rate/pulse oximeter and MAX30105 particle sensor driver");
 MODULE_LICENSE("GPL");
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: health: max30102: update author's email
  2020-08-14 13:49 [PATCH] iio: health: max30102: update author's email Matt Ranostay
@ 2020-08-16  8:33 ` Jonathan Cameron
  2020-08-16  9:51 ` Andy Shevchenko
  1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-08-16  8:33 UTC (permalink / raw)
  To: Matt Ranostay; +Cc: linux-iio

On Fri, 14 Aug 2020 06:49:41 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> Update email to author's current employer
> 
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied.  Thanks,

Jonathan

> ---
>  drivers/iio/health/max30102.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c
> index 9b47d9472a4f..bb504e993f19 100644
> --- a/drivers/iio/health/max30102.c
> +++ b/drivers/iio/health/max30102.c
> @@ -2,7 +2,7 @@
>  /*
>   * max30102.c - Support for MAX30102 heart rate and pulse oximeter sensor
>   *
> - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
>   *
>   * Support for MAX30105 optical particle sensor
>   * Copyright (C) 2017 Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> @@ -632,6 +632,6 @@ static struct i2c_driver max30102_driver = {
>  };
>  module_i2c_driver(max30102_driver);
>  
> -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
>  MODULE_DESCRIPTION("MAX30102 heart rate/pulse oximeter and MAX30105 particle sensor driver");
>  MODULE_LICENSE("GPL");


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: health: max30102: update author's email
  2020-08-14 13:49 [PATCH] iio: health: max30102: update author's email Matt Ranostay
  2020-08-16  8:33 ` Jonathan Cameron
@ 2020-08-16  9:51 ` Andy Shevchenko
  2020-08-16 22:19   ` Matt Ranostay
  1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-08-16  9:51 UTC (permalink / raw)
  To: Matt Ranostay; +Cc: Jonathan Cameron, linux-iio

On Sun, Aug 16, 2020 at 1:06 AM Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
>
> Update email to author's current employer

> - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>

> -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");

This is actually an interesting question, had you been working already
for your current employer?
If no, I don't think this is a proper change in the code (of course it
might require your new contract, then it's probably fine, I dunno). It
would be a good change for MAINTAINERS, though.
If yes, the commit message doesn't clarify this.

In any case, just my 2 cents for the future changes like this, since
the patch already applied.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: health: max30102: update author's email
  2020-08-16  9:51 ` Andy Shevchenko
@ 2020-08-16 22:19   ` Matt Ranostay
  0 siblings, 0 replies; 4+ messages in thread
From: Matt Ranostay @ 2020-08-16 22:19 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Jonathan Cameron, linux-iio

On Sun, Aug 16, 2020 at 2:52 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Aug 16, 2020 at 1:06 AM Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
> >
> > Update email to author's current employer
>
> > - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> > + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
>
> > -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> > +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
>
> This is actually an interesting question, had you been working already
> for your current employer?

Yes I was, but this was for my independent contracting company (that
has been dissolved, and the email clearly won't work anymore)
for a presentation on iio.

Pretty sure Konsulko doesn't have any issue with copyright assignment
to them :).
Also retroactive assignments are quite legal (under US law at least,
also IANAL) as long you of course own the copyright.

Good questions though!

- Matt

> If no, I don't think this is a proper change in the code (of course it
> might require your new contract, then it's probably fine, I dunno). It
> would be a good change for MAINTAINERS, though.
> If yes, the commit message doesn't clarify this.
>
> In any case, just my 2 cents for the future changes like this, since
> the patch already applied.
>
> --
> With Best Regards,
> Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-16 22:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 13:49 [PATCH] iio: health: max30102: update author's email Matt Ranostay
2020-08-16  8:33 ` Jonathan Cameron
2020-08-16  9:51 ` Andy Shevchenko
2020-08-16 22:19   ` Matt Ranostay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).