Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
@ 2020-10-12 20:52 Fabien Parent
  2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Fabien Parent @ 2020-10-12 20:52 UTC (permalink / raw)
  To: linux-kernel, linux-mediatek, linux-arm-kernel, devicetree, linux-iio
  Cc: matthias.bgg, robh+dt, pmeerw, lars, knaack.h, jic23, Fabien Parent

Add documentation for the auxadc binding for MT8516 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
index 78c06e05c8e5..1b7ff9e5615a 100644
--- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
@@ -17,6 +17,7 @@ Required properties:
     - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
     - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
     - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
+    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
   - reg: Address range of the AUXADC unit.
   - clocks: Should contain a clock specifier for each entry in clock-names
   - clock-names: Should contain "main".
-- 
2.28.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
  2020-10-12 20:52 [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Fabien Parent
@ 2020-10-12 20:52 ` Fabien Parent
  2020-10-13  6:01   ` Matthias Brugger
  2020-10-19 10:21   ` Matthias Brugger
  2020-10-13  6:00 ` [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Matthias Brugger
  2020-10-13 17:22 ` Rob Herring
  2 siblings, 2 replies; 9+ messages in thread
From: Fabien Parent @ 2020-10-12 20:52 UTC (permalink / raw)
  To: linux-kernel, linux-mediatek, linux-arm-kernel, devicetree, linux-iio
  Cc: matthias.bgg, robh+dt, pmeerw, lars, knaack.h, jic23, Fabien Parent

Add node for the auxadc IP. The IP is compatible with the one found
in MT8173 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index 89af661e7f63..943c426e9aaf 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
 				#phy-cells = <1>;
 			};
 		};
+
+		auxadc: adc@11003000 {
+			compatible = "mediatek,mt8516-auxadc",
+				     "mediatek,mt8173-auxadc";
+			reg = <0 0x11003000 0 0x1000>;
+			clocks = <&topckgen CLK_TOP_AUX_ADC>;
+			clock-names = "main";
+			#io-channel-cells = <1>;
+			status = "disabled";
+		};
 	};
 };
-- 
2.28.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
  2020-10-12 20:52 [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Fabien Parent
  2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
@ 2020-10-13  6:00 ` Matthias Brugger
  2020-10-18 10:11   ` Jonathan Cameron
  2020-10-13 17:22 ` Rob Herring
  2 siblings, 1 reply; 9+ messages in thread
From: Matthias Brugger @ 2020-10-13  6:00 UTC (permalink / raw)
  To: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
	devicetree, linux-iio
  Cc: robh+dt, pmeerw, lars, knaack.h, jic23



On 12/10/2020 22:52, Fabien Parent wrote:
> Add documentation for the auxadc binding for MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> index 78c06e05c8e5..1b7ff9e5615a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -17,6 +17,7 @@ Required properties:
>       - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
>       - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
>       - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
> +    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
>     - reg: Address range of the AUXADC unit.
>     - clocks: Should contain a clock specifier for each entry in clock-names
>     - clock-names: Should contain "main".
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
  2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
@ 2020-10-13  6:01   ` Matthias Brugger
  2020-10-13  9:06     ` Fabien Parent
  2020-10-19 10:21   ` Matthias Brugger
  1 sibling, 1 reply; 9+ messages in thread
From: Matthias Brugger @ 2020-10-13  6:01 UTC (permalink / raw)
  To: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
	devicetree, linux-iio
  Cc: robh+dt, pmeerw, lars, knaack.h, jic23



On 12/10/2020 22:52, Fabien Parent wrote:
> Add node for the auxadc IP. The IP is compatible with the one found
> in MT8173 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 89af661e7f63..943c426e9aaf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
>   				#phy-cells = <1>;
>   			};
>   		};
> +
> +		auxadc: adc@11003000 {
> +			compatible = "mediatek,mt8516-auxadc",
> +				     "mediatek,mt8173-auxadc";
> +			reg = <0 0x11003000 0 0x1000>;
> +			clocks = <&topckgen CLK_TOP_AUX_ADC>;
> +			clock-names = "main";
> +			#io-channel-cells = <1>;
> +			status = "disabled";
> +		};
>   	};
>   };
> 

Any reason you don't enable the status in the pumpkin dts?

Regards,
Matthias

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
  2020-10-13  6:01   ` Matthias Brugger
@ 2020-10-13  9:06     ` Fabien Parent
  2020-10-13 15:29       ` Matthias Brugger
  0 siblings, 1 reply; 9+ messages in thread
From: Fabien Parent @ 2020-10-13  9:06 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM,
	DTML, linux-iio, Rob Herring, pmeerw, lars, knaack.h, jic23

Hi Matthias,

> Any reason you don't enable the status in the pumpkin dts?

No particular reasons. I looked at what other MTK SoC did for this IP,
and half went with the status to be disabled and the other half went
with an enabled status.  So I went the mt8183 way since it is the last
MTK SoC to have been merged and disabled by default. If you think it
is better to be enabled by default, I can change it, I don't have any
strong opinion about this.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
  2020-10-13  9:06     ` Fabien Parent
@ 2020-10-13 15:29       ` Matthias Brugger
  0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2020-10-13 15:29 UTC (permalink / raw)
  To: Fabien Parent
  Cc: linux-kernel, moderated list:ARM/Mediatek SoC support, Linux ARM,
	DTML, linux-iio, Rob Herring, pmeerw, lars, knaack.h, jic23



On 13/10/2020 11:06, Fabien Parent wrote:
> Hi Matthias,
> 
>> Any reason you don't enable the status in the pumpkin dts?
> 
> No particular reasons. I looked at what other MTK SoC did for this IP,
> and half went with the status to be disabled and the other half went
> with an enabled status.  So I went the mt8183 way since it is the last
> MTK SoC to have been merged and disabled by default. If you think it
> is better to be enabled by default, I can change it, I don't have any
> strong opinion about this.
> 

Well on mt8183 it is missing the thermal driver although as you can read the 
values via sysfs I'd say to enable it. No need to resend just because of that. 
I'll take the patch as-is as soon as Jonathan takes 1/2.

Regards,
Matthias

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
  2020-10-12 20:52 [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Fabien Parent
  2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
  2020-10-13  6:00 ` [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Matthias Brugger
@ 2020-10-13 17:22 ` Rob Herring
  2 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2020-10-13 17:22 UTC (permalink / raw)
  To: Fabien Parent
  Cc: pmeerw, devicetree, linux-kernel, linux-iio, lars, knaack.h,
	matthias.bgg, linux-arm-kernel, linux-mediatek, jic23, robh+dt

On Mon, 12 Oct 2020 22:52:17 +0200, Fabien Parent wrote:
> Add documentation for the auxadc binding for MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
  2020-10-13  6:00 ` [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Matthias Brugger
@ 2020-10-18 10:11   ` Jonathan Cameron
  0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2020-10-18 10:11 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
	devicetree, linux-iio, robh+dt, pmeerw, lars, knaack.h

On Tue, 13 Oct 2020 08:00:25 +0200
Matthias Brugger <matthias.bgg@gmail.com> wrote:

> On 12/10/2020 22:52, Fabien Parent wrote:
> > Add documentation for the auxadc binding for MT8516 SoC.
> > 
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>  
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it (or do nothing given it's
a txt file ;)

Jonathan

> 
> > ---
> >   Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > index 78c06e05c8e5..1b7ff9e5615a 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > @@ -17,6 +17,7 @@ Required properties:
> >       - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
> >       - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> >       - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
> > +    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
> >     - reg: Address range of the AUXADC unit.
> >     - clocks: Should contain a clock specifier for each entry in clock-names
> >     - clock-names: Should contain "main".
> >   


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
  2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
  2020-10-13  6:01   ` Matthias Brugger
@ 2020-10-19 10:21   ` Matthias Brugger
  1 sibling, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2020-10-19 10:21 UTC (permalink / raw)
  To: Fabien Parent, linux-kernel, linux-mediatek, linux-arm-kernel,
	devicetree, linux-iio
  Cc: robh+dt, pmeerw, lars, knaack.h, jic23



On 12/10/2020 22:52, Fabien Parent wrote:
> Add node for the auxadc IP. The IP is compatible with the one found
> in MT8173 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Applied to v5.10-tmp/dts64

Thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 89af661e7f63..943c426e9aaf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
>   				#phy-cells = <1>;
>   			};
>   		};
> +
> +		auxadc: adc@11003000 {
> +			compatible = "mediatek,mt8516-auxadc",
> +				     "mediatek,mt8173-auxadc";
> +			reg = <0 0x11003000 0 0x1000>;
> +			clocks = <&topckgen CLK_TOP_AUX_ADC>;
> +			clock-names = "main";
> +			#io-channel-cells = <1>;
> +			status = "disabled";
> +		};
>   	};
>   };
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 20:52 [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Fabien Parent
2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
2020-10-13  6:01   ` Matthias Brugger
2020-10-13  9:06     ` Fabien Parent
2020-10-13 15:29       ` Matthias Brugger
2020-10-19 10:21   ` Matthias Brugger
2020-10-13  6:00 ` [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Matthias Brugger
2020-10-18 10:11   ` Jonathan Cameron
2020-10-13 17:22 ` Rob Herring

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git