* [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource
@ 2019-10-13 15:27 jic23
2019-11-04 15:16 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 15:27 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Artur Rojek
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Replaces local boilerplate. Identified by coccinelle.
CHECK drivers/iio/adc/ingenic-adc.c
drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Artur Rojek <contact@artur-rojek.eu>
---
drivers/iio/adc/ingenic-adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-adc.c
index 7a53c2f8d438..39c0a609fc94 100644
--- a/drivers/iio/adc/ingenic-adc.c
+++ b/drivers/iio/adc/ingenic-adc.c
@@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct iio_dev *iio_dev;
struct ingenic_adc *adc;
- struct resource *mem_base;
const struct ingenic_adc_soc_data *soc_data;
int ret;
@@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device *pdev)
mutex_init(&adc->aux_lock);
adc->soc_data = soc_data;
- mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- adc->base = devm_ioremap_resource(dev, mem_base);
+ adc->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(adc->base))
return PTR_ERR(adc->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource
2019-10-13 15:27 [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:20 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:16 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Jonathan.Cameron, contact
On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Replaces local boilerplate. Identified by coccinelle.
> CHECK drivers/iio/adc/ingenic-adc.c
> drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> devm_platform_ioremap_resource for adc -> base
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Artur Rojek <contact@artur-rojek.eu>
> ---
> drivers/iio/adc/ingenic-adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> adc.c
> index 7a53c2f8d438..39c0a609fc94 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
> struct device *dev = &pdev->dev;
> struct iio_dev *iio_dev;
> struct ingenic_adc *adc;
> - struct resource *mem_base;
> const struct ingenic_adc_soc_data *soc_data;
> int ret;
>
> @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
> mutex_init(&adc->aux_lock);
> adc->soc_data = soc_data;
>
> - mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - adc->base = devm_ioremap_resource(dev, mem_base);
> + adc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adc->base))
> return PTR_ERR(adc->base);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource
2019-11-04 15:16 ` Ardelean, Alexandru
@ 2019-11-09 12:20 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:20 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, Jonathan.Cameron, contact
On Mon, 4 Nov 2019 15:16:14 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Replaces local boilerplate. Identified by coccinelle.
> > CHECK drivers/iio/adc/ingenic-adc.c
> > drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> > devm_platform_ioremap_resource for adc -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Artur Rojek <contact@artur-rojek.eu>
> > ---
> > drivers/iio/adc/ingenic-adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> > adc.c
> > index 7a53c2f8d438..39c0a609fc94 100644
> > --- a/drivers/iio/adc/ingenic-adc.c
> > +++ b/drivers/iio/adc/ingenic-adc.c
> > @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> > struct device *dev = &pdev->dev;
> > struct iio_dev *iio_dev;
> > struct ingenic_adc *adc;
> > - struct resource *mem_base;
> > const struct ingenic_adc_soc_data *soc_data;
> > int ret;
> >
> > @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> > mutex_init(&adc->aux_lock);
> > adc->soc_data = soc_data;
> >
> > - mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - adc->base = devm_ioremap_resource(dev, mem_base);
> > + adc->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(adc->base))
> > return PTR_ERR(adc->base);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 15:27 [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource jic23
2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).