From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Cosmin Tanislav <demonsingur@gmail.com>,
Jagath Jog J <jagathjog1996@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer
Date: Wed, 21 Sep 2022 21:11:52 +0200 [thread overview]
Message-ID: <482c5a54-3d53-5760-fc8e-8aa3b9341707@linaro.org> (raw)
In-Reply-To: <eb3edbb63c117f93e8ec534f50d8e3cf91ab3041.1663760018.git.mazziesaccount@gmail.com>
On 21/09/2022 13:45, Matti Vaittinen wrote:
> KX022A is a 3-axis Accelerometer from ROHM/Kionix. The senor features
> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ,
Thank you for your patch. There is something to discuss/improve.
> tap/motion detection, wake-up & back-to-sleep events, four acceleration
> ranges (2, 4, 8 and 16g) and probably some other cool fatures.
s/fatures/features/
> +$id: http://devicetree.org/schemas/iio/accel/kionix,kx022a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM/Kionix KX022A Accelerometer bindings
Drop "bindings"
> +
> +maintainers:
> + - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> +
> +description: |
> + KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges,
> + output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering.
> + KX022A can be accessed either via I2C or SPI.
> +
> +properties:
> + compatible: kionix,kx022a
Missing const. I wonder how did it pass testing...
> +
> + reg:
> + description:
> + I2C slave address or SPI chip-select.
Skip description, it's obvious.
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply: true
> + io_vdd-supply: true
No underscores, so io-vdd-supply
> +
> + mount-matrix:
> + description: |
> + an optional 3x3 mounting rotation matrix.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + accel@1f {
Messed up indentation.
> + compatible = "kionix,kx022a";
> + reg = <0x1f>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-21 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 11:40 [RFC PATCH 0/5] iio: Support ROHM/Kionix kx022a Matti Vaittinen
2022-09-21 11:42 ` [RFC PATCH 1/5] regulator: Add devm helpers for get and enable Matti Vaittinen
2022-09-21 11:43 ` [RFC PATCH 2/5] " Matti Vaittinen
2022-09-21 11:45 ` [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer Matti Vaittinen
2022-09-21 19:11 ` Krzysztof Kozlowski [this message]
2022-09-21 19:30 ` Vaittinen, Matti
2022-09-21 19:56 ` Krzysztof Kozlowski
2022-09-22 3:49 ` Matti Vaittinen
2022-09-21 11:45 ` [RFC PATCH 4/5] iio: accel: Support Kionix/ROHM " Matti Vaittinen
2022-09-21 19:18 ` Vaittinen, Matti
2022-09-22 17:03 ` Jonathan Cameron
2022-09-23 6:31 ` Matti Vaittinen
2022-09-24 15:17 ` Jonathan Cameron
2022-09-26 5:02 ` Vaittinen, Matti
2022-10-02 11:11 ` Jonathan Cameron
2022-09-28 11:14 ` Matti Vaittinen
2022-09-28 14:06 ` Andy Shevchenko
2022-09-28 16:23 ` Matti Vaittinen
2022-10-02 11:14 ` Jonathan Cameron
2022-10-02 11:18 ` Jonathan Cameron
2022-10-02 14:31 ` Matti Vaittinen
2022-09-21 11:46 ` [RFC PATCH 5/5] MAINTAINERS: Add KX022A maintainer entry Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482c5a54-3d53-5760-fc8e-8aa3b9341707@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).