* [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure
@ 2020-06-05 2:44 Navid Emamdoost
2020-06-06 16:11 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Navid Emamdoost @ 2020-06-05 2:44 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Navid Emamdoost, Alexandru Ardelean,
linux-iio, linux-kernel
Cc: emamd001, wu000273, kjlu, smccaman
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/iio/pressure/zpa2326.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index 99dfe33ee402..245f2e2d412b 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -664,8 +664,10 @@ static int zpa2326_resume(const struct iio_dev *indio_dev)
int err;
err = pm_runtime_get_sync(indio_dev->dev.parent);
- if (err < 0)
+ if (err < 0) {
+ pm_runtime_put(indio_dev->dev.parent);
return err;
+ }
if (err > 0) {
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure
2020-06-05 2:44 [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure Navid Emamdoost
@ 2020-06-06 16:11 ` Jonathan Cameron
[not found] ` <CAHp75VeRaS0JBRSyr+MeCbkVsscLyxkag00eY+pMPXZ6Jvb2zQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2020-06-06 16:11 UTC (permalink / raw)
To: Navid Emamdoost
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Alexandru Ardelean, linux-iio, linux-kernel, emamd001, wu000273,
kjlu, smccaman
On Thu, 4 Jun 2020 21:44:44 -0500
Navid Emamdoost <navid.emamdoost@gmail.com> wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Hi Navid,
This looks to be a fix, be it for a case that we are hopefully
unlikely to ever hit. Please could you add an appropriate
Fixes tag so we can work out how far to backport it?
Patch looks good to me so if you just reply with a suitable
tag I can add it whilst applying.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/zpa2326.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
> index 99dfe33ee402..245f2e2d412b 100644
> --- a/drivers/iio/pressure/zpa2326.c
> +++ b/drivers/iio/pressure/zpa2326.c
> @@ -664,8 +664,10 @@ static int zpa2326_resume(const struct iio_dev *indio_dev)
> int err;
>
> err = pm_runtime_get_sync(indio_dev->dev.parent);
> - if (err < 0)
> + if (err < 0) {
> + pm_runtime_put(indio_dev->dev.parent);
> return err;
> + }
>
> if (err > 0) {
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure
[not found] ` <CAHp75VeRaS0JBRSyr+MeCbkVsscLyxkag00eY+pMPXZ6Jvb2zQ@mail.gmail.com>
@ 2020-06-08 3:47 ` Navid Emamdoost
0 siblings, 0 replies; 3+ messages in thread
From: Navid Emamdoost @ 2020-06-08 3:47 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Alexandru Ardelean, linux-iio,
linux-kernel, emamd001, wu000273, kjlu, smccaman
On Sat, Jun 6, 2020 at 2:29 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
>
>
> On Saturday, June 6, 2020, Jonathan Cameron <jic23@kernel.org> wrote:
>>
>> On Thu, 4 Jun 2020 21:44:44 -0500
>> Navid Emamdoost <navid.emamdoost@gmail.com> wrote:
>>
>> > Calling pm_runtime_get_sync increments the counter even in case of
>> > failure, causing incorrect ref count. Call pm_runtime_put if
>> > pm_runtime_get_sync fails.
>> >
>> > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
>>
>> Hi Navid,
>>
>> This looks to be a fix, be it for a case that we are hopefully
>> unlikely to ever hit. Please could you add an appropriate
>> Fixes tag so we can work out how far to backport it?
>>
>> Patch looks good to me so if you just reply with a suitable
>> tag I can add it whilst applying.
Hi Jonathan,
Here is the fixes tag:
Fixes: 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support")
>
>
>
> Should not be "iio: ..." in the prefix?
Yes! It should be "iio" in the patch name.
>>
>>
>> Thanks,
>>
>> Jonathan
>>
>> > ---
>> > drivers/iio/pressure/zpa2326.c | 4 +++-
>> > 1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
>> > index 99dfe33ee402..245f2e2d412b 100644
>> > --- a/drivers/iio/pressure/zpa2326.c
>> > +++ b/drivers/iio/pressure/zpa2326.c
>> > @@ -664,8 +664,10 @@ static int zpa2326_resume(const struct iio_dev *indio_dev)
>> > int err;
>> >
>> > err = pm_runtime_get_sync(indio_dev->dev.parent);
>> > - if (err < 0)
>> > + if (err < 0) {
>> > + pm_runtime_put(indio_dev->dev.parent);
>> > return err;
>> > + }
>> >
>> > if (err > 0) {
>> > /*
>>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
Navid.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-08 3:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 2:44 [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure Navid Emamdoost
2020-06-06 16:11 ` Jonathan Cameron
[not found] ` <CAHp75VeRaS0JBRSyr+MeCbkVsscLyxkag00eY+pMPXZ6Jvb2zQ@mail.gmail.com>
2020-06-08 3:47 ` Navid Emamdoost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).