* Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
2020-09-13 11:25 [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required Jonathan Cameron
@ 2020-09-18 13:35 ` Lars-Peter Clausen
2020-09-18 19:15 ` Matt Ranostay
2020-09-20 17:12 ` H. Nikolaus Schaller
2 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2020-09-18 13:35 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio; +Cc: Jonathan Cameron, H . Nikolaus Schaller
On 9/13/20 1:25 PM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> So it's obvious that the code is wrong in passing true, but I'm assuming
> that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> The documentation however has this attribute as IIO_SHARED_BY_ALL.
> My current assumption is the documentation is wrong.
> If anyone knows otherwise please shout out!
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
Obviously correct.
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> index 1474ba63babe..780faea61d82 100644
> --- a/drivers/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/iio/magnetometer/hmc5843_core.c
> @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
> @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
2020-09-13 11:25 [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required Jonathan Cameron
2020-09-18 13:35 ` Lars-Peter Clausen
@ 2020-09-18 19:15 ` Matt Ranostay
2020-09-19 12:10 ` Jonathan Cameron
2020-09-20 17:12 ` H. Nikolaus Schaller
2 siblings, 1 reply; 6+ messages in thread
From: Matt Ranostay @ 2020-09-18 19:15 UTC (permalink / raw)
To: Jonathan Cameron
Cc: open list:IIO SUBSYSTEM AND DRIVERS, Jonathan Cameron,
H . Nikolaus Schaller
On Sun, Sep 13, 2020 at 4:27 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> So it's obvious that the code is wrong in passing true, but I'm assuming
> that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> The documentation however has this attribute as IIO_SHARED_BY_ALL.
> My current assumption is the documentation is wrong.
> If anyone knows otherwise please shout out!
>
Yeah this is much easier to understand than the odd boolean value.
Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> index 1474ba63babe..780faea61d82 100644
> --- a/drivers/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/iio/magnetometer/hmc5843_core.c
> @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
> @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
2020-09-18 19:15 ` Matt Ranostay
@ 2020-09-19 12:10 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-09-19 12:10 UTC (permalink / raw)
To: Matt Ranostay
Cc: open list:IIO SUBSYSTEM AND DRIVERS, Jonathan Cameron,
H . Nikolaus Schaller
On Fri, 18 Sep 2020 12:15:20 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> On Sun, Sep 13, 2020 at 4:27 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > So it's obvious that the code is wrong in passing true, but I'm assuming
> > that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> > The documentation however has this attribute as IIO_SHARED_BY_ALL.
> > My current assumption is the documentation is wrong.
> > If anyone knows otherwise please shout out!
> >
>
> Yeah this is much easier to understand than the odd boolean value.
>
> Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
Thanks all.
Applied to the togreg branch of iio.git. I've not marked it for
stable as it has no functional affect.
Jonathan
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> > Cc: H. Nikolaus Schaller <hns@goldelico.com>
> > ---
> > drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> > index 1474ba63babe..780faea61d82 100644
> > --- a/drivers/iio/magnetometer/hmc5843_core.c
> > +++ b/drivers/iio/magnetometer/hmc5843_core.c
> > @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> > };
> >
> > static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> > - IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> > + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> > IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> > IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> > { }
> > @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> > };
> >
> > static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> > - IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> > + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> > IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> > IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> > { }
> > --
> > 2.28.0
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
2020-09-13 11:25 [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required Jonathan Cameron
2020-09-18 13:35 ` Lars-Peter Clausen
2020-09-18 19:15 ` Matt Ranostay
@ 2020-09-20 17:12 ` H. Nikolaus Schaller
2020-09-21 18:06 ` Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: H. Nikolaus Schaller @ 2020-09-20 17:12 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Jonathan Cameron
> Am 13.09.2020 um 13:25 schrieb Jonathan Cameron <jic23@kernel.org>:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> So it's obvious that the code is wrong in passing true, but I'm assuming
> that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> The documentation however has this attribute as IIO_SHARED_BY_ALL.
> My current assumption is the documentation is wrong.
> If anyone knows otherwise please shout out!
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
on GTA04 (omap3-gta04.dtsi).
> ---
> drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> index 1474ba63babe..780faea61d82 100644
> --- a/drivers/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/iio/magnetometer/hmc5843_core.c
> @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
> @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> };
>
> static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> - IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> { }
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
2020-09-20 17:12 ` H. Nikolaus Schaller
@ 2020-09-21 18:06 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-09-21 18:06 UTC (permalink / raw)
To: H. Nikolaus Schaller; +Cc: linux-iio, Jonathan Cameron
On Sun, 20 Sep 2020 19:12:47 +0200
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> > Am 13.09.2020 um 13:25 schrieb Jonathan Cameron <jic23@kernel.org>:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > So it's obvious that the code is wrong in passing true, but I'm assuming
> > that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> > The documentation however has this attribute as IIO_SHARED_BY_ALL.
> > My current assumption is the documentation is wrong.
> > If anyone knows otherwise please shout out!
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> > Cc: H. Nikolaus Schaller <hns@goldelico.com>
>
> Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> on GTA04 (omap3-gta04.dtsi).
Thanks, that's great. Added the tag and re-pushed as testing for the
autobuilders to work their magic.
Thanks,
Jonathan
>
> > ---
> > drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> > index 1474ba63babe..780faea61d82 100644
> > --- a/drivers/iio/magnetometer/hmc5843_core.c
> > +++ b/drivers/iio/magnetometer/hmc5843_core.c
> > @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> > };
> >
> > static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> > - IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> > + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> > IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> > IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> > { }
> > @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> > };
> >
> > static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> > - IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> > + IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> > IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> > IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> > { }
> > --
> > 2.28.0
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread