From: Roderick Colenbrander <roderick@gaikai.com>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, Chris Ye <lzye@google.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: [PATCH 07/13] HID: playstation: add DualSense Bluetooth support.
Date: Fri, 18 Dec 2020 22:23:30 -0800 [thread overview]
Message-ID: <20201219062336.72568-8-roderick@gaikai.com> (raw)
In-Reply-To: <20201219062336.72568-1-roderick@gaikai.com>
From: Roderick Colenbrander <roderick.colenbrander@sony.com>
This patch adds support for the DualSense when operating in Bluetooth mode.
The device has the same behavior as the DualShock 4 in that by default it
sends a limited input report (0x1), but after requesting calibration data,
it switches to an extended input report (report 49), which adds data for
touchpad, motion sensors, battery and more.
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
---
drivers/hid/hid-playstation.c | 36 +++++++++++++++++++++++++++++++++++
drivers/hid/hid-quirks.c | 1 +
2 files changed, 37 insertions(+)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index b0c0286cfd2b..042fa8d2627d 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -43,6 +43,7 @@ struct ps_calibration_data {
};
#define DS_INPUT_REPORT_USB 0x01
+#define DS_INPUT_REPORT_BT 0x31
#define DS_FEATURE_REPORT_CALIBRATION 5
#define DS_FEATURE_REPORT_CALIBRATION_SIZE 41
@@ -274,6 +275,17 @@ static int ps_device_register_battery(struct ps_device *dev)
return 0;
}
+/* Compute crc32 of HID data and compare against expected CRC. */
+static bool ps_check_crc32(uint8_t seed, uint8_t *data, size_t len, uint32_t report_crc)
+{
+ uint32_t crc;
+
+ crc = crc32_le(0xFFFFFFFF, &seed, 1);
+ crc = ~crc32_le(crc, data, len);
+
+ return crc == report_crc;
+}
+
static struct input_dev *ps_gamepad_create(struct hid_device *hdev)
{
struct input_dev *gamepad;
@@ -390,6 +402,18 @@ static int dualsense_get_calibration_data(struct dualsense *ds)
if (ret < 0)
goto err_free;
+ if (ds->base.hdev->bus == BUS_BLUETOOTH) {
+ /* Last 4 bytes contains crc32 */
+ uint8_t crc_offset = DS_FEATURE_REPORT_CALIBRATION_SIZE - 4;
+ uint32_t report_crc = get_unaligned_le32(&buf[crc_offset]);
+
+ if (!ps_check_crc32(0xa3, buf, crc_offset, report_crc)) {
+ hid_err(ds->base.hdev, "DualSense calibration report CRC's check failed\n");
+ ret = -EILSEQ;
+ goto err_free;
+ }
+ }
+
gyro_pitch_bias = get_unaligned_le16(&buf[1]);
gyro_yaw_bias = get_unaligned_le16(&buf[3]);
gyro_roll_bias = get_unaligned_le16(&buf[5]);
@@ -494,6 +518,16 @@ static int dualsense_parse_report(struct ps_device *ps_dev, struct hid_report *r
*/
if (report->id == DS_INPUT_REPORT_USB && hdev->bus == BUS_USB) {
ds_report = (struct dualsense_input_report *)&data[1];
+ } else if (report->id == DS_INPUT_REPORT_BT && hdev->bus == BUS_BLUETOOTH) {
+ /* Last 4 bytes of input report contain crc32 */
+ uint32_t report_crc = get_unaligned_le32(&data[size - 4]);
+
+ if (!ps_check_crc32(0xa1, data, size - 4, report_crc)) {
+ hid_err(hdev, "DualSense input CRC's check failed, size=%d\n", size);
+ return -EILSEQ;
+ }
+
+ ds_report = (struct dualsense_input_report *)&data[2];
} else {
hid_err(hdev, "Unhandled reportID=%d\n", report->id);
return -1;
@@ -756,6 +790,8 @@ static void ps_remove(struct hid_device *hdev)
}
static const struct hid_device_id ps_devices[] = {
+ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLER),
+ .driver_data = 0 },
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLER),
.driver_data = 0 },
};
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 1ca46cb445be..541c8837debd 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -567,6 +567,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
#endif
#if IS_ENABLED(CONFIG_HID_PLAYSTATION)
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLER) },
++ { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLER) },
#endif
#if IS_ENABLED(CONFIG_HID_PRIMAX)
{ HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) },
--
2.26.2
next prev parent reply other threads:[~2020-12-19 6:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 6:23 [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 01/13] HID: playstation: initial DualSense USB support Roderick Colenbrander
2020-12-27 16:23 ` Barnabás Pőcze
2020-12-27 23:04 ` Roderick Colenbrander
2020-12-29 19:12 ` Barnabás Pőcze
2020-12-31 0:08 ` Barnabás Pőcze
2020-12-31 1:08 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 02/13] HID: playstation: use DualSense MAC address as unique identifier Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 03/13] HID: playstation: add DualSense battery support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 04/13] HID: playstation: add DualSense touchpad support Roderick Colenbrander
2020-12-26 2:14 ` Samuel Čavoj
2020-12-26 22:27 ` Roderick Colenbrander
2020-12-29 19:49 ` Barnabás Pőcze
2020-12-29 21:44 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 05/13] HID: playstation: add DualSense accelerometer and gyroscope support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 06/13] HID: playstation: track devices in list Roderick Colenbrander
2020-12-19 6:23 ` Roderick Colenbrander [this message]
2020-12-19 6:23 ` [PATCH 08/13] HID: playstation: add DualSense classic rumble support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 09/13] HID: playstation: add DualSense lightbar support Roderick Colenbrander
2020-12-27 14:41 ` Barnabás Pőcze
2020-12-28 21:26 ` Roderick Colenbrander
2020-12-29 18:59 ` Barnabás Pőcze
2020-12-29 19:54 ` Roderick Colenbrander
2020-12-29 20:22 ` Barnabás Pőcze
2020-12-19 6:23 ` [PATCH 10/13] HID: playstation: add microphone mute support for DualSense Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 11/13] HID: playstation: add DualSense player LEDs support Roderick Colenbrander
2020-12-26 19:27 ` Samuel Čavoj
2020-12-26 23:07 ` Roderick Colenbrander
2020-12-27 14:27 ` Barnabás Pőcze
2020-12-28 22:02 ` Roderick Colenbrander
2020-12-29 18:49 ` Barnabás Pőcze
2020-12-19 6:23 ` [PATCH 12/13] HID: playstation: DualSense set LEDs to default player id Roderick Colenbrander
2020-12-27 0:08 ` Samuel Čavoj
2020-12-27 23:07 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 13/13] HID: playstation: report DualSense hardware and firmware version Roderick Colenbrander
2020-12-27 17:06 ` Barnabás Pőcze
2020-12-27 22:21 ` Roderick Colenbrander
2020-12-27 22:27 ` Roderick Colenbrander
2020-12-27 22:37 ` Barnabás Pőcze
2020-12-28 22:45 ` Roderick Colenbrander
2020-12-29 15:10 ` Barnabás Pőcze
2020-12-19 8:38 ` [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Bastien Nocera
2020-12-19 22:39 ` Roderick.Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219062336.72568-8-roderick@gaikai.com \
--to=roderick@gaikai.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lzye@google.com \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).