linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roderick Colenbrander <roderick@gaikai.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Chris Ye <lzye@google.com>,
	Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 09/13] HID: playstation: add DualSense lightbar support
Date: Tue, 29 Dec 2020 11:54:38 -0800	[thread overview]
Message-ID: <CANndSKntkgKQokotUYoKrdJ4B9ucKx6FLucEgP=m0ppcxz370g@mail.gmail.com> (raw)
In-Reply-To: <mc1Un9RZANQ4yIfAjCv3ziQaVjEBZ6FYCWJjSygax6AZ5L0VS01uBxkmG3kGWYT2_Sf12jQ62ZVG8pwhZUqc7C9Z0L60ZwaONDkoDMhH0Yc=@protonmail.com>

On Tue, Dec 29, 2020 at 10:59 AM Barnabás Pőcze <pobrn@protonmail.com> wrote:
>
> 2020. december 28., hétfő 22:26 keltezéssel, Roderick Colenbrander írta:
>
> > [...]
> > > > +/* Create a DualSense/DualShock4 RGB lightbar represented by a multicolor LED. */
> > > > +static struct led_classdev_mc *ps_lightbar_create(struct ps_device *ps_dev,
> > > > +     int (*brightness_set)(struct led_classdev *, enum led_brightness))
> > > > +{
> > > > +     struct hid_device *hdev = ps_dev->hdev;
> > > > +     struct led_classdev_mc *lightbar_mc_dev;
> > > > +     struct mc_subled *mc_led_info;
> > > > +     struct led_classdev *led_cdev;
> > > > +     int ret;
> > > > +
> > > > +     lightbar_mc_dev = devm_kzalloc(&hdev->dev, sizeof(*lightbar_mc_dev), GFP_KERNEL);
> > > > +     if (!lightbar_mc_dev)
> > > > +             return ERR_PTR(-ENOMEM);
> > > > +
> > > > +     mc_led_info = devm_kzalloc(&hdev->dev, 3*sizeof(*mc_led_info), GFP_KERNEL);
> > > > +     if (!mc_led_info)
> > > > +             return ERR_PTR(-ENOMEM);
> > > > +
> > >
> > > Is there any reason why these are dynamically allocated?
> >
> > No particular reason. I should probably at least not dynamically
> > allocate 'mc_dev' and pass it in similar to regular LED registration
> > (previously I had my regular LEDs dynamically allocated). The
> > mc_led_info I will probably keep dynamic. It feels a bit nasty to have
> > the caller be aware of these internal details.
> > [...]
>
> Could you please elaborate what you mean by "It feels a bit nasty to have
> the caller be aware of these internal details."? I don't think I fully understand
> what you're referring to.
>

Maybe I misunderstood your original comment. The question was why both
'lightbar_mc_dev' and 'mc_led_info' were dynamically allocated. I
interpreted it as getting rid of some of the dynamic allocation as
some wasn't needed, but not sure what you had in mind. The code now
looks like:

struct dualsense {
...
        /* RGB lightbar */
        struct led_classdev_mc lightbar; (not a pointer anymore)
}

static int ps_lightbar_register(struct ps_device *ps_dev, struct
led_classdev_mc *lightbar_mc_dev,
              int (*brightness_set)(struct led_classdev *, enum led_brightness))
{
          struct hid_device *hdev = ps_dev->hdev;
          struct mc_subled *mc_led_info;
          struct led_classdev *led_cdev;
          int ret;

          mc_led_info = devm_kzalloc(&hdev->dev,
3*sizeof(*mc_led_info), GFP_KERNEL);
          if (!mc_led_info)
                return -ENOMEM;

          mc_led_info[0].color_index = LED_COLOR_ID_RED;
...

In here I kept 'mc_led_info' as dynamically allocated. I didn't think
it made sense to have the caller know about it. What was your original
idea?

Regards,
Roderick

  reply	other threads:[~2020-12-29 19:55 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-19  6:23 [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 01/13] HID: playstation: initial DualSense USB support Roderick Colenbrander
2020-12-27 16:23   ` Barnabás Pőcze
2020-12-27 23:04     ` Roderick Colenbrander
2020-12-29 19:12       ` Barnabás Pőcze
2020-12-31  0:08   ` Barnabás Pőcze
2020-12-31  1:08     ` Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 02/13] HID: playstation: use DualSense MAC address as unique identifier Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 03/13] HID: playstation: add DualSense battery support Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 04/13] HID: playstation: add DualSense touchpad support Roderick Colenbrander
2020-12-26  2:14   ` Samuel Čavoj
2020-12-26 22:27     ` Roderick Colenbrander
2020-12-29 19:49   ` Barnabás Pőcze
2020-12-29 21:44     ` Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 05/13] HID: playstation: add DualSense accelerometer and gyroscope support Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 06/13] HID: playstation: track devices in list Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 07/13] HID: playstation: add DualSense Bluetooth support Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 08/13] HID: playstation: add DualSense classic rumble support Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 09/13] HID: playstation: add DualSense lightbar support Roderick Colenbrander
2020-12-27 14:41   ` Barnabás Pőcze
2020-12-28 21:26     ` Roderick Colenbrander
2020-12-29 18:59       ` Barnabás Pőcze
2020-12-29 19:54         ` Roderick Colenbrander [this message]
2020-12-29 20:22           ` Barnabás Pőcze
2020-12-19  6:23 ` [PATCH 10/13] HID: playstation: add microphone mute support for DualSense Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 11/13] HID: playstation: add DualSense player LEDs support Roderick Colenbrander
2020-12-26 19:27   ` Samuel Čavoj
2020-12-26 23:07     ` Roderick Colenbrander
2020-12-27 14:27   ` Barnabás Pőcze
2020-12-28 22:02     ` Roderick Colenbrander
2020-12-29 18:49       ` Barnabás Pőcze
2020-12-19  6:23 ` [PATCH 12/13] HID: playstation: DualSense set LEDs to default player id Roderick Colenbrander
2020-12-27  0:08   ` Samuel Čavoj
2020-12-27 23:07     ` Roderick Colenbrander
2020-12-19  6:23 ` [PATCH 13/13] HID: playstation: report DualSense hardware and firmware version Roderick Colenbrander
2020-12-27 17:06   ` Barnabás Pőcze
2020-12-27 22:21     ` Roderick Colenbrander
2020-12-27 22:27       ` Roderick Colenbrander
2020-12-27 22:37         ` Barnabás Pőcze
2020-12-28 22:45           ` Roderick Colenbrander
2020-12-29 15:10             ` Barnabás Pőcze
2020-12-19  8:38 ` [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Bastien Nocera
2020-12-19 22:39   ` Roderick.Colenbrander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANndSKntkgKQokotUYoKrdJ4B9ucKx6FLucEgP=m0ppcxz370g@mail.gmail.com' \
    --to=roderick@gaikai.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=lzye@google.com \
    --cc=pobrn@protonmail.com \
    --cc=roderick.colenbrander@sony.com \
    --subject='Re: [PATCH 09/13] HID: playstation: add DualSense lightbar support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox