From: "Ayush" <ayush@disroot.org>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value
Date: Sat, 12 Sep 2020 15:38:50 +0000 [thread overview]
Message-ID: <193982aa3ddb7fcc7ee790d254cbdee0@disroot.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2009121608490.22523@felia>
Sir,
> I could not reproduce those numbers.
>
> Can you share exactly what you are running? And can you share the list of
> differences in your report?
>
> I have seen that the line number now has also changed in some cases.
>
> We can check if the script really improves the detection or not.
I am re-evaluating my output and will give you a analysis of all commits
which are getting affected by my patch.
It will take time to run checkpatch.pl again on those commits, so I will
share as soon as it's finished.
>> my ${CONFIG_} = "CONFIG_";
>> -
>> +my $c_count = 0;
>
> Why do you think this variable definition is supposed to be placed here?
>
> Where are other variables with similar use defined in the checkpatch.pl
> script?
I think this variable should not be defined here, similar variables are added in
the subroutine "process".
In cases like:
- commit
1234567890ab ("foo bar")
It was checking line 1, then it was checking line 2 and then reports the error, which
should not be the case.
This variable is used to track such cases and do not check line 2 in such cases.
It need not be a global variable to work.
I will do the necessary changes in the next version.
Ayush
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-12 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 9:48 [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value Ayush
2020-09-12 11:17 ` Lukas Bulwahn
2020-09-12 12:42 ` Lukas Bulwahn
2020-09-12 13:34 ` Ayush
2020-09-12 14:15 ` Lukas Bulwahn
2020-09-12 15:38 ` Ayush [this message]
2020-09-12 19:37 ` Ayush
2020-09-13 11:01 ` Lukas Bulwahn
2020-09-13 12:06 ` Ayush
2020-09-13 18:09 ` Lukas Bulwahn
2020-09-13 20:53 ` Ayush
2020-09-14 5:12 ` Lukas Bulwahn
2020-09-17 14:53 ` Ayush
2020-09-17 15:17 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=193982aa3ddb7fcc7ee790d254cbdee0@disroot.org \
--to=ayush@disroot.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).