From: "Ayush" <ayush@disroot.org>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value
Date: Sun, 13 Sep 2020 12:06:43 +0000 [thread overview]
Message-ID: <fc57f6016ed0405b87b99549e9de26fc@disroot.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2009131220070.22585@felia>
> Did checkpatch.pl output on other types change?
>
> One of the testers on this list reported that two COMMIT_LOG_LONG_LINE
> reports disappeared. That should not have happened, right?
>
> I had a look at the checkpatch.pl output for commit 0a2bd55c194a ("dm
> integrity: document allow_discard option").
>
> I think the reported line is wrong here.
After the patch, It reports the following line:
#6:
Add decription of the allow_discard option added in commit
Which I think is right as the author wanted to refer commit, which started from the word "commit"
in the reported line only.
Please give your opinion on this.
> Also, the line number for other cases have changed.
Actually I am noticing a weird thing. When I run checkpacth.pl on multiple commits using v5.7..v5.8,
It is not showing correct output, like for some commits, I can see the command when run on multiple commits
did not report an error but when I ran on that individual commit, it's reporting an error.
- Running scripts/checkpatch.pl --show-types -g v5.7..v5.8, gives (for this particular commit):
-----------------------------------------------------------------------------------------------
Commit 3dbf1ee6abbb ("pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler")
-----------------------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 15 lines checked
Commit 3dbf1ee6abbb ("pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler") has no obvious style problems and is ready for submission.
- Running scripts/checkpatch.pl --show-types -g 3dbf1ee6abbb, gives:
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cdca06e4e859 ("pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler")'
#11:
cdca06e4e859 ("pinctrl: baytrail: Add missing spinlock usage in
total: 1 errors, 0 warnings, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 3dbf1ee6abbb ("pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler") has style problems, please review.
This is the reason the analysis on a large no. of commits was incorrect.
I need to investigate this more and check if it's an issue on my side or on the checkpatch.pl side.
Also, I noticed one more issue with my patch, it doesn't handle cases like:
- commit
1234567890ab ("foo
bar")
Due to this, some new GIT_COMMIT_ID errors were also reported.
So, I will try to address this in the next version.
Thanks,
Ayush
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-13 12:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 9:48 [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value Ayush
2020-09-12 11:17 ` Lukas Bulwahn
2020-09-12 12:42 ` Lukas Bulwahn
2020-09-12 13:34 ` Ayush
2020-09-12 14:15 ` Lukas Bulwahn
2020-09-12 15:38 ` Ayush
2020-09-12 19:37 ` Ayush
2020-09-13 11:01 ` Lukas Bulwahn
2020-09-13 12:06 ` Ayush [this message]
2020-09-13 18:09 ` Lukas Bulwahn
2020-09-13 20:53 ` Ayush
2020-09-14 5:12 ` Lukas Bulwahn
2020-09-17 14:53 ` Ayush
2020-09-17 15:17 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc57f6016ed0405b87b99549e9de26fc@disroot.org \
--to=ayush@disroot.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).