* Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h> [not found] <ZDuhnLPczec5qJnq@yoga> @ 2023-04-16 10:01 ` Andy Shevchenko 2023-04-16 13:08 ` Hans de Goede 0 siblings, 1 reply; 2+ messages in thread From: Andy Shevchenko @ 2023-04-16 10:01 UTC (permalink / raw) To: Anup Sharma Cc: andy, linux-staging, linux-kernel, hdegoede, sakari.ailus, mchehab, linux-kernel-mentees, linux-media On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote: > > Fix following checkpatch.pl warning by including > <linux/processor.h> instead of <asm/processor.h> Missing period at the end. But the entire patch seems unnecessary since it's all about x86, and we have more arch headers there anyway. Anyway it's up to Hans. Also see below. ... > #include <asm/intel-family.h> > -#include <asm/processor.h> > +#include <linux/processor.h> > > #include <linux/i2c.h> > #include <media/v4l2-subdev.h> This seems a bit chaotic with the ordering of the headers here. ... If you want a good patch, you need to understand what headers are _really_ being used in the header file. Then drop unused, try to compile that and fix all files that will have missing headers after that. This will be a very useful clean up! -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h> 2023-04-16 10:01 ` [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h> Andy Shevchenko @ 2023-04-16 13:08 ` Hans de Goede 0 siblings, 0 replies; 2+ messages in thread From: Hans de Goede @ 2023-04-16 13:08 UTC (permalink / raw) To: Andy Shevchenko, Anup Sharma Cc: andy, linux-staging, linux-kernel, sakari.ailus, mchehab, linux-kernel-mentees, linux-media Hi, On 4/16/23 12:01, Andy Shevchenko wrote: > On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote: >> >> Fix following checkpatch.pl warning by including >> <linux/processor.h> instead of <asm/processor.h> > > Missing period at the end. But the entire patch seems unnecessary > since it's all about x86, and we have more arch headers there anyway. > Anyway it's up to Hans. Also see below. Right, given how much real work this driver still needs this really feels like needless churn, so I'm not going to take this patch, sorry. Regards, Hans > > ... > >> #include <asm/intel-family.h> >> -#include <asm/processor.h> >> +#include <linux/processor.h> >> >> #include <linux/i2c.h> >> #include <media/v4l2-subdev.h> > > This seems a bit chaotic with the ordering of the headers here. > > ... > > If you want a good patch, you need to understand what headers are > _really_ being used in the header file. Then drop unused, try to > compile that and fix all files that will have missing headers after > that. This will be a very useful clean up! > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-16 13:09 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <ZDuhnLPczec5qJnq@yoga> 2023-04-16 10:01 ` [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h> Andy Shevchenko 2023-04-16 13:08 ` Hans de Goede
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).