* [Linux-kernel-mentees] [PATCH v2] checkpatch: disable commit log length check warning for signature tag
@ 2020-07-28 11:29 Nachiket Naganure
0 siblings, 0 replies; 3+ messages in thread
From: Nachiket Naganure @ 2020-07-28 11:29 UTC (permalink / raw)
To: apw, joe, lukas.bulwahn, skhan
Cc: nachiketun8, linux-kernel-mentees, linux-kernel
Disable commit log length check in case of signature tag. If the commit
log line has valid signature tags such as "Reported-and-tested-by" with
more than 75 characters, suppress the long length warning.
For instance in commit ac854131d984 ("USB: core: Fix misleading driver bug
report"), the corresponding patch contains a "Reported by" tag line which
exceeds 75 chars. And there is no valid way to shorten the length.
Signed-off-by: Nachiket Naganure <nachiketun8@gmail.com>
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 197436b20288..ef603f2d9dbf 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2806,6 +2806,8 @@ sub process {
# filename then :
$line =~ /^\s*(?:Fixes:|Link:)/i ||
# A Fixes: or Link: line
+ $line =~ /^\s*$signature_tags/ ||
+ # Check for signature tag
$commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable commit log length check warning for signature tag
@ 2020-07-27 5:07 Nachiket Naganure
2020-07-27 5:39 ` Lukas Bulwahn
0 siblings, 1 reply; 3+ messages in thread
From: Nachiket Naganure @ 2020-07-27 5:07 UTC (permalink / raw)
To: lukas.bulwahn, skhan, linux-kernel-mentees; +Cc: nachiketun8
Disable commit log length check in case of signature tag. If the commit
log line has valid signature tags such as "Reported-and-tested-by" with
more than 75 characters, suppress the long length warning.
For instance in commit ac854131d984 ("USB: core: Fix misleading driver bug
report"), the corresponding patch contains a "Reported by" tag line which
exceeds 75 chars. And there is no valid way to shorten the length.
Signed-off-by: Nachiket Naganure <nachiketun8@gmail.com>
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 197436b20288..46237e9e0550 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2806,6 +2806,8 @@ sub process {
# filename then :
$line =~ /^\s*(?:Fixes:|Link:)/i ||
# A Fixes: or Link: line
+ $line =~ /$signature_tags/ ||
+ # Check for signature_tags
$commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable commit log length check warning for signature tag
2020-07-27 5:07 [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable " Nachiket Naganure
@ 2020-07-27 5:39 ` Lukas Bulwahn
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2020-07-27 5:39 UTC (permalink / raw)
To: Nachiket Naganure; +Cc: linux-kernel-mentees
On Mon, 27 Jul 2020, Nachiket Naganure wrote:
> Disable commit log length check in case of signature tag. If the commit
> log line has valid signature tags such as "Reported-and-tested-by" with
> more than 75 characters, suppress the long length warning.
>
> For instance in commit ac854131d984 ("USB: core: Fix misleading driver bug
> report"), the corresponding patch contains a "Reported by" tag line which
> exceeds 75 chars. And there is no valid way to shorten the length.
>
> Signed-off-by: Nachiket Naganure <nachiketun8@gmail.com>
It looks more sound now. It applies cleanly on next-20200724, and it
addresses the false positive in the mentioned commit.
The commit message header is still wrong.
If you run
git log --oneline ./scripts/checkpatch.pl
you will see that all commits start with lower-case "checkpatch:" and very
often, it continues with lower-case after the colon.
Fix that and send it out to intended recipients using get_maintainers.pl,
also CC the kernel-mentees list, Shuah and me.
Lukas
> ---
> scripts/checkpatch.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 197436b20288..46237e9e0550 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2806,6 +2806,8 @@ sub process {
> # filename then :
> $line =~ /^\s*(?:Fixes:|Link:)/i ||
> # A Fixes: or Link: line
> + $line =~ /$signature_tags/ ||
> + # Check for signature_tags
> $commit_log_possible_stack_dump)) {
> WARN("COMMIT_LOG_LONG_LINE",
> "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> --
> 2.25.1
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-28 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 11:29 [Linux-kernel-mentees] [PATCH v2] checkpatch: disable commit log length check warning for signature tag Nachiket Naganure
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 5:07 [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable " Nachiket Naganure
2020-07-27 5:39 ` Lukas Bulwahn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).