From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Improve SPDX license identifier check for script files
Date: Mon, 7 Sep 2020 09:10:10 +0200 [thread overview]
Message-ID: <CAKXUXMyh1eVusXc+2DAN9H9WfyXHkTuCuhaiG8dfM54Km+rW4A@mail.gmail.com> (raw)
In-Reply-To: <20200906042724.p6gbirsugnvslmh7@mrinalpandey>
> I was wondering how should I go about the original patch? Should I keep
> both the checks or just the executable one and let be the patch as it is
> as further cleanup can lead to better performance as we have already
> seen with the evaluations.
>
Kees Cook and Andrew Morton pointed out that a tool may not rely on
the executable flag. So, checkpatch.pl may not rely on the executable
flag; the patch we created here is misdesigned, now we know that.
> Also, I have completed all the tasks related to this project on Community
> Bridge's site. What are the next steps of mentorship? By when can I
> expect the results sir/ma'am?
>
Mentorship can begin by October 1st. We need to develop a project plan
for the mentorship, you are in the lead to write that. We need a
project plan for the mentorship to start.
In the process of the checkpatch.pl patch creation, we identified that
we can check if we find any invocations that rely on the executable
flag. This could be a first set of tasks to do in the mentorship.
Maybe, you can find another aspect to look into the checkpatch.pl
evaluation? Maybe the check for the line of the SPDX-Identifier was
not the best case to start with, because it is more complex than
initially thought.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-07 7:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 7:58 [Linux-kernel-mentees] [PATCH] checkpatch: Improve SPDX license identifier check for script files Mrinal Pandey
2020-08-03 10:59 ` Lukas Bulwahn
2020-08-04 15:56 ` Mrinal Pandey
2020-08-04 19:37 ` Lukas Bulwahn
2020-08-09 7:22 ` Mrinal Pandey
2020-08-20 4:42 ` Mrinal Pandey
2020-08-22 8:24 ` Lukas Bulwahn
2020-08-22 19:25 ` Lukas Bulwahn
2020-08-24 8:35 ` Mrinal Pandey
2020-08-24 8:56 ` Lukas Bulwahn
2020-08-25 4:56 ` Mrinal Pandey
2020-08-25 5:54 ` Lukas Bulwahn
2020-08-24 8:23 ` Mrinal Pandey
2020-08-24 8:54 ` Lukas Bulwahn
2020-08-25 4:53 ` Mrinal Pandey
2020-09-06 4:27 ` Mrinal Pandey
2020-09-07 7:10 ` Lukas Bulwahn [this message]
2020-09-11 10:16 ` Mrinal Pandey
2020-09-11 10:33 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMyh1eVusXc+2DAN9H9WfyXHkTuCuhaiG8dfM54Km+rW4A@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=mrinalmni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).