Re: [Linux-kernel-mentees] [PATCH] checkpatch: Improve SPDX license identifier check for script files

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Improve SPDX license identifier check for script files
Date: Fri, 11 Sep 2020 12:33:59 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009111224270.16254@felia> (raw)
In-Reply-To: <20200911101631.4lylpsbaog5g5jdj@mrinalpandey>

On Fri, 11 Sep 2020, Mrinal Pandey wrote:

> On 20/09/07 09:10AM, Lukas Bulwahn wrote:
> > > I was wondering how should I go about the original patch? Should I keep
> > > both the checks or just the executable one and let be the patch as it is
> > > as further cleanup can lead to better performance as we have already
> > > seen with the evaluations.
> > >
> > 
> > Kees Cook and Andrew Morton pointed out that a tool may not rely on
> > the executable flag. So, checkpatch.pl may not rely on the executable
> > flag; the patch we created here is misdesigned, now we know that.
> 
> Sir,
> 
> Yes.
> > 
> > > Also, I have completed all the tasks related to this project on Community
> > > Bridge's site. What are the next steps of mentorship? By when can I
> > > expect the results sir/ma'am?
> > >
> > 
> > Mentorship can begin by October 1st. We need to develop a project plan
> > for the mentorship, you are in the lead to write that. We need a
> > project plan for the mentorship to start.
> > 
> Eagerly looking forward to writing the plan. How, when and to whom am I
> required to submit this plan and what should it broadly contain?
>

A rough plan is required for the beginning of the mentorship, if you would 
like to start on October 1st.

Simply send the plan as text email or share it as a plain Google Doc 
document with me.

I should describe buckets of tasks around checkpatch.pl improvements that 
you see that you can work on.

Just as a hint:

You should have the script for evaluating checkpatch.pl.
If you find many false positives, you can try to improve the check.
If you find many same true positives, you can try to implement a "fix 
automation" in checkpatch.pl.

The end goal is to have a setup/config where we have very few false 
positives and very much fix automation.
Then, we can report back the checkpatch.pl findings for the patches sent 
to the mailing list and integrate the reliable fix automation into
tools for maintainers to pick up patches, such as b4, to quickly fix 
patches on the fly when integrating.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees