From: shuah at kernel.org (Shuah Khan)
Subject: [RFC 16/20] selftest: Add Time Namespace test for supported clocks
Date: Mon, 24 Sep 2018 15:36:56 -0600 [thread overview]
Message-ID: <741594c9-2247-3cde-5da9-ae8cc41854b6@kernel.org> (raw)
In-Reply-To: <20180919205037.9574-17-dima@arista.com>
Hi Dmitry,
Thanks for adding tests with the kernel changes.
On 09/19/2018 02:50 PM, Dmitry Safonov wrote:
> This test checks that all supported clocks can be changed by
> clock_settime.
It would good to elaborate a bit more on the nature of the tests in the
here. Also a few things to consider.
I noticed that this test isn't added to selftests/Makefile as TARGET. If it is
an oversight, please make that change as well. If not, it is fine.
Please make sure if the test can't be run because of unmet dependencies, the test
will exit with KSFT_SKIP as opposed to an error. Dependencies include configuration,
privilege, any other unsupported conditions.
This is a comment applies to all the test patches in this series.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (Shuah Khan)
Subject: [RFC 16/20] selftest: Add Time Namespace test for supported clocks
Date: Mon, 24 Sep 2018 15:36:56 -0600 [thread overview]
Message-ID: <741594c9-2247-3cde-5da9-ae8cc41854b6@kernel.org> (raw)
Message-ID: <20180924213656.umLFWi9W9dmfwqGbY1CInullmkXlgvnobGJUf0zLhyg@z> (raw)
In-Reply-To: <20180919205037.9574-17-dima@arista.com>
Hi Dmitry,
Thanks for adding tests with the kernel changes.
On 09/19/2018 02:50 PM, Dmitry Safonov wrote:
> This test checks that all supported clocks can be changed by
> clock_settime.
It would good to elaborate a bit more on the nature of the tests in the
here. Also a few things to consider.
I noticed that this test isn't added to selftests/Makefile as TARGET. If it is
an oversight, please make that change as well. If not, it is fine.
Please make sure if the test can't be run because of unmet dependencies, the test
will exit with KSFT_SKIP as opposed to an error. Dependencies include configuration,
privilege, any other unsupported conditions.
This is a comment applies to all the test patches in this series.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-09-24 21:36 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 20:50 [RFC 00/20] ns: Introduce Time Namespace dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` [RFC 16/20] selftest: Add Time Namespace test for supported clocks dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-24 21:36 ` shuah [this message]
2018-09-24 21:36 ` Shuah Khan
2018-09-19 20:50 ` [RFC 17/20] selftest/timens: Add test for timerfd dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` [RFC 18/20] selftest/timens: Add test for clock_nanosleep dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` [RFC 19/20] timens/selftest: Add procfs selftest dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-19 20:50 ` [RFC 20/20] timens/selftest: Add timer offsets test dima
2018-09-19 20:50 ` Dmitry Safonov
2018-09-21 12:27 ` [RFC 00/20] ns: Introduce Time Namespace ebiederm
2018-09-21 12:27 ` Eric W. Biederman
2018-09-24 20:51 ` avagin
2018-09-24 20:51 ` Andrey Vagin
2018-09-24 22:02 ` ebiederm
2018-09-24 22:02 ` Eric W. Biederman
2018-09-25 1:42 ` avagin
2018-09-25 1:42 ` Andrey Vagin
2018-09-26 17:36 ` ebiederm
2018-09-26 17:36 ` Eric W. Biederman
2018-09-26 17:59 ` 0x7f454c46
2018-09-26 17:59 ` Dmitry Safonov
2018-09-27 21:30 ` tglx
2018-09-27 21:30 ` Thomas Gleixner
2018-09-27 21:41 ` tglx
2018-09-27 21:41 ` Thomas Gleixner
2018-10-01 23:20 ` avagin
2018-10-01 23:20 ` Andrey Vagin
2018-10-02 6:15 ` tglx
2018-10-02 6:15 ` Thomas Gleixner
2018-10-02 21:05 ` 0x7f454c46
2018-10-02 21:05 ` Dmitry Safonov
2018-10-02 21:26 ` tglx
2018-10-02 21:26 ` Thomas Gleixner
2018-09-28 17:03 ` ebiederm
2018-09-28 17:03 ` Eric W. Biederman
2018-09-28 19:32 ` tglx
2018-09-28 19:32 ` Thomas Gleixner
2018-10-01 9:05 ` ebiederm
2018-10-01 9:05 ` Eric W. Biederman
2018-10-01 9:15 ` Setting monotonic time? ebiederm
2018-10-01 9:15 ` Eric W. Biederman
2018-10-01 18:52 ` tglx
2018-10-01 18:52 ` Thomas Gleixner
2018-10-02 20:00 ` arnd
2018-10-02 20:00 ` Arnd Bergmann
2018-10-02 20:06 ` tglx
2018-10-02 20:06 ` Thomas Gleixner
2018-10-03 4:50 ` ebiederm
2018-10-03 4:50 ` Eric W. Biederman
2018-10-03 5:25 ` tglx
2018-10-03 5:25 ` Thomas Gleixner
2018-10-03 6:14 ` ebiederm
2018-10-03 6:14 ` Eric W. Biederman
2018-10-03 7:02 ` arnd
2018-10-03 7:02 ` Arnd Bergmann
2018-10-03 6:14 ` tglx
2018-10-03 6:14 ` Thomas Gleixner
2018-10-01 20:51 ` avagin
2018-10-01 20:51 ` Andrey Vagin
2018-10-02 6:16 ` tglx
2018-10-02 6:16 ` Thomas Gleixner
2018-10-21 1:41 ` [RFC 00/20] ns: Introduce Time Namespace avagin
2018-10-21 1:41 ` Andrei Vagin
2018-10-21 3:54 ` avagin
2018-10-21 3:54 ` Andrei Vagin
2018-10-29 20:33 ` tglx
2018-10-29 20:33 ` Thomas Gleixner
2018-10-29 21:21 ` ebiederm
2018-10-29 21:21 ` Eric W. Biederman
2018-10-29 21:36 ` tglx
2018-10-29 21:36 ` Thomas Gleixner
2018-10-31 16:26 ` avagin
2018-10-31 16:26 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741594c9-2247-3cde-5da9-ae8cc41854b6@kernel.org \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).