[PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue

[PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue

[Stefan Wahren]

bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
on all Raspberry Pi boards. But there is no driver for this particual
GPIO on CM3 in mainline yet, so this node was left incomplete without
the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
value mismatch of function gpiod_get_from_of_node()") this causing probe
issues of the leds-gpio driver for users of the CM3 dtsi file.

  leds-gpio: probe of leds failed with error -2

Until we have the necessary GPIO driver hide the ACT node for CM3
to avoid this.

Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Hi,

i'm not sure the behavior change in leds-gpio was intended.

Regards
Stefan

diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
index 7c3cb7e..925cb37 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
+++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
@@ -9,6 +9,14 @@
 		reg = <0 0x40000000>;
 	};

+	leds {
+		/*
+		 * Since there is no upstream GPIO driver yet,
+		 * remove the incomplete node.
+		 */
+		/delete-node/ act;
+	};
+
 	reg_3v3: fixed-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
--
2.7.4

Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue

[Florian Fainelli]

On Sun, 13 Oct 2019 12:53:23 +0200, Stefan Wahren <wahrenst@gmx.net> wrote:
> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
> on all Raspberry Pi boards. But there is no driver for this particual
> GPIO on CM3 in mainline yet, so this node was left incomplete without
> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
> value mismatch of function gpiod_get_from_of_node()") this causing probe
> issues of the leds-gpio driver for users of the CM3 dtsi file.
> 
>   leds-gpio: probe of leds failed with error -2
> 
> Until we have the necessary GPIO driver hide the ACT node for CM3
> to avoid this.
> 
> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Applied to devicetree/fixes, thanks!
--
Florian

Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Sun 2019-10-13 12:53:23, Stefan Wahren wrote:
> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
> on all Raspberry Pi boards. But there is no driver for this particual
> GPIO on CM3 in mainline yet, so this node was left incomplete without
> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
> value mismatch of function gpiod_get_from_of_node()") this causing probe
> issues of the leds-gpio driver for users of the CM3 dtsi file.
> 
>   leds-gpio: probe of leds failed with error -2
> 
> Until we have the necessary GPIO driver hide the ACT node for CM3
> to avoid this.
> 
> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue

[Stefan Wahren]

Hi Pavel,

Am 04.11.19 um 10:09 schrieb Pavel Machek:
> On Sun 2019-10-13 12:53:23, Stefan Wahren wrote:
>> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
>> on all Raspberry Pi boards. But there is no driver for this particual
>> GPIO on CM3 in mainline yet, so this node was left incomplete without
>> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
>> value mismatch of function gpiod_get_from_of_node()") this causing probe
>> issues of the leds-gpio driver for users of the CM3 dtsi file.
>>
>>   leds-gpio: probe of leds failed with error -2
>>
>> Until we have the necessary GPIO driver hide the ACT node for CM3
>> to avoid this.
>>
>> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>

thanks but this patch has already been applied.

Can i consider this as a "yes" to my intended question ( Is the behavior
change in leds-gpio desired )?