Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
@ 2019-10-13 10:53 Stefan Wahren
  2019-10-18 18:59 ` Florian Fainelli
  2019-11-04  9:09 ` Pavel Machek
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Wahren @ 2019-10-13 10:53 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Eric Anholt, Florian Fainelli,
	Ray Jui, Scott Branden, Pavel Machek
  Cc: Dan Murphy, bcm-kernel-feedback-list, linux-arm-kernel,
	devicetree, linux-leds, Stefan Wahren, Linus Walleij,
	Krzysztof Kozlowski

bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
on all Raspberry Pi boards. But there is no driver for this particual
GPIO on CM3 in mainline yet, so this node was left incomplete without
the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
value mismatch of function gpiod_get_from_of_node()") this causing probe
issues of the leds-gpio driver for users of the CM3 dtsi file.

  leds-gpio: probe of leds failed with error -2

Until we have the necessary GPIO driver hide the ACT node for CM3
to avoid this.

Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Hi,

i'm not sure the behavior change in leds-gpio was intended.

Regards
Stefan

diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
index 7c3cb7e..925cb37 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
+++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
@@ -9,6 +9,14 @@
 		reg = <0 0x40000000>;
 	};

+	leds {
+		/*
+		 * Since there is no upstream GPIO driver yet,
+		 * remove the incomplete node.
+		 */
+		/delete-node/ act;
+	};
+
 	reg_3v3: fixed-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
--
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
  2019-10-13 10:53 [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue Stefan Wahren
@ 2019-10-18 18:59 ` Florian Fainelli
  2019-11-04  9:09 ` Pavel Machek
  1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-10-18 18:59 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Stefan Wahren, Rob Herring,
	Mark Rutland, Eric Anholt, Ray Jui, Scott Branden, Pavel Machek
  Cc: Dan Murphy, linux-arm-kernel, devicetree, linux-leds,
	Linus Walleij, Krzysztof Kozlowski

On Sun, 13 Oct 2019 12:53:23 +0200, Stefan Wahren <wahrenst@gmx.net> wrote:
> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
> on all Raspberry Pi boards. But there is no driver for this particual
> GPIO on CM3 in mainline yet, so this node was left incomplete without
> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
> value mismatch of function gpiod_get_from_of_node()") this causing probe
> issues of the leds-gpio driver for users of the CM3 dtsi file.
> 
>   leds-gpio: probe of leds failed with error -2
> 
> Until we have the necessary GPIO driver hide the ACT node for CM3
> to avoid this.
> 
> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Applied to devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
  2019-10-13 10:53 [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue Stefan Wahren
  2019-10-18 18:59 ` Florian Fainelli
@ 2019-11-04  9:09 ` Pavel Machek
  2019-11-04 17:03   ` Stefan Wahren
  1 sibling, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2019-11-04  9:09 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Rob Herring, Mark Rutland, Eric Anholt, Florian Fainelli,
	Ray Jui, Scott Branden, Dan Murphy, bcm-kernel-feedback-list,
	linux-arm-kernel, devicetree, linux-leds, Linus Walleij,
	Krzysztof Kozlowski

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Sun 2019-10-13 12:53:23, Stefan Wahren wrote:
> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
> on all Raspberry Pi boards. But there is no driver for this particual
> GPIO on CM3 in mainline yet, so this node was left incomplete without
> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
> value mismatch of function gpiod_get_from_of_node()") this causing probe
> issues of the leds-gpio driver for users of the CM3 dtsi file.
> 
>   leds-gpio: probe of leds failed with error -2
> 
> Until we have the necessary GPIO driver hide the ACT node for CM3
> to avoid this.
> 
> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
  2019-11-04  9:09 ` Pavel Machek
@ 2019-11-04 17:03   ` Stefan Wahren
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2019-11-04 17:03 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Mark Rutland, devicetree, Florian Fainelli, Scott Branden,
	Ray Jui, Linus Walleij, Krzysztof Kozlowski, Eric Anholt,
	Rob Herring, bcm-kernel-feedback-list, Dan Murphy, linux-leds,
	linux-arm-kernel

Hi Pavel,

Am 04.11.19 um 10:09 schrieb Pavel Machek:
> On Sun 2019-10-13 12:53:23, Stefan Wahren wrote:
>> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
>> on all Raspberry Pi boards. But there is no driver for this particual
>> GPIO on CM3 in mainline yet, so this node was left incomplete without
>> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
>> value mismatch of function gpiod_get_from_of_node()") this causing probe
>> issues of the leds-gpio driver for users of the CM3 dtsi file.
>>
>>   leds-gpio: probe of leds failed with error -2
>>
>> Until we have the necessary GPIO driver hide the ACT node for CM3
>> to avoid this.
>>
>> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>

thanks but this patch has already been applied.

Can i consider this as a "yes" to my intended question ( Is the behavior
change in leds-gpio desired )?


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 10:53 [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue Stefan Wahren
2019-10-18 18:59 ` Florian Fainelli
2019-11-04  9:09 ` Pavel Machek
2019-11-04 17:03   ` Stefan Wahren

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git