* [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
@ 2023-05-22 16:26 Neil Armstrong
2023-05-22 17:39 ` Conor Dooley
2023-05-25 11:23 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-05-22 16:26 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson
Cc: linux-leds, devicetree, linux-kernel, Neil Armstrong
The PM8550 PWM modules are compatible with the PM8350c PWM modules,
document the PM8350c PWM compatible as fallback for the PM8550 PWM.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 6295c91f43e8..fa378ee05c16 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -16,18 +16,24 @@ description: >
properties:
compatible:
- enum:
- - qcom,pm660l-lpg
- - qcom,pm8150b-lpg
- - qcom,pm8150l-lpg
- - qcom,pm8350c-pwm
- - qcom,pm8916-pwm
- - qcom,pm8941-lpg
- - qcom,pm8994-lpg
- - qcom,pmc8180c-lpg
- - qcom,pmi8994-lpg
- - qcom,pmi8998-lpg
- - qcom,pmk8550-pwm
+ oneOf:
+ - enum:
+ - qcom,pm660l-lpg
+ - qcom,pm8150b-lpg
+ - qcom,pm8150l-lpg
+ - qcom,pm8350c-pwm
+ - qcom,pm8916-pwm
+ - qcom,pm8941-lpg
+ - qcom,pm8994-lpg
+ - qcom,pmc8180c-lpg
+ - qcom,pmi8994-lpg
+ - qcom,pmi8998-lpg
+ - qcom,pmk8550-pwm
+ - items:
+ - enum:
+ - qcom,pm8550-pwm
+ - const: qcom,pm8350c-pwm
+
"#pwm-cells":
const: 2
---
base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
2023-05-22 16:26 [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible Neil Armstrong
@ 2023-05-22 17:39 ` Conor Dooley
2023-05-22 18:00 ` Neil Armstrong
2023-05-25 11:23 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2023-05-22 17:39 UTC (permalink / raw)
To: Neil Armstrong
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, linux-leds, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]
On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote:
> The PM8550 PWM modules are compatible with the PM8350c PWM modules,
> document the PM8350c PWM compatible as fallback for the PM8550 PWM.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
I suppose you picked "items/enum", rather than "items/const" to reduce
future churn?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---------
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 6295c91f43e8..fa378ee05c16 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -16,18 +16,24 @@ description: >
>
> properties:
> compatible:
> - enum:
> - - qcom,pm660l-lpg
> - - qcom,pm8150b-lpg
> - - qcom,pm8150l-lpg
> - - qcom,pm8350c-pwm
> - - qcom,pm8916-pwm
> - - qcom,pm8941-lpg
> - - qcom,pm8994-lpg
> - - qcom,pmc8180c-lpg
> - - qcom,pmi8994-lpg
> - - qcom,pmi8998-lpg
> - - qcom,pmk8550-pwm
> + oneOf:
> + - enum:
> + - qcom,pm660l-lpg
> + - qcom,pm8150b-lpg
> + - qcom,pm8150l-lpg
> + - qcom,pm8350c-pwm
> + - qcom,pm8916-pwm
> + - qcom,pm8941-lpg
> + - qcom,pm8994-lpg
> + - qcom,pmc8180c-lpg
> + - qcom,pmi8994-lpg
> + - qcom,pmi8998-lpg
> + - qcom,pmk8550-pwm
> + - items:
> + - enum:
> + - qcom,pm8550-pwm
> + - const: qcom,pm8350c-pwm
> +
>
> "#pwm-cells":
> const: 2
>
> ---
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
> change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
2023-05-22 17:39 ` Conor Dooley
@ 2023-05-22 18:00 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-05-22 18:00 UTC (permalink / raw)
To: Conor Dooley
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, linux-leds, devicetree,
linux-kernel
On 22/05/2023 19:39, Conor Dooley wrote:
> On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote:
>> The PM8550 PWM modules are compatible with the PM8350c PWM modules,
>> document the PM8350c PWM compatible as fallback for the PM8550 PWM.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> I suppose you picked "items/enum", rather than "items/const" to reduce
> future churn?
Yes indeed.
Thanks,
Neil
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks,
> Conor.
>
>> ---
>> .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---------
>> 1 file changed, 18 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> index 6295c91f43e8..fa378ee05c16 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> @@ -16,18 +16,24 @@ description: >
>>
>> properties:
>> compatible:
>> - enum:
>> - - qcom,pm660l-lpg
>> - - qcom,pm8150b-lpg
>> - - qcom,pm8150l-lpg
>> - - qcom,pm8350c-pwm
>> - - qcom,pm8916-pwm
>> - - qcom,pm8941-lpg
>> - - qcom,pm8994-lpg
>> - - qcom,pmc8180c-lpg
>> - - qcom,pmi8994-lpg
>> - - qcom,pmi8998-lpg
>> - - qcom,pmk8550-pwm
>> + oneOf:
>> + - enum:
>> + - qcom,pm660l-lpg
>> + - qcom,pm8150b-lpg
>> + - qcom,pm8150l-lpg
>> + - qcom,pm8350c-pwm
>> + - qcom,pm8916-pwm
>> + - qcom,pm8941-lpg
>> + - qcom,pm8994-lpg
>> + - qcom,pmc8180c-lpg
>> + - qcom,pmi8994-lpg
>> + - qcom,pmi8998-lpg
>> + - qcom,pmk8550-pwm
>> + - items:
>> + - enum:
>> + - qcom,pm8550-pwm
>> + - const: qcom,pm8350c-pwm
>> +
>>
>> "#pwm-cells":
>> const: 2
>>
>> ---
>> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
>> change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d
>>
>> Best regards,
>> --
>> Neil Armstrong <neil.armstrong@linaro.org>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
2023-05-22 16:26 [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible Neil Armstrong
2023-05-22 17:39 ` Conor Dooley
@ 2023-05-25 11:23 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-05-25 11:23 UTC (permalink / raw)
To: Neil Armstrong
Cc: Pavel Machek, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, linux-leds, devicetree, linux-kernel
On Mon, 22 May 2023, Neil Armstrong wrote:
> The PM8550 PWM modules are compatible with the PM8350c PWM modules,
> document the PM8350c PWM compatible as fallback for the PM8550 PWM.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---------
> 1 file changed, 18 insertions(+), 12 deletions(-)
Doesn't seem to want to apply.
Please rebase onto:
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/log/?h=for-leds-next
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-25 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 16:26 [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible Neil Armstrong
2023-05-22 17:39 ` Conor Dooley
2023-05-22 18:00 ` Neil Armstrong
2023-05-25 11:23 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).