* Re: [PATCH] microblaze: Remove architecture heart beat code [not found] <84075652e978661247d71f84de46efd827869948.1528697370.git.michal.simek@xilinx.com> @ 2018-06-11 8:46 ` Linus Walleij 2018-06-11 8:52 ` Geert Uytterhoeven 0 siblings, 1 reply; 2+ messages in thread From: Linus Walleij @ 2018-06-11 8:46 UTC (permalink / raw) To: Michal Simek, linux-m68k Cc: linux-kernel, Michal Simek, Rob Herring, Thomas Gleixner, Philippe Ombredanne, U-Boot Mailing List, Neil Armstrong, Kate Stewart, Greg Kroah-Hartman, Matthias Brugger, Daniel Lezcano On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek <michal.simek@xilinx.com> wrote: > There is no reason to keep this gpio based code in architecture. Use > ledtrig-heartbeat.c instead which is much more flexible then this > ancient code. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Maybe the arch maintainers will complain that the corresponding new heartbeat code is not put in place in the same patch, but I think the change is so much overdue that I don't see why they can't do that themselves if they have interest in it. BTW: m68k has the same kind of luggage, in the middle of it timekeeping code: arch/m68k/kernel/time.c Yours, Linus Walleij ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] microblaze: Remove architecture heart beat code 2018-06-11 8:46 ` [PATCH] microblaze: Remove architecture heart beat code Linus Walleij @ 2018-06-11 8:52 ` Geert Uytterhoeven 0 siblings, 0 replies; 2+ messages in thread From: Geert Uytterhoeven @ 2018-06-11 8:52 UTC (permalink / raw) To: Linus Walleij Cc: Michal Simek, Linux/m68k, Linux Kernel Mailing List, Michal Simek, Rob Herring, Thomas Gleixner, Philippe Ombredanne, U-Boot Mailing List, Neil Armstrong, Kate Stewart, Greg KH, Matthias Brugger, Daniel Lezcano Hi Linus, On Mon, Jun 11, 2018 at 10:47 AM Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek <michal.simek@xilinx.com> wrote: > > There is no reason to keep this gpio based code in architecture. Use > > ledtrig-heartbeat.c instead which is much more flexible then this > > ancient code. > > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Maybe the arch maintainers will complain that the corresponding > new heartbeat code is not put in place in the same patch, but I > think the change is so much overdue that I don't see why they > can't do that themselves if they have interest in it. > > BTW: m68k has the same kind of luggage, in the middle of it > timekeeping code: > arch/m68k/kernel/time.c Fixing that means converting m68k to GPIO first, which would take lots of heartbeats ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-11 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <84075652e978661247d71f84de46efd827869948.1528697370.git.michal.simek@xilinx.com>
2018-06-11 8:46 ` [PATCH] microblaze: Remove architecture heart beat code Linus Walleij
2018-06-11 8:52 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).