From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level
Date: Tue, 20 Apr 2021 10:35:23 +0200 [thread overview]
Message-ID: <20210420083522.GA1411@agape.jhs> (raw)
In-Reply-To: <4947abeebc2cecca43137675519a2fb48577d3e5.1618859059.git.drv@mailo.com>
Hi Deepak,
On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote:
> printk() without KERN_<LEVEL> facility is flagged by checkpatch as a
> warning. It is better to use pr_info() which comes with an
> inbuilt KERN_INFO level.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> index b572551f1a0d..a0f3c5c32f94 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> @@ -1020,7 +1020,7 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd,
> return -EINVAL;
> }
>
> - printk("%s: before gc0310_write_reg_array %s\n", __func__,
> + pr_info("%s: before gc0310_write_reg_array %s\n", __func__,
> gc0310_res[dev->fmt_idx].desc);
in a driver is best recommended to replace a raw printk call
with a dev_*() log. Check few lines above here to see
how it is done.
> ret = startup(sd);
> if (ret) {
> --
> 2.25.1
>
>
thank you,
fabio
next prev parent reply other threads:[~2021-04-20 8:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:11 [PATCH 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-19 19:12 ` [PATCH 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-20 13:24 ` Hans Verkuil
2021-04-20 17:19 ` Deepak R Varma
2021-04-20 20:59 ` Hans Verkuil
2021-04-21 10:19 ` Deepak R Varma
2021-04-19 19:13 ` [PATCH 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-19 19:14 ` [PATCH 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-19 19:15 ` [PATCH 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-20 8:44 ` Fabio Aiuto
2021-04-20 17:17 ` Deepak R Varma
2021-04-21 7:17 ` Fabio Aiuto
2021-04-28 7:53 ` Dan Carpenter
2021-04-19 19:15 ` [PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-20 8:39 ` Fabio Aiuto
2021-04-20 13:26 ` Hans Verkuil
2021-04-19 19:16 ` [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level Deepak R Varma
2021-04-20 8:35 ` Fabio Aiuto [this message]
2021-04-20 17:13 ` Deepak R Varma
2021-04-21 7:22 ` Fabio Aiuto
2021-04-21 10:16 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420083522.GA1411@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).