From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: media: atomisp: reformat code comment blocks
Date: Wed, 21 Apr 2021 09:17:15 +0200 [thread overview]
Message-ID: <20210421071713.GA1418@agape.jhs> (raw)
In-Reply-To: <20210420171729.GB193332@localhost>
On Tue, Apr 20, 2021 at 10:47:29PM +0530, Deepak R Varma wrote:
> On Tue, Apr 20, 2021 at 10:44:48AM +0200, Fabio Aiuto wrote:
> > On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote:
> > > Reformat code comment blocks according to the coding style guidelines.
> > > This resolves different checkpatch script WARNINGs around block comments.
> > >
> > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > ---
> > > .../media/atomisp/i2c/atomisp-gc2235.c | 8 +++----
> > > .../atomisp/i2c/atomisp-libmsrlisthelper.c | 3 ++-
> > > .../media/atomisp/i2c/atomisp-mt9m114.c | 22 +++++++++++--------
> > > .../media/atomisp/i2c/atomisp-ov2680.c | 3 ++-
> > > 4 files changed, 21 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> > > index 548c572d3b57..a585d73665a6 100644
> > > --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> > > @@ -747,10 +747,10 @@ static int startup(struct v4l2_subdev *sd)
> > >
> > > if (is_init == 0) {
> > > /* force gc2235 to do a reset in res change, otherwise it
> > > - * can not output normal after switching res. and it is not
> > > - * necessary for first time run up after power on, for the sack
> > > - * of performance
> > > - */
> > > + * can not output normal after switching res. and it is not
> > > + * necessary for first time run up after power on, for the sack
> > > + * of performance
> > > + */
> > > power_down(sd);
> > > power_up(sd);
> > > gc2235_write_reg_array(client, gc2235_init_settings);
> > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
> > > index b93c80471f22..750b3484eb19 100644
> > > --- a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
> > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c
> > > @@ -57,7 +57,8 @@ static int set_msr_configuration(struct i2c_client *client, uint8_t *bufptr,
> > > * By convention, the first two bytes of actual data should be
> > > * understood as an address in the sensor address space (hibyte
> > > * followed by lobyte) where the remaining data in the sequence
> > > - * will be written. */
> > > + * will be written.
> > > + */
> > >
> > > u8 *ptr = bufptr;
> > >
> > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> > > index 465fc4468442..160bb58ce708 100644
> > > --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> > > @@ -478,7 +478,8 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
> > > /* Note: current modules wire only one GPIO signal (RESET#),
> > > * but the schematic wires up two to the connector. BIOS
> > > * versions have been unfortunately inconsistent with which
> > > - * ACPI index RESET# is on, so hit both */
> > > + * ACPI index RESET# is on, so hit both
> > > + */
> > >
> > > if (flag) {
> > > ret = dev->platform_data->gpio0_ctrl(sd, 0);
> > > @@ -1019,8 +1020,8 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > > dev->first_gain = AnalogGain;
> > > dev->first_diggain = DigitalGain;
> > > }
> > > - /* DigitalGain = 0x400 * (((u16) DigitalGain) >> 8) +
> > > - ((unsigned int)(0x400 * (((u16) DigitalGain) & 0xFF)) >>8); */
> > > + /* DigitalGain = 0x400 * (((u16) DigitalGain) >> 8) + */
> > > + /* ((unsigned int)(0x400 * (((u16) DigitalGain) & 0xFF)) >>8); */
> > >
> > > /* set frame length */
> > > if (FLines < coarse_integration + 6)
> > > @@ -1035,7 +1036,8 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > >
> > > /* set coarse integration */
> > > /* 3A provide real exposure time.
> > > - should not translate to any value here. */
> > > + * should not translate to any value here.
> > > + */
> > > ret = mt9m114_write_reg(client, MISENSOR_16BIT,
> > > REG_EXPO_COARSE, (u16)(coarse_integration));
> > > if (ret) {
> > > @@ -1044,7 +1046,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > > }
> > >
> > > /*
> > > - // set analog/digital gain
> > > + * set analog/digital gain
> > > switch(AnalogGain)
> > > {
> > > case 0:
> > > @@ -1069,8 +1071,9 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > > */
> > > if (DigitalGain >= 16 || DigitalGain <= 1)
> > > DigitalGain = 1;
> > > - /* AnalogGainToWrite =
> > > - (u16)((DigitalGain << 12) | AnalogGainToWrite); */
> > > +
> > > + /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite);
> > > + */
> >
> > this is best recommended for one line comment:
> >
> > /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); */
>
> It then extends beyond 80 character in length. Will that be acceptable?
>
if the intention is to stay within 80 characters in length then it's better
/*
* AnalogGainToWrite = (u16)(DigitalGain << 12) | AnalogGainToWrite);
*/
thank you,
fabio
next prev parent reply other threads:[~2021-04-21 7:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:11 [PATCH 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-19 19:12 ` [PATCH 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-20 13:24 ` Hans Verkuil
2021-04-20 17:19 ` Deepak R Varma
2021-04-20 20:59 ` Hans Verkuil
2021-04-21 10:19 ` Deepak R Varma
2021-04-19 19:13 ` [PATCH 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-19 19:14 ` [PATCH 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-19 19:15 ` [PATCH 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-20 8:44 ` Fabio Aiuto
2021-04-20 17:17 ` Deepak R Varma
2021-04-21 7:17 ` Fabio Aiuto [this message]
2021-04-28 7:53 ` Dan Carpenter
2021-04-19 19:15 ` [PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-20 8:39 ` Fabio Aiuto
2021-04-20 13:26 ` Hans Verkuil
2021-04-19 19:16 ` [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level Deepak R Varma
2021-04-20 8:35 ` Fabio Aiuto
2021-04-20 17:13 ` Deepak R Varma
2021-04-21 7:22 ` Fabio Aiuto
2021-04-21 10:16 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421071713.GA1418@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).