From: Hans Verkuil <hverkuil@xs4all.nl>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: media: atomisp: improve function argument alignment
Date: Tue, 20 Apr 2021 22:59:16 +0200 [thread overview]
Message-ID: <2b4bffc8-7851-45aa-eb64-8f8d2d5928eb@xs4all.nl> (raw)
In-Reply-To: <20210420171943.GC193332@localhost>
On 20/04/2021 19:19, Deepak R Varma wrote:
> On Tue, Apr 20, 2021 at 03:24:32PM +0200, Hans Verkuil wrote:
>> On 19/04/2021 21:12, Deepak R Varma wrote:
>>> Improve multi-line function argument alignment according to the code style
>>> guidelines. Resolves checkpatch feedback: "Alignment should match
>>> open parenthesis".
>>>
>>> Signed-off-by: Deepak R Varma <drv@mailo.com>
>>
>> WARNING: From:/Signed-off-by: email address mismatch: 'From: Deepak R Varma <mh12gx2825@gmail.com>' != 'Signed-off-by: Deepak R Varma
>> <drv@mailo.com>'
>>
>> Which email should I use? Ideally you should post from the same email
>> as the Signed-off-by.
>
> I am really sorry for this. I was trying to set up mutt to handle both
> my accounts and guess that led to this issue. I will resubmit the patch
> set with the appropriate email match. Will that be okay?
It is sufficient to just let me know which email I should use. I can edit
it so it shows the correct author email.
Regards,
Hans
>
> Thank you,
> deepak.
>
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++--
>>> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++--
>>> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++--
>>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
>>> index 2b71de722ec3..6be3ee1d93a5 100644
>>> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
>>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
>>> @@ -192,8 +192,8 @@ static int __gc0310_buf_reg_array(struct i2c_client *client,
>>> }
>>>
>>> static int __gc0310_write_reg_is_consecutive(struct i2c_client *client,
>>> - struct gc0310_write_ctrl *ctrl,
>>> - const struct gc0310_reg *next)
>>> + struct gc0310_write_ctrl *ctrl,
>>> + const struct gc0310_reg *next)
>>> {
>>> if (ctrl->index == 0)
>>> return 1;
>>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>>> index 78147ffb6099..6ba4a8adff7c 100644
>>> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>>> @@ -171,8 +171,8 @@ static int __gc2235_buf_reg_array(struct i2c_client *client,
>>> }
>>>
>>> static int __gc2235_write_reg_is_consecutive(struct i2c_client *client,
>>> - struct gc2235_write_ctrl *ctrl,
>>> - const struct gc2235_reg *next)
>>> + struct gc2235_write_ctrl *ctrl,
>>> + const struct gc2235_reg *next)
>>> {
>>> if (ctrl->index == 0)
>>> return 1;
>>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>>> index eecefcd734d0..aec7392fd1de 100644
>>> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
>>> @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,
>>> }
>>>
>>> static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
>>> - struct ov2722_write_ctrl *ctrl,
>>> - const struct ov2722_reg *next)
>>> + struct ov2722_write_ctrl *ctrl,
>>> + const struct ov2722_reg *next)
>>> {
>>> if (ctrl->index == 0)
>>> return 1;
>>>
>>
next prev parent reply other threads:[~2021-04-20 20:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:11 [PATCH 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-19 19:12 ` [PATCH 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-20 13:24 ` Hans Verkuil
2021-04-20 17:19 ` Deepak R Varma
2021-04-20 20:59 ` Hans Verkuil [this message]
2021-04-21 10:19 ` Deepak R Varma
2021-04-19 19:13 ` [PATCH 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-19 19:14 ` [PATCH 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-19 19:15 ` [PATCH 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-20 8:44 ` Fabio Aiuto
2021-04-20 17:17 ` Deepak R Varma
2021-04-21 7:17 ` Fabio Aiuto
2021-04-28 7:53 ` Dan Carpenter
2021-04-19 19:15 ` [PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-20 8:39 ` Fabio Aiuto
2021-04-20 13:26 ` Hans Verkuil
2021-04-19 19:16 ` [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level Deepak R Varma
2021-04-20 8:35 ` Fabio Aiuto
2021-04-20 17:13 ` Deepak R Varma
2021-04-21 7:22 ` Fabio Aiuto
2021-04-21 10:16 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b4bffc8-7851-45aa-eb64-8f8d2d5928eb@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).