From: Antti Palosaari <crope@iki.fi>
To: Brad Love <brad@nextdimension.cc>,
linux-media@vger.kernel.org, mchehab@kernel.org
Subject: Re: [PATCH 04/13] si2157: Add clock and pin setup for si2141
Date: Sun, 20 Jan 2019 19:17:22 +0200 [thread overview]
Message-ID: <a0798756-26a2-ad91-9d29-ec314bbb50b9@iki.fi> (raw)
In-Reply-To: <1546105882-15693-5-git-send-email-brad@nextdimension.cc>
On 12/29/18 7:51 PM, Brad Love wrote:
> Include some missing setup for si2141
>
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
> drivers/media/tuners/si2157.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
> index f3a60a1..1ad2d42 100644
> --- a/drivers/media/tuners/si2157.c
> +++ b/drivers/media/tuners/si2157.c
> @@ -236,6 +236,23 @@ static int si2157_init(struct dvb_frontend *fe)
> dev_info(&client->dev, "firmware version: %c.%c.%d\n",
> cmd.args[6], cmd.args[7], cmd.args[8]);
>
> + if (dev->chiptype == SI2157_CHIPTYPE_SI2141) {
> + /* set clock */
> + memcpy(cmd.args, "\xc0\x00\x0d", 3);
> + cmd.wlen = 3;
> + cmd.rlen = 1;
> + ret = si2157_cmd_execute(client, &cmd);
> + if (ret)
> + goto err;
> + /* setup PIN */
> + memcpy(cmd.args, "\x12\x80\x80\x85\x00\x81\x00", 7);
> + cmd.wlen = 7;
> + cmd.rlen = 7;
> + ret = si2157_cmd_execute(client, &cmd);
> + if (ret)
> + goto err;
> + }
> +
> /* enable tuner status flags */
> memcpy(cmd.args, "\x14\x00\x01\x05\x01\x00", 6);
> cmd.wlen = 6;
>
Si2141 is working in my understanding, why these are required?
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2019-01-20 17:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 17:51 [PATCH 00/13] si2157: Analog tuning and optimizations Brad Love
2018-12-29 17:51 ` [PATCH 01/13] si2157: Enable tuner status flags Brad Love
2018-12-29 17:51 ` [PATCH 02/13] si2157: Check error status bit on cmd execute Brad Love
2019-01-09 18:01 ` Antti Palosaari
2019-01-15 17:28 ` Brad Love
2018-12-29 17:51 ` [PATCH 03/13] si2157: Better check for running tuner in init Brad Love
2018-12-29 17:51 ` [PATCH 04/13] si2157: Add clock and pin setup for si2141 Brad Love
2019-01-20 17:17 ` Antti Palosaari [this message]
2019-01-22 17:10 ` Brad Love
2018-12-29 17:51 ` [PATCH 05/13] cx25840: Register labeling, chip specific correction Brad Love
2018-12-29 17:51 ` [PATCH 06/13] si2157: Add analog tuning related functions Brad Love
2018-12-29 17:51 ` [PATCH 07/13] si2157: Briefly wait for tuning operation to complete Brad Love
2019-04-05 10:29 ` Sean Young
2019-04-08 18:14 ` Brad Love
2019-04-08 20:55 ` Sean Young
2019-04-08 21:37 ` Brad Love
2019-04-10 14:48 ` Brad Love
2018-12-29 17:51 ` [PATCH 08/13] cx23885: Add analog tuner support to Hauppauge QuadHD Brad Love
2018-12-29 17:51 ` [PATCH 09/13] cx23885: Add analog tuner to 1265_K4 Brad Love
2018-12-29 17:51 ` [PATCH 11/13] cx23885: Add i2c device analog tuner support Brad Love
2018-12-29 17:51 ` [PATCH 10/13] cx231xx: " Brad Love
2018-12-29 17:51 ` [PATCH 12/13] si2157: add on-demand rf strength func Brad Love
2019-01-20 19:09 ` Antti Palosaari
2018-12-29 17:51 ` [PATCH 13/13] lgdt3306a: Add CNR v5 stat Brad Love
2019-02-27 18:27 ` [PATCH v2 00/13] si2157: Analog tuning and optimizations Brad Love
2019-02-27 18:27 ` [PATCH v2 01/12] si2157: Enable tuner status flags Brad Love
2019-02-27 18:27 ` [PATCH v2 02/12] si2157: Check error status bit on cmd execute Brad Love
2019-02-27 18:27 ` [PATCH v2 03/12] si2157: Better check for running tuner in init Brad Love
2019-02-27 18:27 ` [PATCH v2 04/12] cx25840: Register labeling, chip specific correction Brad Love
2019-02-27 18:27 ` [PATCH v2 05/12] si2157: Add analog tuning related functions Brad Love
2019-04-05 13:24 ` Sean Young
2019-04-08 18:18 ` Brad Love
2019-02-27 18:27 ` [PATCH v2 06/12] si2157: Briefly wait for tuning operation to complete Brad Love
2019-02-27 18:27 ` [PATCH v2 07/12] cx23885: Add analog tuner support to Hauppauge QuadHD Brad Love
2019-02-27 18:27 ` [PATCH v2 08/12] cx23885: Add analog frontend to 1265_K4 Brad Love
2019-02-27 18:27 ` [PATCH v2 09/12] cx23885: Add i2c device analog tuner support Brad Love
2019-02-27 18:27 ` [PATCH v2 10/12] cx231xx: " Brad Love
2019-02-27 18:27 ` [PATCH v2 11/12] si2157: add on-demand rf strength func Brad Love
2019-02-27 18:27 ` [PATCH v2 12/12] lgdt3306a: Add CNR v5 stat Brad Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0798756-26a2-ad91-9d29-ec314bbb50b9@iki.fi \
--to=crope@iki.fi \
--cc=brad@nextdimension.cc \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).