* [PATCH v3 1/2] add dt-binding document for MediaTek Keypad
2020-04-05 2:01 [PATCH v3] Add support for MediaTek keypad Fengping yu
@ 2020-04-05 2:01 ` Fengping yu
2020-04-06 15:21 ` Yingjoe Chen
2020-04-05 2:01 ` [PATCH v3 2/2] add MediaTek keypad driver Fengping yu
2020-04-06 13:04 ` [PATCH v3] Add support for MediaTek keypad Andy Shevchenko
2 siblings, 1 reply; 5+ messages in thread
From: Fengping yu @ 2020-04-05 2:01 UTC (permalink / raw)
To: Dmitry Torokhov, Andy Shevchenko, Yingjoe Chen
Cc: fengping.yu, linux-mediatek, linux-kernel, wsd_upstream
From: "fengping.yu" <fengping.yu@mediatek.com>
Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
---
.../devicetree/bindings/input/mtk-kpd.txt | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.txt b/Documentation/devicetree/bindings/input/mtk-kpd.txt
new file mode 100644
index 000000000000..8b154a5e2f7d
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/mtk-kpd.txt
@@ -0,0 +1,61 @@
+* Mediatek's Keypad Controller device tree binding
+
+Mediatek's Keypad controller is used to interface a SoC with a matrix-type
+keypad device. The keypad controller supports multiple row and column lines.
+A key can be placed at each intersection of a unique row and a unique column.
+The keypad controller can sense a key-press and key-release and report the
+event using a interrupt to the cpu.
+
+Required properties:
+- compatible should contain:
+ * "mediatek,kp" for common keypad
+ * "mediatek,mt6779-keypad" for specific keypad chip
+
+- reg: The base address of the Keypad register bank.
+
+- interrupts: A single interrupt specifier.
+
+- mediatek,debounce-us: Debounce interval in microseconds, maximum value
+ is 256000 microseconds.
+
+- keypad,num-rows: Number of row lines connected to the keypad controller, it is
+ not equal to PCB rows number, instead you should add required value for each IC.
+
+- keypad,num-columns: Number of column lines connected to the keypad controller,
+ it is not equal to PCB columns number, instead you should add required value
+ for each IC.
+
+- linux,keymap: The keymap for keys as described in the binding document
+ devicetree/bindings/input/matrix-keymap.txt.
+
+- pinctrl: Should specify pin control groups used for this controller.
+ See ../pinctrl/pinctrl-bindings.txt for details.
+
+- clocks: Must contain one entry, for the module clock.
+ See ../clocks/clock-bindings.txt for details.
+
+- clock-names: Names of the clocks listed in clocks property in the same order.
+
+Optional Properties:
+- wakeup-source: use any event on keypad as wakeup event.
+
+Example:
+
+ keypad: kp@10010000 {
+ compatible = "mediatek,kp";
+ reg = <0 0x10010000 0 0x1000>;
+ wakeup-source;
+ interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>;
+ clocks = <&clk26m>;
+ clock-names = "kpd";
+ };
+
+ &keypad {
+ mediatek,debounce-us = <32000>;
+ keypad,num-rows = <8>;
+ keypad,num-columns = <9>;
+ linux,keymap = < MATRIX_KEY(0x00, 0x00, KEY_VOLUMEDOWN) >;
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&kpd_gpios_def_cfg>;
+ };
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3 2/2] add MediaTek keypad driver
2020-04-05 2:01 [PATCH v3] Add support for MediaTek keypad Fengping yu
2020-04-05 2:01 ` [PATCH v3 1/2] add dt-binding document for MediaTek Keypad Fengping yu
@ 2020-04-05 2:01 ` Fengping yu
2020-04-06 13:04 ` [PATCH v3] Add support for MediaTek keypad Andy Shevchenko
2 siblings, 0 replies; 5+ messages in thread
From: Fengping yu @ 2020-04-05 2:01 UTC (permalink / raw)
To: Dmitry Torokhov, Andy Shevchenko, Yingjoe Chen
Cc: fengping.yu, linux-mediatek, linux-kernel, wsd_upstream
From: "fengping.yu" <fengping.yu@mediatek.com>
Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
---
arch/arm64/configs/defconfig | 1 +
drivers/input/keyboard/Kconfig | 7 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/mtk-kpd.c | 258 +++++++++++++++++++++++++++++++
4 files changed, 267 insertions(+)
create mode 100644 drivers/input/keyboard/mtk-kpd.c
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 0f212889c931..7863352521e5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -316,6 +316,7 @@ CONFIG_KEYBOARD_GPIO=y
CONFIG_KEYBOARD_SNVS_PWRKEY=m
CONFIG_KEYBOARD_IMX_SC_KEY=m
CONFIG_KEYBOARD_CROS_EC=y
+CONFIG_KEYBOARD_MTK_KPD=y
CONFIG_INPUT_TOUCHSCREEN=y
CONFIG_TOUCHSCREEN_ATMEL_MXT=m
CONFIG_INPUT_MISC=y
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 4706ff09f0e8..0ddb753f7d7e 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -772,6 +772,13 @@ config KEYBOARD_BCM
To compile this driver as a module, choose M here: the
module will be called bcm-keypad.
+config KEYBOARD_MTK_KPD
+ tristate "MediaTek Keypad Support"
+ help
+ Say Y here if you want to use the keypad.
+ If unuse, say N.
+ To compile this driver as a module, choose M here: the
+ module will be called mtk-kpd.
config KEYBOARD_MTK_PMIC
tristate "MediaTek PMIC keys support"
depends on MFD_MT6397
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index f5b17524adf2..63324d3e36c5 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -42,6 +42,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o
obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o
obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o
obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o
+obj-$(CONFIG_KEYBOARD_MTK_KPD) += mtk-kpd.o
obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o
obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o
obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.o
diff --git a/drivers/input/keyboard/mtk-kpd.c b/drivers/input/keyboard/mtk-kpd.c
new file mode 100644
index 000000000000..8c27d07c9e7f
--- /dev/null
+++ b/drivers/input/keyboard/mtk-kpd.c
@@ -0,0 +1,258 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2019 MediaTek Inc.
+ * Author Terry Chang <terry.chang@mediatek.com>
+ */
+#include <linux/clk.h>
+#include <linux/fs.h>
+#include <linux/gpio.h>
+#include <linux/init.h>
+#include <linux/input/matrix_keypad.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/platform_device.h>
+
+#define KPD_NAME "mtk-kpd"
+
+#define KP_STA 0x0000
+#define KP_MEM 0x0004
+#define KP_DEBOUNCE 0x0018
+
+#define KPD_DEBOUNCE_MASK GENMASK(13, 0)
+#define KPD_DEBOUNCE_MAX 256000
+#define KPD_NUM_MEMS 5
+#define KPD_NUM_BITS 136 /* 4 * 32 + 8 MEM5 only use 8 BITS */
+#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32))
+
+struct mtk_keypad {
+ struct input_dev *input_dev;
+ struct clk *clk;
+ void __iomem *base;
+ unsigned int irqnr;
+ bool wakeup;
+ u32 key_debounce;
+ u32 n_rows;
+ u32 n_cols;
+ DECLARE_BITMAP(keymap_state, KPD_NUM_BITS);
+};
+
+static irqreturn_t kpd_irq_handler(int irq, void *dev_id)
+{
+ /* use _nosync to avoid deadlock */
+ struct mtk_keypad *keypad = dev_id;
+ unsigned short *keycode = keypad->input_dev->keycode;
+ DECLARE_BITMAP(new_state, KPD_NUM_BITS);
+ DECLARE_BITMAP(change, KPD_NUM_BITS);
+ int bit_nr;
+ int pressed;
+ unsigned short code;
+
+ disable_irq_nosync(keypad->irqnr);
+
+ memcpy_fromio(new_state, keypad->base + KP_MEM, KPD_NUM_MEMS);
+
+ bitmap_xor(change, new_state, keypad->keymap_state, KPD_NUM_BITS);
+
+ for_each_set_bit(bit_nr, change, KPD_NUM_BITS) {
+ pressed = test_bit(bit_nr, new_state) == 0U;
+ dev_dbg(&keypad->input_dev->dev, "%s",
+ pressed ? "pressed" : "released");
+
+ /* per 32bit register only use low 16bit as keypad mem register */
+ code = keycode[bit_nr - 16 * (BITS_TO_U32(bit_nr) - 1)];
+
+ input_report_key(keypad->input_dev, code, pressed);
+ input_sync(keypad->input_dev);
+
+ dev_dbg(&keypad->input_dev->dev,
+ "report Linux keycode = %d\n", code);
+ }
+
+ bitmap_copy(keypad->keymap_state, new_state, KPD_NUM_BITS);
+
+ enable_irq(keypad->irqnr);
+
+ return IRQ_HANDLED;
+}
+
+static int kpd_get_dts_info(struct mtk_keypad *keypad)
+{
+ int ret;
+ struct device *dev = keypad->input_dev->dev.parent;
+ struct device_node *node = dev->of_node;
+
+ ret = matrix_keypad_parse_properties(dev, &keypad->n_rows,
+ &keypad->n_cols);
+
+ if (ret) {
+ dev_err(dev, "failed to parse keypad params.\n");
+ return ret;
+ }
+
+ ret = of_property_read_u32(node, "mediatek,debounce-us",
+ &keypad->key_debounce);
+ if (ret) {
+ dev_err(dev, "read mediatek,debounce-us error.\n");
+ return ret;
+ }
+
+ if (keypad->key_debounce > KPD_DEBOUNCE_MAX) {
+ dev_err(dev, "debounce time exceeds the maximum allowed time 256ms.\n");
+ return -EINVAL;
+ }
+
+ keypad->wakeup = of_property_read_bool(node, "wakeup-source");
+
+ dev_dbg(dev, "n_row=%d n_col=%d debounce=%d.\n",
+ keypad->n_rows, keypad->n_cols,
+ keypad->key_debounce);
+
+ return 0;
+}
+
+static int kpd_gpio_init(struct device *dev)
+{
+ struct pinctrl *keypad_pinctrl;
+ struct pinctrl_state *kpd_default;
+
+ keypad_pinctrl = devm_pinctrl_get(dev);
+ if (IS_ERR(keypad_pinctrl)) {
+ dev_err(dev, "Cannot find keypad_pinctrl!\n");
+ return PTR_ERR(keypad_pinctrl);
+ }
+
+ kpd_default = pinctrl_lookup_state(keypad_pinctrl, "default");
+ if (IS_ERR(kpd_default)) {
+ dev_err(dev, "Cannot find ecall_state!\n");
+ return PTR_ERR(kpd_default);
+ }
+
+ return pinctrl_select_state(keypad_pinctrl, kpd_default);
+}
+
+static int kpd_pdrv_probe(struct platform_device *pdev)
+{
+ struct mtk_keypad *keypad;
+ int ret;
+
+ keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
+ if (!keypad)
+ return -ENOMEM;
+
+ bitmap_fill(keypad->keymap_state, KPD_NUM_BITS);
+
+ keypad->input_dev = devm_input_allocate_device(&pdev->dev);
+ if (!keypad->input_dev) {
+ dev_err(&pdev->dev, "input allocate device fail.\n");
+ return -ENOMEM;
+ }
+
+ keypad->input_dev->name = KPD_NAME;
+ keypad->input_dev->id.bustype = BUS_HOST;
+ keypad->input_dev->dev.parent = &pdev->dev;
+
+ ret = kpd_get_dts_info(keypad);
+ if (ret) {
+ dev_err(&pdev->dev, "get dts info failed.\n");
+ return ret;
+ }
+
+ ret = matrix_keypad_build_keymap(NULL, NULL,
+ keypad->n_rows,
+ keypad->n_cols,
+ NULL,
+ keypad->input_dev);
+
+ if (ret) {
+ dev_err(&pdev->dev, "build keymap failed.\n");
+ return ret;
+ }
+
+ input_set_drvdata(keypad->input_dev, keypad);
+
+ keypad->base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(keypad->base)) {
+ dev_err(&pdev->dev, "KP iomap failed\n");
+ return PTR_ERR(keypad->base);
+ }
+
+ if (keypad->key_debounce > KPD_DEBOUNCE_MAX) {
+ dev_err(&pdev->dev, "invalid debounce time value.\n");
+ return -EINVAL;
+ }
+
+ writew(keypad->key_debounce * 32 / 1000 & KPD_DEBOUNCE_MASK,
+ keypad->base + KP_DEBOUNCE);
+
+ keypad->clk = devm_clk_get(&pdev->dev, "kpd");
+ if (IS_ERR(keypad->clk)) {
+ dev_err(&pdev->dev, "get kpd-clk fail.\n");
+ return PTR_ERR(keypad->clk);
+ }
+
+ ret = clk_prepare_enable(keypad->clk);
+ if (ret) {
+ dev_err(&pdev->dev, "kpd-clk enable failed.\n");
+ return ret;
+ }
+
+ ret = kpd_gpio_init(&pdev->dev);
+ if (ret) {
+ dev_err(&pdev->dev, "gpio init failed\n");
+ goto disable_kpd_clk;
+ }
+
+ keypad->irqnr = platform_get_irq(pdev, 0);
+ if (keypad->irqnr < 0) {
+ dev_err(&pdev->dev, "KP get irqnr failed\n");
+ ret = -keypad->irqnr;
+ goto disable_kpd_clk;
+ }
+
+ ret = devm_request_irq(&pdev->dev, keypad->irqnr,
+ kpd_irq_handler, 0,
+ KPD_NAME, keypad);
+ if (ret) {
+ dev_err(&pdev->dev, "register IRQ failed.\n");
+ goto disable_kpd_clk;
+ }
+
+ ret = input_register_device(keypad->input_dev);
+ if (ret) {
+ dev_err(&pdev->dev, "register input device failed.\n");
+ goto disable_kpd_clk;
+ }
+
+ device_init_wakeup(&pdev->dev, keypad->wakeup);
+
+ platform_set_drvdata(pdev, keypad);
+
+ return 0;
+
+disable_kpd_clk:
+ clk_disable_unprepare(keypad->clk);
+ return ret;
+}
+
+static const struct of_device_id kpd_of_match[] = {
+ {.compatible = "mediatek,kp"},
+ {}
+};
+
+static struct platform_driver kpd_pdrv = {
+ .probe = kpd_pdrv_probe,
+ .driver = {
+ .name = KPD_NAME,
+ .of_match_table = kpd_of_match,
+ },
+};
+
+module_platform_driver(kpd_pdrv);
+
+MODULE_AUTHOR("Mediatek Corporation");
+MODULE_DESCRIPTION("MTK Keypad (KPD) Driver");
+MODULE_LICENSE("GPL");
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 5+ messages in thread