* [PATCH v1 1/2] gpio: loongson: add dts/acpi gpio support
@ 2022-11-08 9:21 Yinbo Zhu
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
0 siblings, 1 reply; 6+ messages in thread
From: Yinbo Zhu @ 2022-11-08 9:21 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, WANG Xuerui, Jiaxun Yang,
Thomas Bogendoerfer, Juxin Gao, Bibo Mao, Yanteng Si, linux-gpio,
devicetree, linux-kernel, loongarch, linux-mips, richard.liu,
Arnaud Patard, Hongbing Hu, Huacai Chen, Yinbo Zhu
Cc: lvjianmin, zhanghongchen, Liu Peibao
The latest Loongson series platform use dts or acpi framework to
register gpio device resources, such as the Loongson-2 series
SoC of LOONGARCH architecture. In order to support dts, acpi and
compatibility with previous platform device resources in driver,
this patch was added.
Signed-off-by: lvjianmin <lvjianmin@loongson.cn>
Signed-off-by: zhanghongchen <zhanghongchen@loongson.cn>
Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
Signed-off-by: Juxin Gao <gaojuxin@loongson.cn>
Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
---
arch/loongarch/include/asm/loongson.h | 13 +
.../include/asm/mach-loongson2ef/loongson.h | 12 +
.../include/asm/mach-loongson64/loongson.h | 13 +
drivers/gpio/Kconfig | 6 +-
drivers/gpio/gpio-loongson.c | 418 +++++++++++++++---
5 files changed, 387 insertions(+), 75 deletions(-)
diff --git a/arch/loongarch/include/asm/loongson.h b/arch/loongarch/include/asm/loongson.h
index 00db93edae1b..383fdda155f0 100644
--- a/arch/loongarch/include/asm/loongson.h
+++ b/arch/loongarch/include/asm/loongson.h
@@ -60,6 +60,19 @@ static inline void xconf_writeq(u64 val64, volatile void __iomem *addr)
);
}
+/* ============== Data structrues =============== */
+
+/* gpio data */
+struct platform_gpio_data {
+ u32 gpio_conf;
+ u32 gpio_out;
+ u32 gpio_in;
+ u32 support_irq;
+ char *label;
+ int gpio_base;
+ int ngpio;
+};
+
/* ============== LS7A registers =============== */
#define LS7A_PCH_REG_BASE 0x10000000UL
/* LPC regs */
diff --git a/arch/mips/include/asm/mach-loongson2ef/loongson.h b/arch/mips/include/asm/mach-loongson2ef/loongson.h
index ca039b8dcde3..b261cea4fee1 100644
--- a/arch/mips/include/asm/mach-loongson2ef/loongson.h
+++ b/arch/mips/include/asm/mach-loongson2ef/loongson.h
@@ -315,4 +315,16 @@ extern unsigned long _loongson_addrwincfg_base;
#endif /* ! CONFIG_CPU_SUPPORTS_ADDRWINCFG */
+/* ============== Data structrues =============== */
+
+/* gpio data */
+struct platform_gpio_data {
+ u32 gpio_conf;
+ u32 gpio_out;
+ u32 gpio_in;
+ u32 support_irq;
+ char *label;
+ int gpio_base;
+ int ngpio;
+};
#endif /* __ASM_MACH_LOONGSON2EF_LOONGSON_H */
diff --git a/arch/mips/include/asm/mach-loongson64/loongson.h b/arch/mips/include/asm/mach-loongson64/loongson.h
index f7c3ab6d724e..b9f8a95aff64 100644
--- a/arch/mips/include/asm/mach-loongson64/loongson.h
+++ b/arch/mips/include/asm/mach-loongson64/loongson.h
@@ -12,6 +12,19 @@
#include <linux/irq.h>
#include <boot_param.h>
+/* ============== Data structrues =============== */
+
+/* gpio data */
+struct platform_gpio_data {
+ u32 gpio_conf;
+ u32 gpio_out;
+ u32 gpio_in;
+ u32 support_irq;
+ char *label;
+ int gpio_base;
+ int ngpio;
+};
+
enum loongson_fw_interface {
LOONGSON_LEFI,
LOONGSON_DTB,
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a01af1180616..fb8f0075a8ae 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -376,10 +376,10 @@ config GPIO_LOGICVC
programmable logic block.
config GPIO_LOONGSON
- bool "Loongson-2/3 GPIO support"
- depends on CPU_LOONGSON2EF || CPU_LOONGSON64
+ bool "Loongson series GPIO support"
+ depends on CPU_LOONGSON2EF || CPU_LOONGSON64 || LOONGARCH
help
- Driver for GPIO functionality on Loongson-2F/3A/3B processors.
+ Driver for GPIO functionality on Loongson seires processors.
config GPIO_LPC18XX
tristate "NXP LPC18XX/43XX GPIO support"
diff --git a/drivers/gpio/gpio-loongson.c b/drivers/gpio/gpio-loongson.c
index a42145873cc9..679ed9665d8c 100644
--- a/drivers/gpio/gpio-loongson.c
+++ b/drivers/gpio/gpio-loongson.c
@@ -1,13 +1,14 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * Loongson-2F/3A/3B GPIO Support
+ * Loongson Series GPIO Support
*
- * Copyright (c) 2008 Richard Liu, STMicroelectronics <richard.liu@st.com>
+ * Copyright (c) 2008 Richard Liu, STMicroelectronics <richard.liu@st.com>
* Copyright (c) 2008-2010 Arnaud Patard <apatard@mandriva.com>
* Copyright (c) 2013 Hongbing Hu <huhb@lemote.com>
* Copyright (c) 2014 Huacai Chen <chenhc@lemote.com>
*/
+#include <linux/acpi.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>
@@ -17,119 +18,392 @@
#include <linux/platform_device.h>
#include <linux/bitops.h>
#include <asm/types.h>
-#include <loongson.h>
-
-#define STLS2F_N_GPIO 4
-#define STLS3A_N_GPIO 16
-
-#ifdef CONFIG_CPU_LOONGSON64
-#define LOONGSON_N_GPIO STLS3A_N_GPIO
+#if defined(CONFIG_LOONGARCH)
+#include <asm/loongson.h>
+#elif defined(CONFIG_CPU_LOONGSON2EF)
+#include <asm/mach-loongson2ef/loongson.h>
#else
-#define LOONGSON_N_GPIO STLS2F_N_GPIO
+#include <asm/mach-loongson64/loongson.h>
#endif
-/*
- * Offset into the register where we read lines, we write them from offset 0.
- * This offset is the only thing that stand between us and using
- * GPIO_GENERIC.
- */
-#define LOONGSON_GPIO_IN_OFFSET 16
+#define LOONGSON_GPIO_IN(x) (x->base + x->in_offset)
+#define LOONGSON_GPIO_OUT(x) (x->base + x->out_offset)
+#define LOONGSON_GPIO_OEN(x) (x->base + x->conf_offset)
+
+#define LOONGSON_GPIO_IN_BYTE(x, gpio) (x->base +\
+ x->in_offset + gpio)
+#define LOONGSON_GPIO_OUT_BYTE(x, gpio) (x->base +\
+ x->out_offset + gpio)
+#define LOONGSON_GPIO_OEN_BYTE(x, gpio) (x->base +\
+ x->conf_offset + gpio)
+
+struct loongson_gpio_chip {
+ struct gpio_chip chip;
+ spinlock_t lock;
+ void __iomem *base;
+ int conf_offset;
+ int out_offset;
+ int in_offset;
+ u16 *gsi_idx_map;
+ u16 mapsize;
+ bool support_irq;
+};
-static DEFINE_SPINLOCK(gpio_lock);
+static int loongson_gpio_request(
+ struct gpio_chip *chip, unsigned int pin)
+{
+ if (pin >= chip->ngpio)
+ return -EINVAL;
+ else
+ return 0;
+}
-static int loongson_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
+static inline void __set_direction(struct loongson_gpio_chip *lgpio,
+ unsigned int pin, int input)
{
- u32 val;
+ u64 qval;
+ u8 bval;
+
+ if (!strcmp(lgpio->chip.label, "loongson,ls2k-gpio")) {
+ qval = readq(LOONGSON_GPIO_OEN(lgpio));
+ if (input)
+ qval |= 1ULL << pin;
+ else
+ qval &= ~(1ULL << pin);
+ writeq(qval, LOONGSON_GPIO_OEN(lgpio));
+ return;
+ }
- spin_lock(&gpio_lock);
- val = LOONGSON_GPIODATA;
- spin_unlock(&gpio_lock);
+ if (!strcmp(lgpio->chip.label, "loongson,ls7a-gpio") ||
+ !strncmp(lgpio->chip.label, "LOON0002", 8)) {
+ if (input)
+ bval = 1;
+ else
+ bval = 0;
+ writeb(bval, LOONGSON_GPIO_OEN_BYTE(lgpio, pin));
+ return;
+ }
- return !!(val & BIT(gpio + LOONGSON_GPIO_IN_OFFSET));
+ if (!strcmp(lgpio->chip.label, "loongson,platform-gpio")) {
+ if (input)
+ LOONGSON_GPIOIE |= BIT(pin);
+ else
+ LOONGSON_GPIOIE &= ~BIT(pin);
+ return;
+ }
}
-static void loongson_gpio_set_value(struct gpio_chip *chip,
- unsigned gpio, int value)
+static void __set_level(struct loongson_gpio_chip *lgpio, unsigned int pin,
+ int high)
{
- u32 val;
+ u64 qval;
+ u8 bval;
- spin_lock(&gpio_lock);
- val = LOONGSON_GPIODATA;
- if (value)
- val |= BIT(gpio);
- else
- val &= ~BIT(gpio);
- LOONGSON_GPIODATA = val;
- spin_unlock(&gpio_lock);
+ if (!strcmp(lgpio->chip.label, "loongson,ls2k-gpio")) {
+ qval = readq(LOONGSON_GPIO_OUT(lgpio));
+ if (high)
+ qval |= 1ULL << pin;
+ else
+ qval &= ~(1ULL << pin);
+ writeq(qval, LOONGSON_GPIO_OUT(lgpio));
+ return;
+ }
+
+ if (!strcmp(lgpio->chip.label, "loongson,ls7a-gpio") ||
+ !strncmp(lgpio->chip.label, "LOON0002", 8)) {
+ if (high)
+ bval = 1;
+ else
+ bval = 0;
+ writeb(bval, LOONGSON_GPIO_OUT_BYTE(lgpio, pin));
+ return;
+ }
+
+ if (!strcmp(lgpio->chip.label, "loongson,platform-gpio")) {
+ if (LOONGSON_GPIODATA)
+ LOONGSON_GPIODATA |= BIT(pin);
+ else
+ LOONGSON_GPIODATA &= ~BIT(pin);
+ return;
+ }
}
-static int loongson_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)
+static int loongson_gpio_direction_input(
+ struct gpio_chip *chip, unsigned int pin)
{
- u32 temp;
+ unsigned long flags;
+ struct loongson_gpio_chip *lgpio =
+ container_of(chip, struct loongson_gpio_chip, chip);
- spin_lock(&gpio_lock);
- temp = LOONGSON_GPIOIE;
- temp |= BIT(gpio);
- LOONGSON_GPIOIE = temp;
- spin_unlock(&gpio_lock);
+ spin_lock_irqsave(&lgpio->lock, flags);
+ __set_direction(lgpio, pin, 1);
+ spin_unlock_irqrestore(&lgpio->lock, flags);
return 0;
}
-static int loongson_gpio_direction_output(struct gpio_chip *chip,
- unsigned gpio, int level)
+static int loongson_gpio_direction_output(
+ struct gpio_chip *chip, unsigned int pin,
+ int value)
{
- u32 temp;
+ struct loongson_gpio_chip *lgpio =
+ container_of(chip, struct loongson_gpio_chip, chip);
+ unsigned long flags;
+
+ spin_lock_irqsave(&lgpio->lock, flags);
+ __set_level(lgpio, pin, value);
+ __set_direction(lgpio, pin, 0);
+ spin_unlock_irqrestore(&lgpio->lock, flags);
+
+ return 0;
+}
+
+static int loongson_gpio_get(struct gpio_chip *chip, unsigned int pin)
+{
+ u64 qval;
+ u8 bval;
+ int val;
+ struct loongson_gpio_chip *lgpio =
+ container_of(chip, struct loongson_gpio_chip, chip);
+
+ if (!strcmp(lgpio->chip.label, "loongson,ls2k-gpio")) {
+ qval = readq(LOONGSON_GPIO_IN(lgpio));
+ return ((qval & (1ULL << pin)) != 0);
+ }
+
+ if (!strcmp(lgpio->chip.label, "loongson,ls7a-gpio") ||
+ !strncmp(lgpio->chip.label, "LOON0002", 8)) {
+ bval = readb(LOONGSON_GPIO_IN_BYTE(lgpio, pin));
+ return (bval & 1);
+ }
+
+ if (!strcmp(lgpio->chip.label, "loongson,platform-gpio")) {
+ val = LOONGSON_GPIODATA;
+ return !!(val & BIT(pin + lgpio->in_offset));
+ }
+
+ return -ENXIO;
+}
+
+static void loongson_gpio_set(struct gpio_chip *chip, unsigned int pin,
+ int value)
+{
+ unsigned long flags;
+ struct loongson_gpio_chip *lgpio =
+ container_of(chip, struct loongson_gpio_chip, chip);
+
+ spin_lock_irqsave(&lgpio->lock, flags);
+ __set_level(lgpio, pin, value);
+ spin_unlock_irqrestore(&lgpio->lock, flags);
+}
+
+static int loongson_gpio_to_irq(
+ struct gpio_chip *chip, unsigned int offset)
+{
+ struct platform_device *pdev =
+ container_of(chip->parent, struct platform_device, dev);
+ struct loongson_gpio_chip *lgpio =
+ container_of(chip, struct loongson_gpio_chip, chip);
+
+ if (offset >= chip->ngpio)
+ return -EINVAL;
+
+ if ((lgpio->gsi_idx_map != NULL) && (offset < lgpio->mapsize))
+ offset = lgpio->gsi_idx_map[offset];
+
+ return platform_get_irq(pdev, offset);
+}
+
+static int loongson_gpio_init(
+ struct device *dev, struct loongson_gpio_chip *lgpio,
+ struct device_node *np, void __iomem *base)
+{
+ lgpio->chip.request = loongson_gpio_request;
+ lgpio->chip.direction_input = loongson_gpio_direction_input;
+ lgpio->chip.get = loongson_gpio_get;
+ lgpio->chip.direction_output = loongson_gpio_direction_output;
+ lgpio->chip.set = loongson_gpio_set;
+ lgpio->chip.can_sleep = 0;
+ lgpio->chip.of_node = np;
+ lgpio->chip.parent = dev;
+ spin_lock_init(&lgpio->lock);
+ lgpio->base = (void __iomem *)base;
+
+ if (!strcmp(lgpio->chip.label, "loongson,ls7a-gpio") ||
+ !strncmp(lgpio->chip.label, "LOON0002", 8) ||
+ !strcmp(lgpio->chip.label, "loongson,ls2k-gpio"))
+ lgpio->chip.to_irq = loongson_gpio_to_irq;
- loongson_gpio_set_value(chip, gpio, level);
- spin_lock(&gpio_lock);
- temp = LOONGSON_GPIOIE;
- temp &= ~BIT(gpio);
- LOONGSON_GPIOIE = temp;
- spin_unlock(&gpio_lock);
+ gpiochip_add(&lgpio->chip);
return 0;
}
+static void of_loongson_gpio_get_props(struct device_node *np,
+ struct loongson_gpio_chip *lgpio)
+{
+ const char *name;
+
+ of_property_read_u32(np, "ngpios", (u32 *)&lgpio->chip.ngpio);
+ of_property_read_u32(np, "loongson,gpio_base",
+ (u32 *)&lgpio->chip.base);
+ of_property_read_u32(np, "loongson,conf_offset",
+ (u32 *)&lgpio->conf_offset);
+ of_property_read_u32(np, "loongson,out_offset",
+ (u32 *)&lgpio->out_offset);
+ of_property_read_u32(np, "loongson,in_offset",
+ (u32 *)&lgpio->in_offset);
+ of_property_read_string(np, "compatible", &name);
+
+ if (!strcmp(name, "loongson,ls2k-gpio"))
+ if (of_property_read_bool(np, "loongson,support_irq"))
+ lgpio->support_irq = true;
+
+ lgpio->chip.label = kstrdup(name, GFP_KERNEL);
+}
+
+static void acpi_loongson_gpio_get_props(struct platform_device *pdev,
+ struct loongson_gpio_chip *lgpio)
+{
+
+ struct device *dev = &pdev->dev;
+ int rval;
+
+ device_property_read_u32(dev, "ngpios", (u32 *)&lgpio->chip.ngpio);
+ device_property_read_u32(dev, "gpio_base", (u32 *)&lgpio->chip.base);
+ device_property_read_u32(dev, "conf_offset",
+ (u32 *)&lgpio->conf_offset);
+ device_property_read_u32(dev, "out_offset",
+ (u32 *)&lgpio->out_offset);
+ device_property_read_u32(dev, "in_offset", (u32 *)&lgpio->in_offset);
+
+ rval = device_property_read_u16_array(dev, "gsi_idx_map", NULL, 0);
+ if (rval > 0) {
+ lgpio->gsi_idx_map =
+ kmalloc_array(rval, sizeof(*lgpio->gsi_idx_map),
+ GFP_KERNEL);
+ if (unlikely(!lgpio->gsi_idx_map)) {
+ dev_err(dev, "Alloc gsi_idx_map fail!\n");
+ } else {
+ lgpio->mapsize = rval;
+ device_property_read_u16_array(dev, "gsi_idx_map",
+ lgpio->gsi_idx_map, lgpio->mapsize);
+ }
+ }
+
+ lgpio->chip.label = kstrdup(pdev->name, GFP_KERNEL);
+}
+
+static void platform_loongson_gpio_get_props(struct platform_device *pdev,
+ struct loongson_gpio_chip *lgpio)
+{
+ struct platform_gpio_data *gpio_data =
+ (struct platform_gpio_data *)pdev->dev.platform_data;
+
+ lgpio->chip.ngpio = gpio_data->ngpio;
+ lgpio->chip.base = gpio_data->gpio_base;
+ lgpio->conf_offset = gpio_data->gpio_conf;
+ lgpio->out_offset = gpio_data->gpio_out;
+ lgpio->in_offset = gpio_data->gpio_in;
+ lgpio->chip.label = kstrdup(gpio_data->label, GFP_KERNEL);
+}
+
static int loongson_gpio_probe(struct platform_device *pdev)
{
- struct gpio_chip *gc;
+ struct resource *iores;
+ void __iomem *base;
+ struct loongson_gpio_chip *lgpio;
+ struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev;
+ int ret = 0;
- gc = devm_kzalloc(dev, sizeof(*gc), GFP_KERNEL);
- if (!gc)
+ lgpio = kzalloc(sizeof(struct loongson_gpio_chip), GFP_KERNEL);
+ if (!lgpio)
return -ENOMEM;
- gc->label = "loongson-gpio-chip";
- gc->base = 0;
- gc->ngpio = LOONGSON_N_GPIO;
- gc->get = loongson_gpio_get_value;
- gc->set = loongson_gpio_set_value;
- gc->direction_input = loongson_gpio_direction_input;
- gc->direction_output = loongson_gpio_direction_output;
+ if (np)
+ of_loongson_gpio_get_props(np, lgpio);
+ else if (ACPI_COMPANION(&pdev->dev))
+ acpi_loongson_gpio_get_props(pdev, lgpio);
+ else
+ platform_loongson_gpio_get_props(pdev, lgpio);
+
+ iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!iores) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ if (!request_mem_region(iores->start, resource_size(iores),
+ pdev->name)) {
+ ret = -EBUSY;
+ goto out;
+ }
+
+ base = ioremap(iores->start, resource_size(iores));
+ if (!base) {
+ ret = -ENOMEM;
+ goto out;
+ }
- return gpiochip_add_data(gc, NULL);
+ platform_set_drvdata(pdev, lgpio);
+
+ loongson_gpio_init(dev, lgpio, np, base);
+
+ return 0;
+out:
+ pr_err("%s: %s: missing mandatory property\n", __func__, np->name);
+ return ret;
}
+static int loongson_gpio_remove(struct platform_device *pdev)
+{
+ struct loongson_gpio_chip *lgpio = platform_get_drvdata(pdev);
+ struct resource *mem;
+
+ platform_set_drvdata(pdev, NULL);
+
+ gpiochip_remove(&lgpio->chip);
+ iounmap(lgpio->base);
+ kfree(lgpio->gsi_idx_map);
+ kfree(lgpio);
+ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ release_mem_region(mem->start, resource_size(mem));
+
+ return 0;
+}
+
+static const struct of_device_id loongson_gpio_dt_ids[] = {
+ { .compatible = "loongson,ls2k-gpio"},
+ { .compatible = "loongson,ls7a-gpio"},
+ {}
+};
+MODULE_DEVICE_TABLE(of, loongson_gpio_dt_ids);
+
+static const struct acpi_device_id loongson_gpio_acpi_match[] = {
+ {"LOON0002"},
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, loongson_gpio_acpi_match);
+
static struct platform_driver loongson_gpio_driver = {
.driver = {
.name = "loongson-gpio",
+ .owner = THIS_MODULE,
+ .of_match_table = loongson_gpio_dt_ids,
+ .acpi_match_table = ACPI_PTR(loongson_gpio_acpi_match),
},
.probe = loongson_gpio_probe,
+ .remove = loongson_gpio_remove,
};
static int __init loongson_gpio_setup(void)
{
- struct platform_device *pdev;
- int ret;
-
- ret = platform_driver_register(&loongson_gpio_driver);
- if (ret) {
- pr_err("error registering loongson GPIO driver\n");
- return ret;
- }
-
- pdev = platform_device_register_simple("loongson-gpio", -1, NULL, 0);
- return PTR_ERR_OR_ZERO(pdev);
+ return platform_driver_register(&loongson_gpio_driver);
}
postcore_initcall(loongson_gpio_setup);
+
+static void __exit loongson_gpio_exit(void)
+{
+ platform_driver_unregister(&loongson_gpio_driver);
+}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
2022-11-08 9:21 [PATCH v1 1/2] gpio: loongson: add dts/acpi gpio support Yinbo Zhu
@ 2022-11-08 9:21 ` Yinbo Zhu
2022-11-08 12:11 ` Linus Walleij
2022-11-08 15:28 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Yinbo Zhu @ 2022-11-08 9:21 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, WANG Xuerui, Jiaxun Yang,
Thomas Bogendoerfer, Juxin Gao, Bibo Mao, Yanteng Si, linux-gpio,
devicetree, linux-kernel, loongarch, linux-mips, richard.liu,
Arnaud Patard, Hongbing Hu, Huacai Chen, Yinbo Zhu
Add the Loongson series gpio binding with DT schema format using
json-schema.
Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
---
.../bindings/gpio/loongson,ls-gpio.yaml | 154 ++++++++++++++++++
MAINTAINERS | 11 ++
2 files changed, 165 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
new file mode 100644
index 000000000000..9d335262ddcc
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
@@ -0,0 +1,154 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/loongson,ls-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson series GPIO controller.
+
+maintainers:
+ - Yinbo Zhu <zhuyinbo@loongson.cn>
+
+properties:
+ compatible:
+ enum:
+ - loongson,ls2k-gpio
+ - loongson,ls7a-gpio
+
+ reg:
+ maxItems: 1
+
+ ngpios: true
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+ gpio-ranges: true
+
+ loongson,conf_offset:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ This option indicate this GPIO configuration offset address.
+
+ loongson,out_offset:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ This option indicate this GPIO output value offset address.
+
+ loongson,in_offset:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ This option indicate this GPIO input value offset address.
+
+ loongson,gpio_base:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ This option indicate the first GPIO number in this node.
+
+ loongson,support_irq:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ This option indicate this GPIO whether support interrupt.
+
+ interrupts:
+ minItems: 1
+ maxItems: 64
+
+required:
+ - compatible
+ - reg
+ - ngpios
+ - "#gpio-cells"
+ - gpio-controller
+ - gpio-ranges
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ gpio0: gpio@1fe00500 {
+ compatible = "loongson,ls2k-gpio";
+ reg = <0x1fe00500 0x38>;
+ ngpios = <64>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pctrl 0 0 15>,
+ <&pctrl 16 16 15>,
+ <&pctrl 32 32 10>,
+ <&pctrl 44 44 20>;
+ loongson,conf_offset = <0>;
+ loongson,out_offset = <0x10>;
+ loongson,in_offset = <0x20>;
+ loongson,gpio_base = <0>;
+ loongson,support_irq;
+ interrupt-parent = <&liointc1>;
+ interrupts = <28 IRQ_TYPE_LEVEL_LOW>,
+ <29 IRQ_TYPE_LEVEL_LOW>,
+ <30 IRQ_TYPE_LEVEL_LOW>,
+ <30 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <26 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <>,
+ <>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>,
+ <27 IRQ_TYPE_LEVEL_LOW>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 916b2d9cffc0..878b8320ac3b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12048,6 +12048,17 @@ S: Maintained
F: Documentation/devicetree/bindings/hwinfo/loongson,ls2k-chipid.yaml
F: drivers/soc/loongson/loongson2_guts.c
+LOONGSON SERIES GPIO DRIVER
+M: Richard Liu, STMicroelectronics <richard.liu@st.com>
+M: Arnaud Patard <apatard@mandriva.com>
+M: Hongbing Hu <huhb@lemote.com>
+M: Huacai Chen <chenhuacai@kernel.org>
+M: Yinbo Zhu <zhuyinbo@loongson.cn>
+L: linux-gpio@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
+F: drivers/gpio/gpio-loongson.c
+
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
M: Sathya Prakash <sathya.prakash@broadcom.com>
M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
@ 2022-11-08 12:11 ` Linus Walleij
2022-11-08 15:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-11-08 12:11 UTC (permalink / raw)
To: Yinbo Zhu
Cc: Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski,
WANG Xuerui, Jiaxun Yang, Thomas Bogendoerfer, Juxin Gao,
Bibo Mao, Yanteng Si, linux-gpio, devicetree, linux-kernel,
loongarch, linux-mips, richard.liu, Arnaud Patard, Hongbing Hu,
Huacai Chen
Hi Yinbo,
thanks for your patch!
On Tue, Nov 8, 2022 at 10:21 AM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
> Add the Loongson series gpio binding with DT schema format using
> json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> + gpio-ranges: true
So you are using GPIO ranges... and...
> + loongson,gpio_base:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate the first GPIO number in this node.
Then you have added this to reimplement gpio ranges.
It also shows in the driver.
Drop gpio_base altogether (we do not encode linux-specific properties
into the device trees) and use gpio-ranges as they are intended to
map between the GPIO numberspace and the pin control pin number
space.
See
Documentation/devicetree/bindings/gpio/gpio.txt
for documentation on gpio-ranges, also look how other drivers are
using them.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
2022-11-08 12:11 ` Linus Walleij
@ 2022-11-08 15:28 ` Krzysztof Kozlowski
2022-11-14 9:50 ` Yinbo Zhu
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-08 15:28 UTC (permalink / raw)
To: Yinbo Zhu, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, WANG Xuerui, Jiaxun Yang,
Thomas Bogendoerfer, Juxin Gao, Bibo Mao, Yanteng Si, linux-gpio,
devicetree, linux-kernel, loongarch, linux-mips, richard.liu,
Arnaud Patard, Hongbing Hu, Huacai Chen
On 08/11/2022 10:21, Yinbo Zhu wrote:
> Add the Loongson series gpio binding with DT schema format using
> json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> .../bindings/gpio/loongson,ls-gpio.yaml | 154 ++++++++++++++++++
> MAINTAINERS | 11 ++
> 2 files changed, 165 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> new file mode 100644
> index 000000000000..9d335262ddcc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> @@ -0,0 +1,154 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/loongson,ls-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson series GPIO controller.
> +
> +maintainers:
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> + compatible:
> + enum:
> + - loongson,ls2k-gpio
> + - loongson,ls7a-gpio
> +
> + reg:
> + maxItems: 1
> +
> + ngpios: true
minimum? maximum?
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-controller: true
> +
> + gpio-ranges: true
> +
> + loongson,conf_offset:
No underscores in node names. Plus comments from Linus seem to apply
here as well. Drop it entirely or explain why this is not part of
compatible, why this is needed and why encoding programming model
address in DT matches the DT...
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate this GPIO configuration offset address.
> +
> + loongson,out_offset:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate this GPIO output value offset address.
Drop
> +
> + loongson,in_offset:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate this GPIO input value offset address.
Drop
> +
> + loongson,gpio_base:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + This option indicate the first GPIO number in this node.
Drop
> +
> + loongson,support_irq:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + This option indicate this GPIO whether support interrupt.
Drop
> +
> + interrupts:
> + minItems: 1
> + maxItems: 64
> +
> +required:
> + - compatible
> + - reg
> + - ngpios
> + - "#gpio-cells"
> + - gpio-controller
> + - gpio-ranges
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + gpio0: gpio@1fe00500 {
> + compatible = "loongson,ls2k-gpio";
> + reg = <0x1fe00500 0x38>;
> + ngpios = <64>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-ranges = <&pctrl 0 0 15>,
> + <&pctrl 16 16 15>,
> + <&pctrl 32 32 10>,
> + <&pctrl 44 44 20>;
> + loongson,conf_offset = <0>;
> + loongson,out_offset = <0x10>;
> + loongson,in_offset = <0x20>;
> + loongson,gpio_base = <0>;
> + loongson,support_irq;
> + interrupt-parent = <&liointc1>;
> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>,
> + <29 IRQ_TYPE_LEVEL_LOW>,
> + <30 IRQ_TYPE_LEVEL_LOW>,
> + <30 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <26 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <>,
What's this?
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <>,
> + <>,
What's this?
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>,
> + <27 IRQ_TYPE_LEVEL_LOW>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 916b2d9cffc0..878b8320ac3b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12048,6 +12048,17 @@ S: Maintained
> F: Documentation/devicetree/bindings/hwinfo/loongson,ls2k-chipid.yaml
> F: drivers/soc/loongson/loongson2_guts.c
>
> +LOONGSON SERIES GPIO DRIVER
> +M: Richard Liu, STMicroelectronics <richard.liu@st.com>
> +M: Arnaud Patard <apatard@mandriva.com>
> +M: Hongbing Hu <huhb@lemote.com>
> +M: Huacai Chen <chenhuacai@kernel.org>
> +M: Yinbo Zhu <zhuyinbo@loongson.cn>
Are they all maintainers of this driver?
> +L: linux-gpio@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> +F: drivers/gpio/gpio-loongson.c
> +
> LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
> M: Sathya Prakash <sathya.prakash@broadcom.com>
> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
2022-11-08 15:28 ` Krzysztof Kozlowski
@ 2022-11-14 9:50 ` Yinbo Zhu
2022-11-18 12:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Yinbo Zhu @ 2022-11-14 9:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Bartosz Golaszewski,
zhuyinbo, Rob Herring, Krzysztof Kozlowski, WANG Xuerui,
Jiaxun Yang, Thomas Bogendoerfer, Juxin Gao, Bibo Mao,
Yanteng Si, linux-gpio, devicetree, linux-kernel, loongarch,
linux-mips, richard.liu, Arnaud Patard, Hongbing Hu, Huacai Chen
在 2022/11/8 下午11:28, Krzysztof Kozlowski 写道:
> On 08/11/2022 10:21, Yinbo Zhu wrote:
>> Add the Loongson series gpio binding with DT schema format using
>> json-schema.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>> ---
>> .../bindings/gpio/loongson,ls-gpio.yaml | 154 ++++++++++++++++++
>> MAINTAINERS | 11 ++
>> 2 files changed, 165 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> new file mode 100644
>> index 000000000000..9d335262ddcc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> @@ -0,0 +1,154 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpio/loongson,ls-gpio.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Loongson series GPIO controller.
>> +
>> +maintainers:
>> + - Yinbo Zhu <zhuyinbo@loongson.cn>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - loongson,ls2k-gpio
>> + - loongson,ls7a-gpio
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + ngpios: true
>
> minimum? maximum?
okay, I got it.
>
>> +
>> + "#gpio-cells":
>> + const: 2
>> +
>> + gpio-controller: true
>> +
>> + gpio-ranges: true
>> +
>> + loongson,conf_offset:
>
> No underscores in node names. Plus comments from Linus seem to apply
> here as well. Drop it entirely or explain why this is not part of
> compatible, why this is needed and why encoding programming model
> address in DT matches the DT...
Add it is to distinguish differnt address in different platform.
and I had drop them and initial them in kernel driver that depend
on diffent compatible.
>
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO configuration offset address.
>> +
>> + loongson,out_offset:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO output value offset address.
>
> Drop
>
>> +
>> + loongson,in_offset:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO input value offset address.
>
> Drop
>
>
>> +
>> + loongson,gpio_base:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate the first GPIO number in this node.
>
> Drop
>
>
>> +
>> + loongson,support_irq:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description:
>> + This option indicate this GPIO whether support interrupt.
>
> Drop
>
>> +
>> + interrupts:
>> + minItems: 1
>> + maxItems: 64
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - ngpios
>> + - "#gpio-cells"
>> + - gpio-controller
>> + - gpio-ranges
>> + - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + gpio0: gpio@1fe00500 {
>> + compatible = "loongson,ls2k-gpio";
>> + reg = <0x1fe00500 0x38>;
>> + ngpios = <64>;
>> + #gpio-cells = <2>;
>> + gpio-controller;
>> + gpio-ranges = <&pctrl 0 0 15>,
>> + <&pctrl 16 16 15>,
>> + <&pctrl 32 32 10>,
>> + <&pctrl 44 44 20>;
>> + loongson,conf_offset = <0>;
>> + loongson,out_offset = <0x10>;
>> + loongson,in_offset = <0x20>;
>> + loongson,gpio_base = <0>;
>> + loongson,support_irq;
>> + interrupt-parent = <&liointc1>;
>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>,
>> + <29 IRQ_TYPE_LEVEL_LOW>,
>> + <30 IRQ_TYPE_LEVEL_LOW>,
>> + <30 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>
> What's this?
There was no interrupt function in this gpio.
>
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>> + <>,
>
> What's this?
>
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>;
>> + };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 916b2d9cffc0..878b8320ac3b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -12048,6 +12048,17 @@ S: Maintained
>> F: Documentation/devicetree/bindings/hwinfo/loongson,ls2k-chipid.yaml
>> F: drivers/soc/loongson/loongson2_guts.c
>>
>> +LOONGSON SERIES GPIO DRIVER
>> +M: Richard Liu, STMicroelectronics <richard.liu@st.com>
>> +M: Arnaud Patard <apatard@mandriva.com>
>> +M: Hongbing Hu <huhb@lemote.com>
>> +M: Huacai Chen <chenhuacai@kernel.org>
>> +M: Yinbo Zhu <zhuyinbo@loongson.cn>
>
> Are they all maintainers of this driver?
add huacai and myself as maintainer.
>
>> +L: linux-gpio@vger.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> +F: drivers/gpio/gpio-loongson.c
>> +
>> LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
>> M: Sathya Prakash <sathya.prakash@broadcom.com>
>> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
2022-11-14 9:50 ` Yinbo Zhu
@ 2022-11-18 12:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-18 12:38 UTC (permalink / raw)
To: Yinbo Zhu, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, WANG Xuerui, Jiaxun Yang,
Thomas Bogendoerfer, Juxin Gao, Bibo Mao, Yanteng Si, linux-gpio,
devicetree, linux-kernel, loongarch, linux-mips, richard.liu,
Arnaud Patard, Hongbing Hu, Huacai Chen
On 14/11/2022 10:50, Yinbo Zhu wrote:
>
>>> +
>>> + "#gpio-cells":
>>> + const: 2
>>> +
>>> + gpio-controller: true
>>> +
>>> + gpio-ranges: true
>>> +
>>> + loongson,conf_offset:
>>
>> No underscores in node names. Plus comments from Linus seem to apply
>> here as well. Drop it entirely or explain why this is not part of
>> compatible, why this is needed and why encoding programming model
>> address in DT matches the DT...
> Add it is to distinguish differnt address in different platform.
> and I had drop them and initial them in kernel driver that depend
> on diffent compatible.
>>
So if you had to drop these, please drop from the bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-18 12:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 9:21 [PATCH v1 1/2] gpio: loongson: add dts/acpi gpio support Yinbo Zhu
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
2022-11-08 12:11 ` Linus Walleij
2022-11-08 15:28 ` Krzysztof Kozlowski
2022-11-14 9:50 ` Yinbo Zhu
2022-11-18 12:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).