From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Huacai Chen <chenhc@lemote.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-mips@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
Huacai Chen <chenhuacai@gmail.com>
Subject: Re: [PATCH 3/5] irqchip: loongson-liointc: Fix misuse of gc->mask_cache
Date: Wed, 29 Jul 2020 13:26:49 +0800 [thread overview]
Message-ID: <ccd646fd-9df6-517f-0cee-4672e8a052f8@flygoat.com> (raw)
In-Reply-To: <1596000130-8689-3-git-send-email-chenhc@lemote.com>
在 2020/7/29 13:22, Huacai Chen 写道:
> In gc->mask_cache bits, 1 means enabled and 0 means disabled, but in the
> loongson-liointc driver mask_cache is misused by reverting its meaning.
> This patch fix the bug and update the comments as well.
Suprisingly it even works with the wrong usage of mask_cache.
Thanks for catching that!
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> drivers/irqchip/irq-loongson-liointc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
> index 63b6147..08165c5 100644
> --- a/drivers/irqchip/irq-loongson-liointc.c
> +++ b/drivers/irqchip/irq-loongson-liointc.c
> @@ -60,7 +60,7 @@ static void liointc_chained_handle_irq(struct irq_desc *desc)
> if (!pending) {
> /* Always blame LPC IRQ if we have that bug */
> if (handler->priv->has_lpc_irq_errata &&
> - (handler->parent_int_map & ~gc->mask_cache &
> + (handler->parent_int_map & gc->mask_cache &
> BIT(LIOINTC_ERRATA_IRQ)))
> pending = BIT(LIOINTC_ERRATA_IRQ);
> else
> @@ -131,11 +131,11 @@ static void liointc_resume(struct irq_chip_generic *gc)
> irq_gc_lock_irqsave(gc, flags);
> /* Disable all at first */
> writel(0xffffffff, gc->reg_base + LIOINTC_REG_INTC_DISABLE);
> - /* Revert map cache */
> + /* Restore map cache */
> for (i = 0; i < LIOINTC_CHIP_IRQ; i++)
> writeb(priv->map_cache[i], gc->reg_base + i);
> - /* Revert mask cache */
> - writel(~gc->mask_cache, gc->reg_base + LIOINTC_REG_INTC_ENABLE);
> + /* Restore mask cache */
> + writel(gc->mask_cache, gc->reg_base + LIOINTC_REG_INTC_ENABLE);
> irq_gc_unlock_irqrestore(gc, flags);
> }
>
> @@ -243,7 +243,7 @@ int __init liointc_of_init(struct device_node *node,
> ct->chip.irq_mask_ack = irq_gc_mask_disable_reg;
> ct->chip.irq_set_type = liointc_set_type;
>
> - gc->mask_cache = 0xffffffff;
> + gc->mask_cache = 0;
> priv->gc = gc;
>
> for (i = 0; i < LIOINTC_NUM_PARENT; i++) {
next prev parent reply other threads:[~2020-07-29 5:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 5:22 [PATCH 1/5] dt-bindings: interrupt-controller: Update Loongson HTVEC description Huacai Chen
2020-07-29 5:22 ` [PATCH 2/5] MIPS: DTS: Fix number of msi vectors for Loongson64G Huacai Chen
2020-07-29 5:22 ` [PATCH 3/5] irqchip: loongson-liointc: Fix misuse of gc->mask_cache Huacai Chen
2020-07-29 5:26 ` Jiaxun Yang [this message]
2020-07-29 15:04 ` Marc Zyngier
2020-07-30 1:16 ` Huacai Chen
2020-07-29 5:22 ` [PATCH 4/5] irqchip: loongson-htvec: Support 8 groups of HT vectors Huacai Chen
2020-07-29 5:27 ` Jiaxun Yang
2020-07-29 5:22 ` [PATCH 5/5] irqchip: loongson-pch-pic: Fix the misused irq flow handler Huacai Chen
2020-07-29 5:33 ` Jiaxun Yang
2020-07-29 5:25 ` [PATCH 1/5] dt-bindings: interrupt-controller: Update Loongson HTVEC description Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccd646fd-9df6-517f-0cee-4672e8a052f8@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).