[PATCH] mm: shmem: remove unused info variable

[PATCH] mm: shmem: remove unused info variable

[Corentin Labbe]

This patch fix the following build warning by simply removing the unused
info variable.
mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 mm/shmem.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 544c105d706a..7fbe67be86fa 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
 	int len;
 	struct inode *inode;
 	struct page *page;
-	struct shmem_inode_info *info;
 
 	len = strlen(symname) + 1;
 	if (len > PAGE_SIZE)
@@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
 		error = 0;
 	}
 
-	info = SHMEM_I(inode);
 	inode->i_size = len-1;
 	if (len <= SHORT_SYMLINK_LEN) {
 		inode->i_link = kmemdup(symname, len, GFP_KERNEL);
-- 
2.13.6

Re: [PATCH] mm: shmem: remove unused info variable

[Michal Hocko]

This seems familiar. Ohh, you have posted it
http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
already. It fall though cracks, it seems. CCing Andrew 

On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> This patch fix the following build warning by simply removing the unused
> info variable.
> mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/shmem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 544c105d706a..7fbe67be86fa 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
>  	int len;
>  	struct inode *inode;
>  	struct page *page;
> -	struct shmem_inode_info *info;
>  
>  	len = strlen(symname) + 1;
>  	if (len > PAGE_SIZE)
> @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
>  		error = 0;
>  	}
>  
> -	info = SHMEM_I(inode);
>  	inode->i_size = len-1;
>  	if (len <= SHORT_SYMLINK_LEN) {
>  		inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> -- 
> 2.13.6

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: shmem: remove unused info variable

[Michal Hocko]

On Thu 16-11-17 14:17:43, Michal Hocko wrote:
> This seems familiar. Ohh, you have posted it
> http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
> already. It fall though cracks, it seems. CCing Andrew 

now, for real

> On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> > This patch fix the following build warning by simply removing the unused
> > info variable.
> > mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>
> 
> > ---
> >  mm/shmem.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/mm/shmem.c b/mm/shmem.c
> > index 544c105d706a..7fbe67be86fa 100644
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> >  	int len;
> >  	struct inode *inode;
> >  	struct page *page;
> > -	struct shmem_inode_info *info;
> >  
> >  	len = strlen(symname) + 1;
> >  	if (len > PAGE_SIZE)
> > @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> >  		error = 0;
> >  	}
> >  
> > -	info = SHMEM_I(inode);
> >  	inode->i_size = len-1;
> >  	if (len <= SHORT_SYMLINK_LEN) {
> >  		inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> > -- 
> > 2.13.6
> 
> -- 
> Michal Hocko
> SUSE Labs

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>