* [PATCH] mm: shmem: remove unused info variable
@ 2017-11-15 19:27 Corentin Labbe
2017-11-16 13:17 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Corentin Labbe @ 2017-11-15 19:27 UTC (permalink / raw)
To: hughd; +Cc: linux-mm, linux-kernel, Corentin Labbe
This patch fix the following build warning by simply removing the unused
info variable.
mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
mm/shmem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 544c105d706a..7fbe67be86fa 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
int len;
struct inode *inode;
struct page *page;
- struct shmem_inode_info *info;
len = strlen(symname) + 1;
if (len > PAGE_SIZE)
@@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
error = 0;
}
- info = SHMEM_I(inode);
inode->i_size = len-1;
if (len <= SHORT_SYMLINK_LEN) {
inode->i_link = kmemdup(symname, len, GFP_KERNEL);
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm: shmem: remove unused info variable
2017-11-15 19:27 [PATCH] mm: shmem: remove unused info variable Corentin Labbe
@ 2017-11-16 13:17 ` Michal Hocko
2017-11-16 13:18 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2017-11-16 13:17 UTC (permalink / raw)
To: Corentin Labbe; +Cc: hughd, linux-mm, linux-kernel
This seems familiar. Ohh, you have posted it
http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
already. It fall though cracks, it seems. CCing Andrew
On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> This patch fix the following build warning by simply removing the unused
> info variable.
> mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/shmem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 544c105d706a..7fbe67be86fa 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> int len;
> struct inode *inode;
> struct page *page;
> - struct shmem_inode_info *info;
>
> len = strlen(symname) + 1;
> if (len > PAGE_SIZE)
> @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> error = 0;
> }
>
> - info = SHMEM_I(inode);
> inode->i_size = len-1;
> if (len <= SHORT_SYMLINK_LEN) {
> inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> --
> 2.13.6
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: shmem: remove unused info variable
2017-11-16 13:17 ` Michal Hocko
@ 2017-11-16 13:18 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2017-11-16 13:18 UTC (permalink / raw)
To: Corentin Labbe; +Cc: hughd, linux-mm, linux-kernel, Andrew Morton
On Thu 16-11-17 14:17:43, Michal Hocko wrote:
> This seems familiar. Ohh, you have posted it
> http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
> already. It fall though cracks, it seems. CCing Andrew
now, for real
> On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> > This patch fix the following build warning by simply removing the unused
> > info variable.
> > mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> > ---
> > mm/shmem.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/mm/shmem.c b/mm/shmem.c
> > index 544c105d706a..7fbe67be86fa 100644
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> > int len;
> > struct inode *inode;
> > struct page *page;
> > - struct shmem_inode_info *info;
> >
> > len = strlen(symname) + 1;
> > if (len > PAGE_SIZE)
> > @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> > error = 0;
> > }
> >
> > - info = SHMEM_I(inode);
> > inode->i_size = len-1;
> > if (len <= SHORT_SYMLINK_LEN) {
> > inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> > --
> > 2.13.6
>
> --
> Michal Hocko
> SUSE Labs
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-16 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 19:27 [PATCH] mm: shmem: remove unused info variable Corentin Labbe
2017-11-16 13:17 ` Michal Hocko
2017-11-16 13:18 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).