* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 17:38 ` Matthew Wilcox
@ 2020-11-01 17:48 ` Randy Dunlap
2020-11-01 17:53 ` Matthew Wilcox
2020-11-01 19:51 ` Arvind Sankar
2020-11-01 21:56 ` Stephen Rothwell
2 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2020-11-01 17:48 UTC (permalink / raw)
To: Matthew Wilcox, Arvind Sankar
Cc: kernel test robot, linux-next, Stephen Rothwell, kbuild-all,
Linux Memory Management List, Nick Desaulniers, Kees Cook,
Andrew Morton, stable
On 11/1/20 9:38 AM, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote:
>> Commit
>> b9de06783f01 ("compiler.h: fix barrier_data() on clang")
>> moved the definition of barrier() into compiler.h.
>
> That's not a real commit ID. It only exists in linux-next and
> will expire after a few weeks.
>
> The right way to fix a patch in Andrew's tree is to send an email
> asking him to apply it as a -fix patch. As part of Andrew's submission
> process, he folds all the -fix patches into the parent patch and it
> shows up pristine in Linus' tree.
>
>> This causes build failures at least on alpha, because there are files
>> that rely on barrier() being defined via the implicit include of
>> compiler_types.h.
>
> That seems like a bug that should be fixed rather than reverting this
> part of the patch?
>
maybe: ?
https://lore.kernel.org/lkml/20201101030159.15858-1-rdunlap@infradead.org/
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 17:48 ` Randy Dunlap
@ 2020-11-01 17:53 ` Matthew Wilcox
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Wilcox @ 2020-11-01 17:53 UTC (permalink / raw)
To: Randy Dunlap
Cc: Arvind Sankar, kernel test robot, linux-next, Stephen Rothwell,
kbuild-all, Linux Memory Management List, Nick Desaulniers,
Kees Cook, Andrew Morton, stable
On Sun, Nov 01, 2020 at 09:48:30AM -0800, Randy Dunlap wrote:
> maybe: ?
>
> https://lore.kernel.org/lkml/20201101030159.15858-1-rdunlap@infradead.org/
Yes
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 17:38 ` Matthew Wilcox
2020-11-01 17:48 ` Randy Dunlap
@ 2020-11-01 19:51 ` Arvind Sankar
2020-11-01 19:52 ` Matthew Wilcox
2020-11-01 21:56 ` Stephen Rothwell
2 siblings, 1 reply; 11+ messages in thread
From: Arvind Sankar @ 2020-11-01 19:51 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Arvind Sankar, kernel test robot, linux-next, Stephen Rothwell,
kbuild-all, Linux Memory Management List, Nick Desaulniers,
Kees Cook, Andrew Morton, stable, Masahiro Yamada
On Sun, Nov 01, 2020 at 05:38:35PM +0000, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote:
> > Commit
> > b9de06783f01 ("compiler.h: fix barrier_data() on clang")
> > moved the definition of barrier() into compiler.h.
>
> That's not a real commit ID. It only exists in linux-next and
> will expire after a few weeks.
>
> The right way to fix a patch in Andrew's tree is to send an email
> asking him to apply it as a -fix patch. As part of Andrew's submission
> process, he folds all the -fix patches into the parent patch and it
> shows up pristine in Linus' tree.
Ok. So I still send it as a separate patch and he does the folding, or
should I send a revised patch that replaces the original one?
>
> > This causes build failures at least on alpha, because there are files
> > that rely on barrier() being defined via the implicit include of
> > compiler_types.h.
>
> That seems like a bug that should be fixed rather than reverting this
> part of the patch?
>
I thought about that, but barrier() is used in a large number of places,
so reverting seemed like the safer approach, in case more errors like
this cropped up. I don't know if it's a bug, as it was defined in
compiler_types.h before my original patch, I'm not sure if there's a
reason only compiler_types.h rather than compiler.h is implicitly
included via the Makefile.
Cc'ing Masahiro Yamada in case he has comments on that part.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 19:51 ` Arvind Sankar
@ 2020-11-01 19:52 ` Matthew Wilcox
2020-11-01 19:59 ` Arvind Sankar
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Wilcox @ 2020-11-01 19:52 UTC (permalink / raw)
To: Arvind Sankar
Cc: kernel test robot, linux-next, Stephen Rothwell, kbuild-all,
Linux Memory Management List, Nick Desaulniers, Kees Cook,
Andrew Morton, stable, Masahiro Yamada
On Sun, Nov 01, 2020 at 02:51:10PM -0500, Arvind Sankar wrote:
> Ok. So I still send it as a separate patch and he does the folding, or
> should I send a revised patch that replaces the original one?
I think Randy's patch should be merged instead of this patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 19:52 ` Matthew Wilcox
@ 2020-11-01 19:59 ` Arvind Sankar
2020-11-01 20:40 ` Randy Dunlap
0 siblings, 1 reply; 11+ messages in thread
From: Arvind Sankar @ 2020-11-01 19:59 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Arvind Sankar, kernel test robot, linux-next, Stephen Rothwell,
kbuild-all, Linux Memory Management List, Nick Desaulniers,
Kees Cook, Andrew Morton, stable, Masahiro Yamada
On Sun, Nov 01, 2020 at 07:52:15PM +0000, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 02:51:10PM -0500, Arvind Sankar wrote:
> > Ok. So I still send it as a separate patch and he does the folding, or
> > should I send a revised patch that replaces the original one?
>
> I think Randy's patch should be merged instead of this patch.
Ok, if that one works then it's better I agree.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 19:59 ` Arvind Sankar
@ 2020-11-01 20:40 ` Randy Dunlap
2020-11-01 21:59 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2020-11-01 20:40 UTC (permalink / raw)
To: Arvind Sankar, Matthew Wilcox
Cc: kernel test robot, linux-next, Stephen Rothwell, kbuild-all,
Linux Memory Management List, Nick Desaulniers, Kees Cook,
Andrew Morton, stable, Masahiro Yamada
On 11/1/20 11:59 AM, Arvind Sankar wrote:
> On Sun, Nov 01, 2020 at 07:52:15PM +0000, Matthew Wilcox wrote:
>> On Sun, Nov 01, 2020 at 02:51:10PM -0500, Arvind Sankar wrote:
>>> Ok. So I still send it as a separate patch and he does the folding, or
>>> should I send a revised patch that replaces the original one?
>>
>> I think Randy's patch should be merged instead of this patch.
>
> Ok, if that one works then it's better I agree.
>
Do I need to resend it to Andrew?
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 20:40 ` Randy Dunlap
@ 2020-11-01 21:59 ` Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2020-11-01 21:59 UTC (permalink / raw)
To: Randy Dunlap
Cc: Arvind Sankar, Matthew Wilcox, kernel test robot, linux-next,
kbuild-all, Linux Memory Management List, Nick Desaulniers,
Kees Cook, Andrew Morton, stable, Masahiro Yamada
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi Randy,
On Sun, 1 Nov 2020 12:40:19 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 11/1/20 11:59 AM, Arvind Sankar wrote:
> > On Sun, Nov 01, 2020 at 07:52:15PM +0000, Matthew Wilcox wrote:
> >> On Sun, Nov 01, 2020 at 02:51:10PM -0500, Arvind Sankar wrote:
> >>> Ok. So I still send it as a separate patch and he does the folding, or
> >>> should I send a revised patch that replaces the original one?
> >>
> >> I think Randy's patch should be merged instead of this patch.
> >
> > Ok, if that one works then it's better I agree.
> >
>
> Do I need to resend it to Andrew?
Well, his SOB is on the original patch (as is mine) ... so, yes, please.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
2020-11-01 17:38 ` Matthew Wilcox
2020-11-01 17:48 ` Randy Dunlap
2020-11-01 19:51 ` Arvind Sankar
@ 2020-11-01 21:56 ` Stephen Rothwell
2 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2020-11-01 21:56 UTC (permalink / raw)
To: Arvind Sankar
Cc: Matthew Wilcox, kernel test robot, linux-next, kbuild-all,
Linux Memory Management List, Nick Desaulniers, Kees Cook,
Andrew Morton, stable
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi all,
On Sun, 1 Nov 2020 17:38:35 +0000 Matthew Wilcox <willy@infradead.org> wrote:
>
> On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote:
> > Commit
> > b9de06783f01 ("compiler.h: fix barrier_data() on clang")
> > moved the definition of barrier() into compiler.h.
>
> That's not a real commit ID. It only exists in linux-next and
> will expire after a few weeks.
Which also means that the Cc: <stable@vger.kernel.org> is also
unnecessary.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread