* [PATCH] The Patch fixes the missing a blank line warning @ 2021-02-11 7:29 Adithya Chandrakasan 2021-02-11 10:36 ` This reply comments on the patch to " David Hildenbrand 0 siblings, 1 reply; 6+ messages in thread From: Adithya Chandrakasan @ 2021-02-11 7:29 UTC (permalink / raw) To: akpm; +Cc: Adithya Chandrakasan, linux-mm, linux-kernel, skhan FILE: mm/util.c:930: WARNING: Missing a blank line after declarations Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> --- mm/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/util.c b/mm/util.c index 8c9b7d1e7c49..60286876636d 100644 --- a/mm/util.c +++ b/mm/util.c @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) unsigned int len; struct mm_struct *mm = get_task_mm(task); unsigned long arg_start, arg_end, env_start, env_end; + if (!mm) goto out; if (!mm->arg_end) -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* This reply comments on the patch to fixes the missing a blank line warning 2021-02-11 7:29 [PATCH] The Patch fixes the missing a blank line warning Adithya Chandrakasan @ 2021-02-11 10:36 ` David Hildenbrand 2021-02-11 17:59 ` [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Adithya Chandrakasan 2021-02-11 18:20 ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan 0 siblings, 2 replies; 6+ messages in thread From: David Hildenbrand @ 2021-02-11 10:36 UTC (permalink / raw) To: Adithya Chandrakasan, akpm; +Cc: linux-mm, linux-kernel, skhan ^ Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. "mm/util: fix ??? warning" Which raises the question, what is ??? Compiler? static code checker? ... ? Thanks On 11.02.21 08:29, Adithya Chandrakasan wrote: > FILE: mm/util.c:930: WARNING: Missing a blank line after declarations > > Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> > --- > mm/util.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/util.c b/mm/util.c > index 8c9b7d1e7c49..60286876636d 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) > unsigned int len; > struct mm_struct *mm = get_task_mm(task); > unsigned long arg_start, arg_end, env_start, env_end; > + > if (!mm) > goto out; > if (!mm->arg_end) > -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix 2021-02-11 10:36 ` This reply comments on the patch to " David Hildenbrand @ 2021-02-11 17:59 ` Adithya Chandrakasan 2021-02-11 18:20 ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan 1 sibling, 0 replies; 6+ messages in thread From: Adithya Chandrakasan @ 2021-02-11 17:59 UTC (permalink / raw) To: akpm Cc: Adithya Chandrakasan, linux-mm, linux-kernel, skhan, linux-kernel-mentees FILE: mm/util.c:930: checkpatch.pl scripts basic coding style issues as below WARNING: Missing a blank line after declarations Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> --- mm/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/util.c b/mm/util.c index 8c9b7d1e7c49..60286876636d 100644 --- a/mm/util.c +++ b/mm/util.c @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) unsigned int len; struct mm_struct *mm = get_task_mm(task); unsigned long arg_start, arg_end, env_start, env_end; + if (!mm) goto out; if (!mm->arg_end) -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: This reply comments on the patch to fixes the missing a blank line warning 2021-02-11 10:36 ` This reply comments on the patch to " David Hildenbrand 2021-02-11 17:59 ` [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Adithya Chandrakasan @ 2021-02-11 18:20 ` Adithya Chandrakasan 2021-02-12 10:14 ` David Hildenbrand 1 sibling, 1 reply; 6+ messages in thread From: Adithya Chandrakasan @ 2021-02-11 18:20 UTC (permalink / raw) To: David Hildenbrand, akpm; +Cc: linux-mm, linux-kernel, skhan [-- Attachment #1: Type: text/plain, Size: 1184 bytes --] On 2/11/21 2:36 AM, David Hildenbrand wrote: > ^ > > Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. > > "mm/util: fix ??? warning" > > Which raises the question, what is ??? > > Compiler? static code checker? ... ? > > > Thanks > > On 11.02.21 08:29, Adithya Chandrakasan wrote: >> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >> >> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> >> --- >> mm/util.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/util.c b/mm/util.c >> index 8c9b7d1e7c49..60286876636d 100644 >> --- a/mm/util.c >> +++ b/mm/util.c >> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) >> unsigned int len; >> struct mm_struct *mm = get_task_mm(task); >> unsigned long arg_start, arg_end, env_start, env_end; >> + >> if (!mm) >> goto out; >> if (!mm->arg_end) >> > > Hi David, Thanks for feedback. I have fixed the issues in the patch thread with change in subject and also log message. with regards, Adithya Chandrakasan [-- Attachment #2: [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix.eml --] [-- Type: message/rfc822, Size: 1660 bytes --] From: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> To: akpm@linux-foundation.org Cc: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Date: Thu, 11 Feb 2021 09:59:14 -0800 Message-ID: <0c1ce6d55fb011f29b2c22134f59829402eba175.1613066176.git.adithya.chandrakasan@gmail.com> FILE: mm/util.c:930: checkpatch.pl scripts basic coding style issues as below WARNING: Missing a blank line after declarations Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> --- mm/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/util.c b/mm/util.c index 8c9b7d1e7c49..60286876636d 100644 --- a/mm/util.c +++ b/mm/util.c @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) unsigned int len; struct mm_struct *mm = get_task_mm(task); unsigned long arg_start, arg_end, env_start, env_end; + if (!mm) goto out; if (!mm->arg_end) -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: This reply comments on the patch to fixes the missing a blank line warning 2021-02-11 18:20 ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan @ 2021-02-12 10:14 ` David Hildenbrand 2021-02-12 10:22 ` David Hildenbrand 0 siblings, 1 reply; 6+ messages in thread From: David Hildenbrand @ 2021-02-12 10:14 UTC (permalink / raw) To: Adithya Chandrakasan, akpm; +Cc: linux-mm, linux-kernel, skhan On 11.02.21 19:20, Adithya Chandrakasan wrote: > On 2/11/21 2:36 AM, David Hildenbrand wrote: >> ^ >> >> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. >> >> "mm/util: fix ??? warning" >> >> Which raises the question, what is ??? >> >> Compiler? static code checker? ... ? >> >> >> Thanks >> >> On 11.02.21 08:29, Adithya Chandrakasan wrote: >>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >>> >>> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> >>> --- >>> mm/util.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/mm/util.c b/mm/util.c >>> index 8c9b7d1e7c49..60286876636d 100644 >>> --- a/mm/util.c >>> +++ b/mm/util.c >>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) >>> unsigned int len; >>> struct mm_struct *mm = get_task_mm(task); >>> unsigned long arg_start, arg_end, env_start, env_end; >>> + >>> if (!mm) >>> goto out; >>> if (!mm->arg_end) >>> >> >> > Hi David, > > Thanks for feedback. I have fixed the issues in the patch thread with > change in subject and also log message. Hi, Please always send patches via proper mails and versioned. E.g., rm *.patch git format-patch -1 -v2 git send-email --to ... *.patch The introducing patch is from 2014. So I wonder how you even get a checkpatch warning? a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore taken.") Anyhow, maybe just call this patch "mm: util.c: minor coding style fix", that makes it clearer that this is really minor and has been in the code for a while. Thanks! -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: This reply comments on the patch to fixes the missing a blank line warning 2021-02-12 10:14 ` David Hildenbrand @ 2021-02-12 10:22 ` David Hildenbrand 0 siblings, 0 replies; 6+ messages in thread From: David Hildenbrand @ 2021-02-12 10:22 UTC (permalink / raw) To: Adithya Chandrakasan, akpm; +Cc: linux-mm, linux-kernel, skhan On 12.02.21 11:14, David Hildenbrand wrote: > On 11.02.21 19:20, Adithya Chandrakasan wrote: >> On 2/11/21 2:36 AM, David Hildenbrand wrote: >>> ^ >>> >>> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. >>> >>> "mm/util: fix ??? warning" >>> >>> Which raises the question, what is ??? >>> >>> Compiler? static code checker? ... ? >>> > > > >>> >>> Thanks >>> >>> On 11.02.21 08:29, Adithya Chandrakasan wrote: >>>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >>>> >>>> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com> >>>> --- >>>> mm/util.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/mm/util.c b/mm/util.c >>>> index 8c9b7d1e7c49..60286876636d 100644 >>>> --- a/mm/util.c >>>> +++ b/mm/util.c >>>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) >>>> unsigned int len; >>>> struct mm_struct *mm = get_task_mm(task); >>>> unsigned long arg_start, arg_end, env_start, env_end; >>>> + >>>> if (!mm) >>>> goto out; >>>> if (!mm->arg_end) >>>> >>> >>> >> Hi David, >> >> Thanks for feedback. I have fixed the issues in the patch thread with >> change in subject and also log message. > > Hi, > > Please always send patches via proper mails and versioned. > > E.g., > > rm *.patch > git format-patch -1 -v2 > git send-email --to ... *.patch > > > The introducing patch is from 2014. So I wonder how you even get a > checkpatch warning? > > a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore > taken.") Sorry wrong pointer, it's from 2014 a90902531a06 ("mm: Create utility function for accessing a tasks commandline value") -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-12 10:22 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-11 7:29 [PATCH] The Patch fixes the missing a blank line warning Adithya Chandrakasan 2021-02-11 10:36 ` This reply comments on the patch to " David Hildenbrand 2021-02-11 17:59 ` [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Adithya Chandrakasan 2021-02-11 18:20 ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan 2021-02-12 10:14 ` David Hildenbrand 2021-02-12 10:22 ` David Hildenbrand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).