[PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE

[PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE

[Yang Shi]

The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
read-only THP support for (non-shmem) FS") instroduced a new khugepaged
scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
for trance events were not added.

Cc: Song Liu <songliubraving@fb.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
 include/trace/events/huge_memory.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index dd4db33..d49fbce 100644
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -31,7 +31,8 @@
 	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
 	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
 	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
-	EMe(SCAN_TRUNCATED,		"truncated")			\
+	EM( SCAN_TRUNCATED,		"truncated")			\
+	EMe(SCAN_PAGE_HAS_PRIVATE,	"has_private")			\
 
 #undef EM
 #undef EMe
-- 
1.8.3.1

Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE

[Anshuman Khandual]

On 11/25/2019 11:57 PM, Yang Shi wrote:
> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add

Reduce the commit SHA ID here to just 12 digits instead ?

> read-only THP support for (non-shmem) FS") instroduced a new khugepaged

s/instroduced/introduced/

> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
> for trance events were not added.

s/trance/trace/

> 
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
>  include/trace/events/huge_memory.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d49fbce 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
>  	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
>  	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
>  	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
> -	EMe(SCAN_TRUNCATED,		"truncated")			\
> +	EM( SCAN_TRUNCATED,		"truncated")			\
> +	EMe(SCAN_PAGE_HAS_PRIVATE,	"has_private")			\

Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
should just follow same pattern here and make it 'page_has_private' instead.

>  
>  #undef EM
>  #undef EMe
> 

Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE

[Yang Shi]

On 11/26/19 12:57 AM, Anshuman Khandual wrote:
>
> On 11/25/2019 11:57 PM, Yang Shi wrote:
>> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
> Reduce the commit SHA ID here to just 12 digits instead ?

Yes, sure.

>
>> read-only THP support for (non-shmem) FS") instroduced a new khugepaged
> s/instroduced/introduced/

Will fix.

>
>> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
>> for trance events were not added.
> s/trance/trace/

My fat finger :-(

>
>> Cc: Song Liu <songliubraving@fb.com>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
>> ---
>>   include/trace/events/huge_memory.h | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
>> index dd4db33..d49fbce 100644
>> --- a/include/trace/events/huge_memory.h
>> +++ b/include/trace/events/huge_memory.h
>> @@ -31,7 +31,8 @@
>>   	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
>>   	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
>>   	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
>> -	EMe(SCAN_TRUNCATED,		"truncated")			\
>> +	EM( SCAN_TRUNCATED,		"truncated")			\
>> +	EMe(SCAN_PAGE_HAS_PRIVATE,	"has_private")			\
> Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
> should just follow same pattern here and make it 'page_has_private' instead.

Some do start with "page_", anyway either is fine to me.

>
>>   
>>   #undef EM
>>   #undef EMe
>>