* Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer
[not found] <20210401022145.2019422-1-keescook@chromium.org>
@ 2021-04-01 6:41 ` kernel test robot
2021-04-01 6:47 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-04-01 6:41 UTC (permalink / raw)
To: Kees Cook, Greg Kroah-Hartman
Cc: kbuild-all, clang-built-linux, Kees Cook, Andrew Morton,
Linux Memory Management List, Rafael J. Wysocki, Michal Hocko,
Alexey Dobriyan, Lee Duncan, Chris Leech, Adam Nichols
[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]
Hi Kees,
I love your patch! Perhaps something to improve:
[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b
config: powerpc-randconfig-r001-20210401 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
git checkout c80ca56c15314908ebc1881678da3b36e007a2f4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return NULL + !*ppos;
~~~~ ^
1 warning generated.
vim +52 fs/sysfs/file.c
35
36 /*
37 * To be proactively defensive against sysfs show() handlers that do not
38 * correctly stay within their PAGE_SIZE buffer, use the vmap area to gain
39 * the trailing guard page which will stop linear buffer overflows.
40 */
41 static void *sysfs_kf_seq_start(struct seq_file *sf, loff_t *ppos)
42 {
43 struct kernfs_open_file *of = sf->private;
44 struct kernfs_node *kn = of->kn;
45
46 WARN_ON_ONCE(sf->buf);
47 sf->buf = __vmalloc(kn->attr.size, GFP_KERNEL_ACCOUNT);
48 if (!sf->buf)
49 return ERR_PTR(-ENOMEM);
50 sf->size = kn->attr.size;
51
> 52 return NULL + !*ppos;
53 }
54
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35632 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer
2021-04-01 6:41 ` [PATCH v3] sysfs: Unconditionally use vmalloc for buffer kernel test robot
@ 2021-04-01 6:47 ` Nathan Chancellor
2021-04-01 6:59 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2021-04-01 6:47 UTC (permalink / raw)
To: kernel test robot
Cc: Kees Cook, Greg Kroah-Hartman, kbuild-all, clang-built-linux,
Andrew Morton, Linux Memory Management List, Rafael J. Wysocki,
Michal Hocko, Alexey Dobriyan, Lee Duncan, Chris Leech,
Adam Nichols
On Thu, Apr 01, 2021 at 02:41:37PM +0800, kernel test robot wrote:
> Hi Kees,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on driver-core/driver-core-testing]
> [also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331]
> [cannot apply to hnaz-linux-mm/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b
> config: powerpc-randconfig-r001-20210401 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install powerpc cross compiling tool for clang build
> # apt-get install binutils-powerpc-linux-gnu
> # https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> git checkout c80ca56c15314908ebc1881678da3b36e007a2f4
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> return NULL + !*ppos;
> ~~~~ ^
> 1 warning generated.
>
Arnd addressed other warnings of this nature in this patch:
https://lore.kernel.org/r/20201028151202.3074398-1-arnd@kernel.org/
which it seems never got picked up :(
Cheers,
Nathan
> vim +52 fs/sysfs/file.c
>
> 35
> 36 /*
> 37 * To be proactively defensive against sysfs show() handlers that do not
> 38 * correctly stay within their PAGE_SIZE buffer, use the vmap area to gain
> 39 * the trailing guard page which will stop linear buffer overflows.
> 40 */
> 41 static void *sysfs_kf_seq_start(struct seq_file *sf, loff_t *ppos)
> 42 {
> 43 struct kernfs_open_file *of = sf->private;
> 44 struct kernfs_node *kn = of->kn;
> 45
> 46 WARN_ON_ONCE(sf->buf);
> 47 sf->buf = __vmalloc(kn->attr.size, GFP_KERNEL_ACCOUNT);
> 48 if (!sf->buf)
> 49 return ERR_PTR(-ENOMEM);
> 50 sf->size = kn->attr.size;
> 51
> > 52 return NULL + !*ppos;
> 53 }
> 54
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer
2021-04-01 6:47 ` Nathan Chancellor
@ 2021-04-01 6:59 ` Kees Cook
2021-04-01 7:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2021-04-01 6:59 UTC (permalink / raw)
To: Nathan Chancellor
Cc: kernel test robot, Greg Kroah-Hartman, kbuild-all,
clang-built-linux, Andrew Morton, Linux Memory Management List,
Rafael J. Wysocki, Michal Hocko, Alexey Dobriyan, Lee Duncan,
Chris Leech, Adam Nichols
On Wed, Mar 31, 2021 at 11:47:53PM -0700, Nathan Chancellor wrote:
> On Thu, Apr 01, 2021 at 02:41:37PM +0800, kernel test robot wrote:
> > Hi Kees,
> >
> > I love your patch! Perhaps something to improve:
> >
> > [auto build test WARNING on driver-core/driver-core-testing]
> > [also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331]
> > [cannot apply to hnaz-linux-mm/master]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch]
> >
> > url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b
> > config: powerpc-randconfig-r001-20210401 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install powerpc cross compiling tool for clang build
> > # apt-get install binutils-powerpc-linux-gnu
> > # https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4
> > git remote add linux-review https://github.com/0day-ci/linux
> > git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> > git checkout c80ca56c15314908ebc1881678da3b36e007a2f4
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > return NULL + !*ppos;
> > ~~~~ ^
> > 1 warning generated.
> >
>
> Arnd addressed other warnings of this nature in this patch:
>
> https://lore.kernel.org/r/20201028151202.3074398-1-arnd@kernel.org/
Ah! Yeah, I copied exactly that clever idiom that Arnd fixed. :)
> which it seems never got picked up :(
Greg, are you able to pick this up too? (Yeow, sent in October!)
(Or I could respin and send them as a series?)
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer
2021-04-01 6:59 ` Kees Cook
@ 2021-04-01 7:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-01 7:08 UTC (permalink / raw)
To: Kees Cook
Cc: Nathan Chancellor, kernel test robot, kbuild-all,
clang-built-linux, Andrew Morton, Linux Memory Management List,
Rafael J. Wysocki, Michal Hocko, Alexey Dobriyan, Lee Duncan,
Chris Leech, Adam Nichols
On Wed, Mar 31, 2021 at 11:59:03PM -0700, Kees Cook wrote:
> On Wed, Mar 31, 2021 at 11:47:53PM -0700, Nathan Chancellor wrote:
> > On Thu, Apr 01, 2021 at 02:41:37PM +0800, kernel test robot wrote:
> > > Hi Kees,
> > >
> > > I love your patch! Perhaps something to improve:
> > >
> > > [auto build test WARNING on driver-core/driver-core-testing]
> > > [also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331]
> > > [cannot apply to hnaz-linux-mm/master]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > >
> > > url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b
> > > config: powerpc-randconfig-r001-20210401 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # install powerpc cross compiling tool for clang build
> > > # apt-get install binutils-powerpc-linux-gnu
> > > # https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4
> > > git remote add linux-review https://github.com/0day-ci/linux
> > > git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455
> > > git checkout c80ca56c15314908ebc1881678da3b36e007a2f4
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > > return NULL + !*ppos;
> > > ~~~~ ^
> > > 1 warning generated.
> > >
> >
> > Arnd addressed other warnings of this nature in this patch:
> >
> > https://lore.kernel.org/r/20201028151202.3074398-1-arnd@kernel.org/
>
> Ah! Yeah, I copied exactly that clever idiom that Arnd fixed. :)
>
> > which it seems never got picked up :(
>
> Greg, are you able to pick this up too? (Yeow, sent in October!)
> (Or I could respin and send them as a series?)
As a series would be great, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-01 7:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210401022145.2019422-1-keescook@chromium.org>
2021-04-01 6:41 ` [PATCH v3] sysfs: Unconditionally use vmalloc for buffer kernel test robot
2021-04-01 6:47 ` Nathan Chancellor
2021-04-01 6:59 ` Kees Cook
2021-04-01 7:08 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).