Linux-Modules Archive on lore.kernel.org
 help / Atom feed
* Re: [PATCH RFC 0/3] Proposal for cycles handling
  2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
  2017-02-13  8:16   ` Lucas De Marchi
@ 2017-02-13  8:32   ` Lucas De Marchi
  1 sibling, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2017-02-13  8:32 UTC (permalink / raw)
  To: Yauheni Kaliuta
  Cc: linux-modules, Mian Yousaf Kaukab, bjorn.andersson, Jessica Yu

On Fri, Nov 11, 2016 at 3:43 AM, Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
> Back to the discussion, does it make any sense?
>
> This is an RFC proposal of dependency loops reporting.
>
> Yauheni Kaliuta (3):
>   testsuite: depmod: check netsted loops reporting
>   libkmod: list: export list handling functions
>   depmod: handle nested loops

I added some comments. It's looking good and I'd like to get this in
to do a release this week.

thanks for fixing this.

Lucas De Marchi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFC 0/3] Proposal for cycles handling
  2017-02-13  8:16   ` Lucas De Marchi
@ 2017-02-13  9:56     ` Yauheni Kaliuta
  0 siblings, 0 replies; 4+ messages in thread
From: Yauheni Kaliuta @ 2017-02-13  9:56 UTC (permalink / raw)
  To: Lucas De Marchi
  Cc: linux-modules, Mian Yousaf Kaukab, bjorn.andersson, Jessica Yu

Hi, Lucas!

>>>>> On Mon, 13 Feb 2017 00:16:44 -0800, Lucas De Marchi  wrote:

 > On Fri, Nov 11, 2016 at 3:43 AM, Yauheni Kaliuta
 > <yauheni.kaliuta@redhat.com> wrote:
 >> Back to the discussion, does it make any sense?
 >> 
 >> This is an RFC proposal of dependency loops reporting.
 >> 
 >> Yauheni Kaliuta (3):
 >> testsuite: depmod: check netsted loops reporting

 > This patch didn't arrive to the mailing list probably due to its size.
 > Do you have a git repo I can pull it from?

I've put it to github (the sent version),
https://github.com/ykaliuta/kmod/commit/96c987e287262c63a9e268f0e3b48aea98700a0f

Thank you a lot for the review!

-- 
WBR,
Yauheni Kaliuta

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFC 0/3] Proposal for cycles handling
  2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
@ 2017-02-13  8:16   ` Lucas De Marchi
  2017-02-13  9:56     ` Yauheni Kaliuta
  2017-02-13  8:32   ` Lucas De Marchi
  1 sibling, 1 reply; 4+ messages in thread
From: Lucas De Marchi @ 2017-02-13  8:16 UTC (permalink / raw)
  To: Yauheni Kaliuta
  Cc: linux-modules, Mian Yousaf Kaukab, bjorn.andersson, Jessica Yu

On Fri, Nov 11, 2016 at 3:43 AM, Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
> Back to the discussion, does it make any sense?
>
> This is an RFC proposal of dependency loops reporting.
>
> Yauheni Kaliuta (3):
>   testsuite: depmod: check netsted loops reporting

This patch didn't arrive to the mailing list probably due to its size.
Do you have a git repo I can pull it from?

Lucas De Marchi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH RFC 0/3] Proposal for cycles handling
  2016-11-09  9:17 [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles Mian Yousaf Kaukab
@ 2016-11-11 11:43 ` Yauheni Kaliuta
  2017-02-13  8:16   ` Lucas De Marchi
  2017-02-13  8:32   ` Lucas De Marchi
  0 siblings, 2 replies; 4+ messages in thread
From: Yauheni Kaliuta @ 2016-11-11 11:43 UTC (permalink / raw)
  To: linux-modules; +Cc: Mian Yousaf Kaukab, bjorn.andersson, Jessica Yu

Back to the discussion, does it make any sense?

This is an RFC proposal of dependency loops reporting.

Yauheni Kaliuta (3):
  testsuite: depmod: check netsted loops reporting
  libkmod: list: export list handling functions
  depmod: handle nested loops

 Makefile.am                                        |   4 +
 libkmod/libkmod-internal.h                         |   4 -
 libkmod/libkmod-list.c                             |  36 ++-
 libkmod/libkmod.h                                  |   5 +
 testsuite/module-playground/Makefile               |   7 +
 testsuite/module-playground/cache/mod-loop-h.ko    | Bin 0 -> 197808 bytes
 testsuite/module-playground/cache/mod-loop-i.ko    | Bin 0 -> 197808 bytes
 testsuite/module-playground/cache/mod-loop-j.ko    | Bin 0 -> 197968 bytes
 testsuite/module-playground/cache/mod-loop-k.ko    | Bin 0 -> 197808 bytes
 testsuite/module-playground/mod-loop-h.c           |  25 ++
 testsuite/module-playground/mod-loop-i.c           |  25 ++
 testsuite/module-playground/mod-loop-j.c           |  26 ++
 testsuite/module-playground/mod-loop-k.c           |  25 ++
 testsuite/module-playground/mod-loop.h             |   4 +
 testsuite/populate-modules.sh                      |   4 +
 .../test-depmod/detect-loop/correct.txt            |   6 +-
 tools/depmod.c                                     | 287 +++++++++++++++------
 17 files changed, 367 insertions(+), 91 deletions(-)
 create mode 100644 testsuite/module-playground/cache/mod-loop-h.ko
 create mode 100644 testsuite/module-playground/cache/mod-loop-i.ko
 create mode 100644 testsuite/module-playground/cache/mod-loop-j.ko
 create mode 100644 testsuite/module-playground/cache/mod-loop-k.ko
 create mode 100644 testsuite/module-playground/mod-loop-h.c
 create mode 100644 testsuite/module-playground/mod-loop-i.c
 create mode 100644 testsuite/module-playground/mod-loop-j.c
 create mode 100644 testsuite/module-playground/mod-loop-k.c

-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-09  9:17 [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles Mian Yousaf Kaukab
2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
2017-02-13  8:16   ` Lucas De Marchi
2017-02-13  9:56     ` Yauheni Kaliuta
2017-02-13  8:32   ` Lucas De Marchi

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox