Linux-Modules Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles
@ 2016-11-09  9:17 Mian Yousaf Kaukab
  2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
  0 siblings, 1 reply; 4+ messages in thread
From: Mian Yousaf Kaukab @ 2016-11-09  9:17 UTC (permalink / raw)
  To: Yauheni Kaliuta, linux-modules; +Cc: bjorn.andersson, afaerber, lucas.de.marchi

On Wed, 2016-11-09 at 04:59 +0200, Yauheni Kaliuta wrote:
> Hi!
> 
> It may require more serious refactoring, since there is a problem
> with the
> approach of path recording. I can get wrong output, for example, for
> the
> following graph:
> 
> /*
>   mod6 -> mod7 -> mod8 -> mod9
>    ^               |       |
>     ---------------        |
>    |                       |
>     -----------------------
> */
> 
> depmod: ERROR: Cycle detected: mod7 -> mod8 -> mod9 -> mod6 -> mod7
> depmod: ERROR: Cycle detected: mod6 -> mod6
> depmod: ERROR: Found 5 modules in dependency cycles!
> 
> 
> The problem is that the path is recorded "globally", not per vertex,
> and
> "wrong" mod6 is compared in "loop == m".

I agree and in the other thread Bjorn is mentioning kind of the same.

BR,
Yousaf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-09  9:17 [PATCH v1 2/2] depmod: ignore related modules in depmod_report_cycles Mian Yousaf Kaukab
2016-11-11 11:43 ` [PATCH RFC 0/3] Proposal for cycles handling Yauheni Kaliuta
2017-02-13  8:16   ` Lucas De Marchi
2017-02-13  9:56     ` Yauheni Kaliuta
2017-02-13  8:32   ` Lucas De Marchi

Linux-Modules Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-modules/0 linux-modules/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-modules linux-modules/ https://lore.kernel.org/linux-modules \
		linux-modules@vger.kernel.org linux-modules@archiver.kernel.org
	public-inbox-index linux-modules


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-modules


AGPL code for this site: git clone https://public-inbox.org/ public-inbox