From: Vignesh Raghavendra <vigneshr@ti.com>
To: <Tudor.Ambarus@microchip.com>, <boris.brezillon@collabora.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v4 01/20] mtd: spi-nor: Use dev_dbg insted of dev_err for low level info
Date: Tue, 5 Nov 2019 17:42:56 +0530 [thread overview]
Message-ID: <bc98d845-1994-69a8-a655-81ba1bb9253f@ti.com> (raw)
In-Reply-To: <20191102112316.20715-2-tudor.ambarus@microchip.com>
Hi,
On 02/11/19 4:53 PM, Tudor.Ambarus@microchip.com wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> What most users care about is "my dev is not working properly".
> All low level information should be discovered when activating
> the debug traces.
>
> Keep error messages for just three cases:
> - when the JEDEC ID is not recognized
> - when the resume() call fails
> - when the spi_nor_check() fails.
>
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 52 +++++++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
[...]
>
> @@ -679,9 +679,9 @@ static int spi_nor_sr_ready(struct spi_nor *nor)
> if (nor->flags & SNOR_F_USE_CLSR &&
> nor->bouncebuf[0] & (SR_E_ERR | SR_P_ERR)) {
> if (nor->bouncebuf[0] & SR_E_ERR)
> - dev_err(nor->dev, "Erase Error occurred\n");
> + dev_dbg(nor->dev, "Erase Error occurred\n");
> else
> - dev_err(nor->dev, "Programming Error occurred\n");
> + dev_dbg(nor->dev, "Programming Error occurred\n");
>
> spi_nor_clear_sr(nor);
> return -EIO;
> @@ -714,12 +714,12 @@ static int spi_nor_fsr_ready(struct spi_nor *nor)
>
> if (nor->bouncebuf[0] & (FSR_E_ERR | FSR_P_ERR)) {
> if (nor->bouncebuf[0] & FSR_E_ERR)
> - dev_err(nor->dev, "Erase operation failed.\n");
> + dev_dbg(nor->dev, "Erase operation failed.\n");
> else
> - dev_err(nor->dev, "Program operation failed.\n");
> + dev_dbg(nor->dev, "Program operation failed.\n");
>
> if (nor->bouncebuf[0] & FSR_PT_ERR)
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "Attempted to modify a protected sector.\n");
>
Since, we are specifically parsing FSR bits to know the reason for
failure, I think we should use dev_err()s here.
I specifically like the last one which informs the user that
program/erase operation failed as sector was write protected.
Rest looks fine to me:
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Regards
Vignesh
> spi_nor_clear_fsr(nor);
> @@ -770,7 +770,7 @@ static int spi_nor_wait_till_ready_with_timeout(struct spi_nor *nor,
> cond_resched();
> }
>
> - dev_err(nor->dev, "flash operation timed out\n");
> + dev_dbg(nor->dev, "flash operation timed out\n");
>
> return -ETIMEDOUT;
> }
> @@ -807,7 +807,7 @@ static int spi_nor_write_sr_cr(struct spi_nor *nor, const u8 *sr_cr)
> }
>
> if (ret) {
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "error while writing configuration register\n");
> return -EINVAL;
> }
> @@ -1771,7 +1771,7 @@ static int macronix_quad_enable(struct spi_nor *nor)
> return ret;
>
> if (!(nor->bouncebuf[0] & SR_QUAD_EN_MX)) {
> - dev_err(nor->dev, "Macronix Quad bit not set\n");
> + dev_dbg(nor->dev, "Macronix Quad bit not set\n");
> return -EINVAL;
> }
>
> @@ -1819,7 +1819,7 @@ static int spansion_quad_enable(struct spi_nor *nor)
> return ret;
>
> if (!(nor->bouncebuf[0] & CR_QUAD_EN_SPAN)) {
> - dev_err(nor->dev, "Spansion Quad bit not set\n");
> + dev_dbg(nor->dev, "Spansion Quad bit not set\n");
> return -EINVAL;
> }
>
> @@ -1897,7 +1897,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor)
> return ret;
>
> if (!(sr_cr[1] & CR_QUAD_EN_SPAN)) {
> - dev_err(nor->dev, "Spansion Quad bit not set\n");
> + dev_dbg(nor->dev, "Spansion Quad bit not set\n");
> return -EINVAL;
> }
>
> @@ -1935,7 +1935,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor)
>
> ret = spi_nor_write_sr2(nor, sr2);
> if (ret) {
> - dev_err(nor->dev, "error while writing status register 2\n");
> + dev_dbg(nor->dev, "error while writing status register 2\n");
> return ret;
> }
>
> @@ -1949,7 +1949,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor)
> return ret;
>
> if (!(*sr2 & SR2_QUAD_EN_BIT7)) {
> - dev_err(nor->dev, "SR2 Quad bit not set\n");
> + dev_dbg(nor->dev, "SR2 Quad bit not set\n");
> return -EINVAL;
> }
>
> @@ -1978,7 +1978,7 @@ static int spi_nor_clear_sr_bp(struct spi_nor *nor)
>
> ret = spi_nor_write_sr(nor, nor->bouncebuf[0] & ~mask);
> if (ret) {
> - dev_err(nor->dev, "write to status register failed\n");
> + dev_dbg(nor->dev, "write to status register failed\n");
> return ret;
> }
>
> @@ -2525,7 +2525,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
> SPI_NOR_MAX_ID_LEN);
> }
> if (tmp) {
> - dev_err(nor->dev, "error %d reading JEDEC ID\n", tmp);
> + dev_dbg(nor->dev, "error %d reading JEDEC ID\n", tmp);
> return ERR_PTR(tmp);
> }
>
> @@ -2740,7 +2740,7 @@ static int s3an_nor_setup(struct spi_nor *nor,
>
> ret = spi_nor_xread_sr(nor, nor->bouncebuf);
> if (ret) {
> - dev_err(nor->dev, "error %d reading XRDSR\n", ret);
> + dev_dbg(nor->dev, "error %d reading XRDSR\n", ret);
> return ret;
> }
>
> @@ -4102,7 +4102,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
> err = spi_nor_read_sfdp(nor, sizeof(header),
> psize, param_headers);
> if (err < 0) {
> - dev_err(dev, "failed to read SFDP parameter headers\n");
> + dev_dbg(dev, "failed to read SFDP parameter headers\n");
> goto exit;
> }
> }
> @@ -4349,7 +4349,7 @@ static int spi_nor_default_setup(struct spi_nor *nor,
> /* Select the (Fast) Read command. */
> err = spi_nor_select_read(nor, shared_mask);
> if (err) {
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "can't select read settings supported by both the SPI controller and memory.\n");
> return err;
> }
> @@ -4357,7 +4357,7 @@ static int spi_nor_default_setup(struct spi_nor *nor,
> /* Select the Page Program command. */
> err = spi_nor_select_pp(nor, shared_mask);
> if (err) {
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "can't select write settings supported by both the SPI controller and memory.\n");
> return err;
> }
> @@ -4365,7 +4365,7 @@ static int spi_nor_default_setup(struct spi_nor *nor,
> /* Select the Sector Erase command. */
> err = spi_nor_select_erase(nor);
> if (err) {
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "can't select erase settings supported by both the SPI controller and memory.\n");
> return err;
> }
> @@ -4686,7 +4686,7 @@ static int spi_nor_init(struct spi_nor *nor)
>
> err = nor->clear_sr_bp(nor);
> if (err) {
> - dev_err(nor->dev,
> + dev_dbg(nor->dev,
> "fail to clear block protection bits\n");
> return err;
> }
> @@ -4694,7 +4694,7 @@ static int spi_nor_init(struct spi_nor *nor)
>
> err = spi_nor_quad_enable(nor);
> if (err) {
> - dev_err(nor->dev, "quad mode not supported\n");
> + dev_dbg(nor->dev, "quad mode not supported\n");
> return err;
> }
>
> @@ -4762,7 +4762,7 @@ static int spi_nor_set_addr_width(struct spi_nor *nor)
> }
>
> if (nor->addr_width > SPI_NOR_MAX_ADDR_WIDTH) {
> - dev_err(nor->dev, "address width is too large: %u\n",
> + dev_dbg(nor->dev, "address width is too large: %u\n",
> nor->addr_width);
> return -EINVAL;
> }
>
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-11-05 12:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 11:23 [PATCH v4 00/20] mtd: spi-nor: Quad Enable and (un)lock methods Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 01/20] mtd: spi-nor: Use dev_dbg insted of dev_err for low level info Tudor.Ambarus
2019-11-05 12:12 ` Vignesh Raghavendra [this message]
2019-11-06 7:07 ` Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 02/20] mtd: spi-nor: Print debug info inside Reg Ops methods Tudor.Ambarus
2019-11-05 12:13 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 03/20] mtd: spi-nor: Check for errors after each Register Operation Tudor.Ambarus
2019-11-06 9:19 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 04/20] mtd: spi-nor: Rename label as it is no longer generic Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 05/20] mtd: spi-nor: Void return type for spi_nor_clear_sr/fsr() Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 06/20] mtd: spi-nor: Move the WE and wait calls inside Write SR methods Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 07/20] mtd: spi-nor: Merge spi_nor_write_sr() and spi_nor_write_sr_cr() Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 08/20] mtd: spi-nor: Describe all the Reg Ops Tudor.Ambarus
2019-11-05 12:21 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 09/20] mtd: spi-nor: Drop spansion_quad_enable() Tudor.Ambarus
2019-11-05 12:35 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 10/20] mtd: spi-nor: Fix errno on Quad Enable methods Tudor.Ambarus
2019-11-05 12:36 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 11/20] mtd: spi-nor: Check all the bits written, not just the BP ones Tudor.Ambarus
2019-11-05 12:21 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 12/20] mtd: spi-nor: Print debug message when the read back test fails Tudor.Ambarus
2019-11-05 12:37 ` Vignesh Raghavendra
2019-11-06 7:24 ` Tudor.Ambarus
2019-11-06 7:39 ` Vignesh Raghavendra
2019-11-07 5:58 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 13/20] mtd: spi-nor: Fix clearing of QE bit on lock()/unlock() Tudor.Ambarus
2019-11-05 17:07 ` Vignesh Raghavendra
2019-11-06 8:33 ` Tudor.Ambarus
2019-11-06 16:26 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 14/20] mtd: spi-nor: Extend the QE Read Back test to the entire SR byte Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 15/20] mtd: spi-nor: Extend the QE Read Back test to both SR1 and SR2 Tudor.Ambarus
2019-11-05 16:06 ` Vignesh Raghavendra
2019-11-06 8:41 ` Tudor.Ambarus
2019-11-02 11:23 ` [PATCH v4 16/20] mtd: spi-nor: Rename CR_QUAD_EN_SPAN to SR2_QUAD_EN_BIT1 Tudor.Ambarus
2019-11-06 5:45 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 17/20] mtd: spi-nor: Merge spansion Quad Enable methods Tudor.Ambarus
2019-11-06 5:46 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 18/20] mtd: spi-nor: Rename macronix_quad_enable to spi_nor_sr1_bit6_quad_enable Tudor.Ambarus
2019-11-06 6:00 ` Vignesh Raghavendra
2019-11-02 11:23 ` [PATCH v4 19/20] mtd: spi-nor: Prepend "spi_nor_" to "sr2_bit7_quad_enable" Tudor.Ambarus
2019-11-02 11:24 ` [PATCH v4 20/20] mtd: spi-nor: Rework the disabling of block write protection Tudor.Ambarus
2019-11-07 6:27 ` [PATCH v4 00/20] mtd: spi-nor: Quad Enable and (un)lock methods Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc98d845-1994-69a8-a655-81ba1bb9253f@ti.com \
--to=vigneshr@ti.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).