From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Takashi Iwai <tiwai@suse.de>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Barry Song <21cnbao@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: linux-next: sound tree build failure
Date: Thu, 16 Jul 2009 21:56:20 -0700 [thread overview]
Message-ID: <20090717045620.GC17656@kroah.com> (raw)
In-Reply-To: <20090717112935.2e831eee.sfr@canb.auug.org.au>
On Fri, Jul 17, 2009 at 11:29:35AM +1000, Stephen Rothwell wrote:
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_probe':
> sound/soc/codecs/ad1938.c:423: error: 'struct device' has no member named 'driver_data'
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_remove':
> sound/soc/codecs/ad1938.c:430: error: 'struct device' has no member named 'driver_data'
>
> Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
> ad1938 codec driver based on asoc") interacting with commit
> 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
> dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
> tree (which will, I assume, be sent to Linus shortly - right, Greg?).
It turned out to be "too late" to make the change, I missed the -rc2
window, so it will be a .32 thing.
I'll move it from my driver-core.current to my driver-core tree to clear
up any confusion.
But yes, the apis should be used instead of directly accessing the
fields.
thanks,
greg k-h
next prev parent reply other threads:[~2009-07-17 5:00 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 1:29 linux-next: sound tree build failure Stephen Rothwell
2009-07-17 4:56 ` Greg KH [this message]
2009-07-17 5:32 ` Stephen Rothwell
2009-07-17 16:27 ` Greg KH
2009-07-17 9:27 ` Takashi Iwai
2009-07-17 9:28 ` Mark Brown
2009-07-17 9:31 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2010-02-02 1:47 Stephen Rothwell
2010-02-02 7:27 ` Takashi Iwai
2010-02-02 10:31 ` Mark Brown
2010-02-02 10:40 ` Takashi Iwai
2010-02-02 10:42 ` Mark Brown
2010-02-02 10:26 ` Mark Brown
2010-02-02 10:37 ` Stephen Rothwell
2010-02-02 10:58 ` Mark Brown
2010-02-02 11:17 ` Stephen Rothwell
2010-02-02 11:34 ` Mark Brown
2010-02-02 11:55 ` Stephen Rothwell
2010-02-02 12:03 ` Mark Brown
2010-02-02 11:50 ` Liam Girdwood
2010-02-02 12:01 ` Stephen Rothwell
2009-10-12 5:08 Stephen Rothwell
2009-10-12 5:34 ` Takashi Iwai
2009-10-02 1:15 Stephen Rothwell
2009-10-02 5:57 ` Takashi Iwai
2009-10-01 1:19 Stephen Rothwell
2009-10-01 6:45 ` Takashi Iwai
2009-10-01 10:31 ` Stephen Rothwell
2009-08-28 1:23 Stephen Rothwell
2009-08-28 5:37 ` Takashi Iwai
2009-08-28 5:47 ` Stephen Rothwell
2009-06-04 7:33 Stephen Rothwell
2009-06-04 8:03 ` Takashi Iwai
2009-06-04 8:08 ` Peter Ujfalusi
2009-06-04 8:54 ` Mark Brown
2009-05-20 14:31 Stephen Rothwell
2009-05-20 14:46 ` Takashi Iwai
2009-05-20 14:59 ` Stephen Rothwell
2009-05-20 15:15 ` Takashi Iwai
2009-03-16 10:39 Stephen Rothwell
2009-03-16 10:41 ` Takashi Iwai
2009-03-16 23:02 ` Stephen Rothwell
2009-03-16 10:59 ` Mark Brown
2009-03-16 23:03 ` Stephen Rothwell
2009-02-26 3:07 Stephen Rothwell
2009-02-26 8:46 ` Takashi Iwai
2009-02-26 10:25 ` Mark Brown
2009-02-26 10:31 ` Takashi Iwai
2009-02-03 3:10 Stephen Rothwell
2009-02-03 5:51 ` Takashi Iwai
2009-02-03 14:48 ` Timur Tabi
2008-12-15 4:43 Stephen Rothwell
2008-12-15 7:36 ` Takashi Iwai
2008-12-16 20:59 ` Ingo Molnar
2008-12-17 7:38 ` Takashi Iwai
2008-12-10 5:23 Stephen Rothwell
2008-12-10 6:53 ` Takashi Iwai
2008-12-10 11:47 ` Mark Brown
2008-11-14 3:56 Stephen Rothwell
2008-11-14 6:32 ` Takashi Iwai
2008-11-14 6:58 ` Stephen Rothwell
2008-11-14 7:07 ` Takashi Iwai
2008-11-14 7:14 ` Takashi Iwai
2008-11-14 7:27 ` Stephen Rothwell
2008-11-14 7:41 ` Takashi Iwai
2008-11-14 7:46 ` Stephen Rothwell
2008-10-31 3:41 Stephen Rothwell
2008-10-31 6:39 ` Takashi Iwai
2008-10-31 20:49 ` Troy Kisky
2008-11-01 9:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717045620.GC17656@kroah.com \
--to=greg@kroah.com \
--cc=21cnbao@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).