From: Takashi Iwai <tiwai@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Lydia Wang <lydiawang@viatech.com.cn>,
Logan Li <loganli@viatech.com.cn>
Subject: Re: linux-next: sound tree build failure
Date: Mon, 12 Oct 2009 07:34:31 +0200 [thread overview]
Message-ID: <s5hljjhfa54.wl%tiwai@suse.de> (raw)
In-Reply-To: <20091012160816.90fe936d.sfr@canb.auug.org.au>
At Mon, 12 Oct 2009 16:08:16 +1100,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (i386 defconfig) failed like this:
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
>
> Caused by commit eb7188cafcb7aa1419b8889494cdbd4e6a01da1c ("ALSA: HDA
> VIA: Add VT1718S support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
>
> Caused by commit f3db423df84570c9950754a5771ad26f0111235f ("ALSA: HDA
> VIA: Add VT1716S support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
>
> Caused by commit 25eaba2f8a6877ba6f58197c4723c2433a316e09 ("ALSA: HDA VIA: Add VT2002P support").
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
>
> Caused by commit ab6734e7ea32e9f9cbe0f55eeddf4aa629ed1c3d ("ALSA: HDA VIA: Add VT1812 support").
>
> I applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 Oct 2009 15:56:17 +1100
> Subject: [PATCH] sound: use semicolons to end statements
>
> Fixes:
>
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
This error happens only when CONFIG_SND_HDA_POWER_SAVE=n, which wasn't
triggered by build tests...
I applied your fix now. Thanks Stephen!
Takashi
> ---
> sound/pci/hda/patch_via.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 30260e2..a294060 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -4942,7 +4942,7 @@ static int patch_vt1718S(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1718S_loopbacks;
> @@ -5432,7 +5432,7 @@ static int patch_vt1716S(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1716S_loopbacks;
> @@ -5785,7 +5785,7 @@ static int patch_vt2002P(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt2002P_loopbacks;
> @@ -6139,7 +6139,7 @@ static int patch_vt1812(struct hda_codec *codec)
> codec->patch_ops = via_patch_ops;
>
> codec->patch_ops.init = via_auto_init;
> - codec->patch_ops.unsol_event = via_unsol_event,
> + codec->patch_ops.unsol_event = via_unsol_event;
>
> #ifdef CONFIG_SND_HDA_POWER_SAVE
> spec->loopback.amplist = vt1812_loopbacks;
> --
> 1.6.4.3
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
next prev parent reply other threads:[~2009-10-12 5:34 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 5:08 linux-next: sound tree build failure Stephen Rothwell
2009-10-12 5:34 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-02 1:47 Stephen Rothwell
2010-02-02 7:27 ` Takashi Iwai
2010-02-02 10:31 ` Mark Brown
2010-02-02 10:40 ` Takashi Iwai
2010-02-02 10:42 ` Mark Brown
2010-02-02 10:26 ` Mark Brown
2010-02-02 10:37 ` Stephen Rothwell
2010-02-02 10:58 ` Mark Brown
2010-02-02 11:17 ` Stephen Rothwell
2010-02-02 11:34 ` Mark Brown
2010-02-02 11:55 ` Stephen Rothwell
2010-02-02 12:03 ` Mark Brown
2010-02-02 11:50 ` Liam Girdwood
2010-02-02 12:01 ` Stephen Rothwell
2009-10-02 1:15 Stephen Rothwell
2009-10-02 5:57 ` Takashi Iwai
2009-10-01 1:19 Stephen Rothwell
2009-10-01 6:45 ` Takashi Iwai
2009-10-01 10:31 ` Stephen Rothwell
2009-08-28 1:23 Stephen Rothwell
2009-08-28 5:37 ` Takashi Iwai
2009-08-28 5:47 ` Stephen Rothwell
2009-07-17 1:29 Stephen Rothwell
2009-07-17 4:56 ` Greg KH
2009-07-17 5:32 ` Stephen Rothwell
2009-07-17 16:27 ` Greg KH
2009-07-17 9:27 ` Takashi Iwai
2009-07-17 9:28 ` Mark Brown
2009-07-17 9:31 ` Takashi Iwai
2009-06-04 7:33 Stephen Rothwell
2009-06-04 8:03 ` Takashi Iwai
2009-06-04 8:08 ` Peter Ujfalusi
2009-06-04 8:54 ` Mark Brown
2009-05-20 14:31 Stephen Rothwell
2009-05-20 14:46 ` Takashi Iwai
2009-05-20 14:59 ` Stephen Rothwell
2009-05-20 15:15 ` Takashi Iwai
2009-03-16 10:39 Stephen Rothwell
2009-03-16 10:41 ` Takashi Iwai
2009-03-16 23:02 ` Stephen Rothwell
2009-03-16 10:59 ` Mark Brown
2009-03-16 23:03 ` Stephen Rothwell
2009-02-26 3:07 Stephen Rothwell
2009-02-26 8:46 ` Takashi Iwai
2009-02-26 10:25 ` Mark Brown
2009-02-26 10:31 ` Takashi Iwai
2009-02-03 3:10 Stephen Rothwell
2009-02-03 5:51 ` Takashi Iwai
2009-02-03 14:48 ` Timur Tabi
2008-12-15 4:43 Stephen Rothwell
2008-12-15 7:36 ` Takashi Iwai
2008-12-16 20:59 ` Ingo Molnar
2008-12-17 7:38 ` Takashi Iwai
2008-12-10 5:23 Stephen Rothwell
2008-12-10 6:53 ` Takashi Iwai
2008-12-10 11:47 ` Mark Brown
2008-11-14 3:56 Stephen Rothwell
2008-11-14 6:32 ` Takashi Iwai
2008-11-14 6:58 ` Stephen Rothwell
2008-11-14 7:07 ` Takashi Iwai
2008-11-14 7:14 ` Takashi Iwai
2008-11-14 7:27 ` Stephen Rothwell
2008-11-14 7:41 ` Takashi Iwai
2008-11-14 7:46 ` Stephen Rothwell
2008-10-31 3:41 Stephen Rothwell
2008-10-31 6:39 ` Takashi Iwai
2008-10-31 20:49 ` Troy Kisky
2008-11-01 9:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hljjhfa54.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=loganli@viatech.com.cn \
--cc=lydiawang@viatech.com.cn \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).