linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Takashi Iwai <tiwai@suse.de>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: linux-next: sound tree build failure
Date: Tue, 2 Feb 2010 10:58:00 +0000	[thread overview]
Message-ID: <20100202105800.GE6566@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100202213732.586a3566.sfr@canb.auug.org.au>

On Tue, Feb 02, 2010 at 09:37:32PM +1100, Stephen Rothwell wrote:

> The sound tree is merged before the mfd tree, and the commit that adds
> those is only in the mfd tree.  So the sound tree, on its own, is
> broken.  This driver will only build if you merge the mfd tree as well.

Ah, you're doing builds after each individual merge.  It might help to
change the form you're using when reporting problems with partially
constructed -next - at the minute you say "Today's linux-next build
(x86_64 allmodconfig) failed like this:" which makes it look like you're
testing the result of the full -next merge.

> > > To fix this, the relevant commits from the mfd tree could be put into a
> > > "never to be rebased" branch (or separate git tree) and then this branch
> > > merged into both the sound and mfd trees.

> > This is not needed, Kconfig will handle it.

> Kconfig has nothing to do with it, sorry.

No, it does really fix the problem.  As I said the driver should build
depend on a Kconfig symbol which is introduced in the MFD tree.  This
means that the driver will not be built at all until MFD has been merged
since the dependencies required to select the driver will not be
satisfied unless the commits it depends on are present in the tree.

I'll push a patch for this shortly.

  reply	other threads:[~2010-02-02 10:58 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02  1:47 linux-next: sound tree build failure Stephen Rothwell
2010-02-02  7:27 ` Takashi Iwai
2010-02-02 10:31   ` Mark Brown
2010-02-02 10:40     ` Takashi Iwai
2010-02-02 10:42       ` Mark Brown
2010-02-02 10:26 ` Mark Brown
2010-02-02 10:37   ` Stephen Rothwell
2010-02-02 10:58     ` Mark Brown [this message]
2010-02-02 11:17       ` Stephen Rothwell
2010-02-02 11:34         ` Mark Brown
2010-02-02 11:55           ` Stephen Rothwell
2010-02-02 12:03             ` Mark Brown
2010-02-02 11:50         ` Liam Girdwood
2010-02-02 12:01           ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-10-12  5:08 Stephen Rothwell
2009-10-12  5:34 ` Takashi Iwai
2009-10-02  1:15 Stephen Rothwell
2009-10-02  5:57 ` Takashi Iwai
2009-10-01  1:19 Stephen Rothwell
2009-10-01  6:45 ` Takashi Iwai
2009-10-01 10:31   ` Stephen Rothwell
2009-08-28  1:23 Stephen Rothwell
2009-08-28  5:37 ` Takashi Iwai
2009-08-28  5:47   ` Stephen Rothwell
2009-07-17  1:29 Stephen Rothwell
2009-07-17  4:56 ` Greg KH
2009-07-17  5:32   ` Stephen Rothwell
2009-07-17 16:27     ` Greg KH
2009-07-17  9:27 ` Takashi Iwai
2009-07-17  9:28 ` Mark Brown
2009-07-17  9:31   ` Takashi Iwai
2009-06-04  7:33 Stephen Rothwell
2009-06-04  8:03 ` Takashi Iwai
2009-06-04  8:08   ` Peter Ujfalusi
2009-06-04  8:54   ` Mark Brown
2009-05-20 14:31 Stephen Rothwell
2009-05-20 14:46 ` Takashi Iwai
2009-05-20 14:59   ` Stephen Rothwell
2009-05-20 15:15     ` Takashi Iwai
2009-03-16 10:39 Stephen Rothwell
2009-03-16 10:41 ` Takashi Iwai
2009-03-16 23:02   ` Stephen Rothwell
2009-03-16 10:59 ` Mark Brown
2009-03-16 23:03   ` Stephen Rothwell
2009-02-26  3:07 Stephen Rothwell
2009-02-26  8:46 ` Takashi Iwai
2009-02-26 10:25   ` Mark Brown
2009-02-26 10:31     ` Takashi Iwai
2009-02-03  3:10 Stephen Rothwell
2009-02-03  5:51 ` Takashi Iwai
2009-02-03 14:48   ` Timur Tabi
2008-12-15  4:43 Stephen Rothwell
2008-12-15  7:36 ` Takashi Iwai
2008-12-16 20:59   ` Ingo Molnar
2008-12-17  7:38     ` Takashi Iwai
2008-12-10  5:23 Stephen Rothwell
2008-12-10  6:53 ` Takashi Iwai
2008-12-10 11:47   ` Mark Brown
2008-11-14  3:56 Stephen Rothwell
2008-11-14  6:32 ` Takashi Iwai
2008-11-14  6:58   ` Stephen Rothwell
2008-11-14  7:07     ` Takashi Iwai
2008-11-14  7:14       ` Takashi Iwai
2008-11-14  7:27       ` Stephen Rothwell
2008-11-14  7:41         ` Takashi Iwai
2008-11-14  7:46           ` Stephen Rothwell
2008-10-31  3:41 Stephen Rothwell
2008-10-31  6:39 ` Takashi Iwai
2008-10-31 20:49 ` Troy Kisky
2008-11-01  9:53   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100202105800.GE6566@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).