linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: linux-next:  sound tree build failure
Date: Wed, 10 Dec 2008 07:53:21 +0100	[thread overview]
Message-ID: <s5h63lsldwe.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081210162309.add4393f.sfr@canb.auug.org.au>

At Wed, 10 Dec 2008 16:23:09 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> sound/soc/codecs/twl4030.c:1278: error: conflicting types for 'twl4030_init'
> sound/soc/codecs/twl4030.c:1187: error: previous definition of 'twl4030_init' was here
> 
> Caused by commit 64089b84abfe2f26a864ebd968429302dcb071de ("ASoC:
> Register non-AC97 codec DAIs").
> 
> I have reverted the sound tree for today.

Thanks for noticing.  I fixed it on sound git tree now.
FWIW, the patch below should fix the build problem.


thanks,

Takashi

===
>From 24e07db8cceb7dfe2d4005e4450a27f4bcda6499 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 10 Dec 2008 07:40:24 +0100
Subject: [PATCH] ALSA: ASoC - Fix module init entry for twl4030.c

Fixed the function name of module init entry for twl4030.c, which
conflicted with the existing hardware init function:
  sound/soc/codecs/twl4030.c:1278: error: conflicting types for 'twl4030_init'
  sound/soc/codecs/twl4030.c:1187: error: previous definition of 'twl4030_init' was here

Also fixed the section type of init function.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/codecs/twl4030.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 373daa4..71ab534 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -1275,11 +1275,11 @@ struct snd_soc_codec_device soc_codec_dev_twl4030 = {
 };
 EXPORT_SYMBOL_GPL(soc_codec_dev_twl4030);
 
-static int __devinit twl4030_init(void)
+static int __init twl4030_modinit(void)
 {
 	return snd_soc_register_dai(&twl4030_dai);
 }
-module_init(twl4030_init);
+module_init(twl4030_modinit);
 
 static void __exit twl4030_exit(void)
 {
-- 
1.6.0.4

  reply	other threads:[~2008-12-10  6:53 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10  5:23 linux-next: sound tree build failure Stephen Rothwell
2008-12-10  6:53 ` Takashi Iwai [this message]
2008-12-10 11:47   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2010-02-02  1:47 Stephen Rothwell
2010-02-02  7:27 ` Takashi Iwai
2010-02-02 10:31   ` Mark Brown
2010-02-02 10:40     ` Takashi Iwai
2010-02-02 10:42       ` Mark Brown
2010-02-02 10:26 ` Mark Brown
2010-02-02 10:37   ` Stephen Rothwell
2010-02-02 10:58     ` Mark Brown
2010-02-02 11:17       ` Stephen Rothwell
2010-02-02 11:34         ` Mark Brown
2010-02-02 11:55           ` Stephen Rothwell
2010-02-02 12:03             ` Mark Brown
2010-02-02 11:50         ` Liam Girdwood
2010-02-02 12:01           ` Stephen Rothwell
2009-10-12  5:08 Stephen Rothwell
2009-10-12  5:34 ` Takashi Iwai
2009-10-02  1:15 Stephen Rothwell
2009-10-02  5:57 ` Takashi Iwai
2009-10-01  1:19 Stephen Rothwell
2009-10-01  6:45 ` Takashi Iwai
2009-10-01 10:31   ` Stephen Rothwell
2009-08-28  1:23 Stephen Rothwell
2009-08-28  5:37 ` Takashi Iwai
2009-08-28  5:47   ` Stephen Rothwell
2009-07-17  1:29 Stephen Rothwell
2009-07-17  4:56 ` Greg KH
2009-07-17  5:32   ` Stephen Rothwell
2009-07-17 16:27     ` Greg KH
2009-07-17  9:27 ` Takashi Iwai
2009-07-17  9:28 ` Mark Brown
2009-07-17  9:31   ` Takashi Iwai
2009-06-04  7:33 Stephen Rothwell
2009-06-04  8:03 ` Takashi Iwai
2009-06-04  8:08   ` Peter Ujfalusi
2009-06-04  8:54   ` Mark Brown
2009-05-20 14:31 Stephen Rothwell
2009-05-20 14:46 ` Takashi Iwai
2009-05-20 14:59   ` Stephen Rothwell
2009-05-20 15:15     ` Takashi Iwai
2009-03-16 10:39 Stephen Rothwell
2009-03-16 10:41 ` Takashi Iwai
2009-03-16 23:02   ` Stephen Rothwell
2009-03-16 10:59 ` Mark Brown
2009-03-16 23:03   ` Stephen Rothwell
2009-02-26  3:07 Stephen Rothwell
2009-02-26  8:46 ` Takashi Iwai
2009-02-26 10:25   ` Mark Brown
2009-02-26 10:31     ` Takashi Iwai
2009-02-03  3:10 Stephen Rothwell
2009-02-03  5:51 ` Takashi Iwai
2009-02-03 14:48   ` Timur Tabi
2008-12-15  4:43 Stephen Rothwell
2008-12-15  7:36 ` Takashi Iwai
2008-12-16 20:59   ` Ingo Molnar
2008-12-17  7:38     ` Takashi Iwai
2008-11-14  3:56 Stephen Rothwell
2008-11-14  6:32 ` Takashi Iwai
2008-11-14  6:58   ` Stephen Rothwell
2008-11-14  7:07     ` Takashi Iwai
2008-11-14  7:14       ` Takashi Iwai
2008-11-14  7:27       ` Stephen Rothwell
2008-11-14  7:41         ` Takashi Iwai
2008-11-14  7:46           ` Stephen Rothwell
2008-10-31  3:41 Stephen Rothwell
2008-10-31  6:39 ` Takashi Iwai
2008-10-31 20:49 ` Troy Kisky
2008-11-01  9:53   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h63lsldwe.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).