* linux-next: build warning after merge of the nfsd tree
@ 2017-04-03 1:09 Stephen Rothwell
2017-04-03 2:39 ` J. Bruce Fields
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2017-04-03 1:09 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, NeilBrown
Hi,
After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/nfsd/nfs4state.c: In function 'copy_cred':
fs/nfsd/nfs4state.c:1917:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^
Introduced by commit
d39662236bf8 ("nfsd4: remove pointless strdup_if_nonnull")
Also, that commit has no Signed-off-by from its Author.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2017-04-03 1:09 linux-next: build warning after merge of the nfsd tree Stephen Rothwell
@ 2017-04-03 2:39 ` J. Bruce Fields
0 siblings, 0 replies; 11+ messages in thread
From: J. Bruce Fields @ 2017-04-03 2:39 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, NeilBrown
On Mon, Apr 03, 2017 at 11:09:48AM +1000, Stephen Rothwell wrote:
> Hi,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/nfsd/nfs4state.c: In function 'copy_cred':
> fs/nfsd/nfs4state.c:1917:6: warning: unused variable 'ret' [-Wunused-variable]
> int ret;
> ^
>
> Introduced by commit
>
> d39662236bf8 ("nfsd4: remove pointless strdup_if_nonnull")
>
> Also, that commit has no Signed-off-by from its Author.
Both fixed, thanks.--b.
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the nfsd tree
@ 2022-02-15 9:27 Stephen Rothwell
2022-02-15 15:08 ` Chuck Lever III
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2022-02-15 9:27 UTC (permalink / raw)
To: Chuck Lever; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
Hi all,
After merging the nfsd tree, today's linux-next build (htmldocs) produced
this warning:
Documentation/networking/kapi:62: net/sunrpc/svc_xprt.c:331: WARNING: Unknown target name: "sock".
Introduced by commit
26978084103a ("SUNRPC: Rename svc_create_xprt()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2022-02-15 9:27 Stephen Rothwell
@ 2022-02-15 15:08 ` Chuck Lever III
0 siblings, 0 replies; 11+ messages in thread
From: Chuck Lever III @ 2022-02-15 15:08 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
> On Feb 15, 2022, at 4:27 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the nfsd tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/networking/kapi:62: net/sunrpc/svc_xprt.c:331: WARNING: Unknown target name: "sock".
>
> Introduced by commit
>
> 26978084103a ("SUNRPC: Rename svc_create_xprt()")
Thank you, Stephen. I'll fix that up.
--
Chuck Lever
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the nfsd tree
@ 2018-05-10 0:42 Stephen Rothwell
2018-05-10 14:21 ` Chuck Lever
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-05-10 0:42 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Chuck Lever
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
Hi all,
After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
struct svcxprt_rdma *rdma = cma_id->context;
^~~~
Introduced by commit
d1ab72afe681 ("svcrdma: Trace key RDMA API events")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2018-05-10 0:42 Stephen Rothwell
@ 2018-05-10 14:21 ` Chuck Lever
2018-05-10 15:24 ` Bruce Fields
0 siblings, 1 reply; 11+ messages in thread
From: Chuck Lever @ 2018-05-10 14:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Bruce Fields, Linux-Next Mailing List, Linux Kernel Mailing List
> On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
> net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
> struct svcxprt_rdma *rdma = cma_id->context;
> ^~~~
Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
Would you like me to send a patch?
> Introduced by commit
>
> d1ab72afe681 ("svcrdma: Trace key RDMA API events")
--
Chuck Lever
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2018-05-10 14:21 ` Chuck Lever
@ 2018-05-10 15:24 ` Bruce Fields
2018-05-10 16:10 ` Chuck Lever
0 siblings, 1 reply; 11+ messages in thread
From: Bruce Fields @ 2018-05-10 15:24 UTC (permalink / raw)
To: Chuck Lever
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
On Thu, May 10, 2018 at 10:21:05AM -0400, Chuck Lever wrote:
>
>
> > On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the nfsd tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
> > net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
> > struct svcxprt_rdma *rdma = cma_id->context;
> > ^~~~
>
> Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
> Would you like me to send a patch?
Any objection to saving the #if and just going back to writing out
cma_id->context there?
I've done that in my tree.
--b.
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index ca9001d73456..05edb18f8ca3 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -544,7 +544,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
struct rdma_cm_event *event)
{
struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
- struct svcxprt_rdma *rdma = cma_id->context;
int ret = 0;
trace_svcrdma_cm_event(event, sap);
@@ -552,7 +551,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
switch (event->event) {
case RDMA_CM_EVENT_CONNECT_REQUEST:
dprintk("svcrdma: Connect request on cma_id=%p, xprt = %p, "
- "event = %s (%d)\n", cma_id, rdma,
+ "event = %s (%d)\n", cma_id, cma_id->context,
rdma_event_msg(event->event), event->event);
handle_connect_req(cma_id, &event->param.conn);
break;
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2018-05-10 15:24 ` Bruce Fields
@ 2018-05-10 16:10 ` Chuck Lever
0 siblings, 0 replies; 11+ messages in thread
From: Chuck Lever @ 2018-05-10 16:10 UTC (permalink / raw)
To: Bruce Fields
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
> On May 10, 2018, at 11:24 AM, Bruce Fields <bfields@fieldses.org> wrote:
>
> On Thu, May 10, 2018 at 10:21:05AM -0400, Chuck Lever wrote:
>>
>>
>>> On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> Hi all,
>>>
>>> After merging the nfsd tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
>>> struct svcxprt_rdma *rdma = cma_id->context;
>>> ^~~~
>>
>> Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
>> Would you like me to send a patch?
>
> Any objection to saving the #if and just going back to writing out
> cma_id->context there?
LGTM
That's not really very useful information anyway, but I decided
to leave this stuff mostly as-is for now. I plan to do something
to fix races between disconnect and device removal at some point.
> I've done that in my tree.
>
> --b.
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index ca9001d73456..05edb18f8ca3 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -544,7 +544,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> struct rdma_cm_event *event)
> {
> struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
> - struct svcxprt_rdma *rdma = cma_id->context;
> int ret = 0;
>
> trace_svcrdma_cm_event(event, sap);
> @@ -552,7 +551,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> switch (event->event) {
> case RDMA_CM_EVENT_CONNECT_REQUEST:
> dprintk("svcrdma: Connect request on cma_id=%p, xprt = %p, "
> - "event = %s (%d)\n", cma_id, rdma,
> + "event = %s (%d)\n", cma_id, cma_id->context,
> rdma_event_msg(event->event), event->event);
> handle_connect_req(cma_id, &event->param.conn);
> break;
--
Chuck Lever
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the nfsd tree
@ 2018-01-18 23:23 Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2018-01-18 23:23 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Chuck Lever
Hi,
After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/nfsd/nfs4xdr.c:241:1: warning: 'svcxdr_dupstr' defined but not used [-Wunused-function]
svcxdr_dupstr(struct nfsd4_compoundargs *argp, void *buf, u32 len)
^~~~~~~~~~~~~
Introduced by commit
e40d99e6183e ("NFSD: Clean up symlink argument XDR decoders")
The only remaining call is protected by CONFIG_NFSD_V4_SECURITY_LABEL.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread* linux-next: build warning after merge of the nfsd tree
@ 2011-03-10 0:53 Stephen Rothwell
2011-03-17 18:09 ` J. Bruce Fields
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2011-03-10 0:53 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
Hi Bruce,
After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of 'svcauth_unix_domain_release' from incompatible pointer type
net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but argument is of type 'struct unix_domain *'
Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
creation").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: build warning after merge of the nfsd tree
2011-03-10 0:53 Stephen Rothwell
@ 2011-03-17 18:09 ` J. Bruce Fields
0 siblings, 0 replies; 11+ messages in thread
From: J. Bruce Fields @ 2011-03-17 18:09 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
On Thu, Mar 10, 2011 at 11:53:31AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
> net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of 'svcauth_unix_domain_release' from incompatible pointer type
> net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but argument is of type 'struct unix_domain *'
>
> Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
> creation").
Should be fixed, thanks for the report.
--b.
commit 352b5d13c0684ba8cd103aa20cb74f105334562a
Author: J. Bruce Fields <bfields@redhat.com>
Date: Wed Mar 9 22:40:30 2011 -0500
svcrpc: fix bad argument in unix_domain_find
"After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/sunrpc/svcauth_unix.c: In function 'unix_domain_find':
net/sunrpc/svcauth_unix.c:58: warning: passing argument 1 of
+'svcauth_unix_domain_release' from incompatible pointer type
net/sunrpc/svcauth_unix.c:41: note: expected 'struct auth_domain *' but
argument
+is of type 'struct unix_domain *'
Introduced by commit 8b3e07ac908d ("svcrpc: fix rare race on unix_domain
creation")."
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index d100bf2..c8e1021 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -55,7 +55,7 @@ struct auth_domain *unix_domain_find(char *name)
while(1) {
if (rv) {
if (new && rv != &new->h)
- svcauth_unix_domain_release(new);
+ svcauth_unix_domain_release(&new->h);
if (rv->flavour != &svcauth_unix) {
auth_domain_put(rv);
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-02-15 15:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 1:09 linux-next: build warning after merge of the nfsd tree Stephen Rothwell
2017-04-03 2:39 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2022-02-15 9:27 Stephen Rothwell
2022-02-15 15:08 ` Chuck Lever III
2018-05-10 0:42 Stephen Rothwell
2018-05-10 14:21 ` Chuck Lever
2018-05-10 15:24 ` Bruce Fields
2018-05-10 16:10 ` Chuck Lever
2018-01-18 23:23 Stephen Rothwell
2011-03-10 0:53 Stephen Rothwell
2011-03-17 18:09 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).