linux-next: build warning after merge of the arm-soc tree

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (all)
produced this warning:

drivers/clk/Kconfig:22: warning: menuconfig statement without prompt

Introduced by commit c173033d154e ("clk: make CONFIG_COMMON_CLK invisible").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the arm-soc tree

[Arnd Bergmann]

On Monday 19 March 2012, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the arm-soc tree, today's linux-next build (all)
> produced this warning:
> 
> drivers/clk/Kconfig:22: warning: menuconfig statement without prompt
> 
> Introduced by commit c173033d154e ("clk: make CONFIG_COMMON_CLK invisible").

Thanks for the report. This is clearly my fault for not testing the last
minute patch.
I have now replaced it with the one below and tested that it works
as intended.

	Arnd


commit 8fb61e33507e5d76b69467b4f96290338e96b733
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Mar 17 21:10:51 2012 +0000

    clk: make CONFIG_COMMON_CLK invisible
    
    All platforms that use the common clk infrastructure should select
    COMMON_CLK from platform code, and on all other platforms, it must
    not be enabled, so there is no point making the option visible to
    users, and when it is visible, we break randconfig builds.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 2eaf17e..165e1fe 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -9,21 +9,18 @@ config HAVE_CLK_PREPARE
 config HAVE_MACH_CLKDEV
 	bool
 
-menuconfig COMMON_CLK
-	bool "Common Clock Framework"
+config COMMON_CLK
+	bool
 	select HAVE_CLK_PREPARE
 	---help---
 	  The common clock framework is a single definition of struct
 	  clk, useful across many platforms, as well as an
 	  implementation of the clock API in include/linux/clk.h.
 	  Architectures utilizing the common struct clk should select
-	  this automatically, but it may be necessary to manually select
-	  this option for loadable modules requiring the common clock
-	  framework.
-
-	  If in doubt, say "N".
+	  this option.
 
-if COMMON_CLK
+menu "Common Clock Framework"
+	depends on COMMON_CLK
 
 config COMMON_CLK_DISABLE_UNUSED
 	bool "Disabled unused clocks at boot"
@@ -47,4 +44,4 @@ config COMMON_CLK_DEBUG
 	  clk_flags, clk_prepare_count, clk_enable_count &
 	  clk_notifier_count.
 
-endif
+endmenu

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/pinctrl/pinconf.c: In function 'pinconf_pins_show':
drivers/pinctrl/pinconf.c:299:28: warning: unused variable 'ops' [-Wunused-variable]
  const struct pinconf_ops *ops = pctldev->desc->confops;
                            ^
drivers/pinctrl/pinconf.c: In function 'pinconf_groups_show':
drivers/pinctrl/pinconf.c:346:28: warning: unused variable 'ops' [-Wunused-variable]
  const struct pinconf_ops *ops = pctldev->desc->confops;
                            ^

Introduced by commit c420619d5177 ("pinctrl: pinconf: remove checks on
ops->pin_config_get").

Sorry, that I did not notice this earlier.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 451 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:

drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
 static u64 notrace ixp4xx_read_sched_clock(void)
                    ^~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  13e0b4059b98 ("clocksource/drivers/ixp4xx: Add driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warning after merge of the arm-soc tree

[Linus Walleij]

On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the arm-soc tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
>  static u64 notrace ixp4xx_read_sched_clock(void)
>                     ^~~~~~~~~~~~~~~~~~~~~~~

This is kind of normal for timer drivers, as the sched_clock() call is #ifdef:ed
for CONFIG_ARM, it is not uniformly available on all archs. This appears
as a side effect of COMPILE_TEST which I think is fair to produce
things like this.

Yours,
Linus Walleij

Re: linux-next: build warning after merge of the arm-soc tree

[Arnd Bergmann]

On Fri, May 3, 2019 at 2:49 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > After merging the arm-soc tree, today's linux-next build
> > (x86_64 allmodconfig) produced this warning:
> >
> > drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
> >  static u64 notrace ixp4xx_read_sched_clock(void)
> >                     ^~~~~~~~~~~~~~~~~~~~~~~
>
> This is kind of normal for timer drivers, as the sched_clock() call is #ifdef:ed
> for CONFIG_ARM, it is not uniformly available on all archs. This appears
> as a side effect of COMPILE_TEST which I think is fair to produce
> things like this.

Could you send a fixup patch to mark the function __maybe_unused or
move it into the #ifdef?

         Arnd

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:15,
                 from include/linux/list.h:9,
                 from include/linux/module.h:9,
                 from drivers/dma/iop-adma.c:13:
drivers/dma/iop-adma.c: In function '__iop_adma_slot_cleanup':
drivers/dma/iop-adma.c:118:12: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
   pr_debug("\tcookie: %d slot: %d busy: %d "
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:288:21: note: in definition of macro 'pr_fmt'
 #define pr_fmt(fmt) fmt
                     ^~~
include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call'
  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call'
  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
  ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug'
  dynamic_pr_debug(fmt, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~
drivers/dma/iop-adma.c:118:3: note: in expansion of macro 'pr_debug'
   pr_debug("\tcookie: %d slot: %d busy: %d "
   ^~~~~~~~
drivers/dma/iop-adma.c:119:18: note: format string is defined here
    "this_desc: %#x next_desc: %#llx ack: %d\n",
                ~~^
                %#llx

Introduced (or exposed?) by commit

  00c9755524fb ("dmaengine: iop-adma: use correct printk format strings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_pop_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1156:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  switch (((u32) data) & 0x3) {
           ^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_stuff_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1257:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  switch (((u32) data) & 0x3) {
           ^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_handle_ep0_setup':
drivers/usb/gadget/udc/lpc32xx_udc.c:2230:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (reqtype) {
   ^~~~~~
drivers/usb/gadget/udc/lpc32xx_udc.c:2269:2: note: here
  case USB_REQ_SET_ADDRESS:
  ^~~~

Exposed by commit

  50ad15282e7c ("usb: udc: lpc32xx: allow compile-testing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  102 |   if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
      |       ^

Exposed by commit

  cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks")
  552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the arm-soc tree

[Krzysztof Kozlowski]

On 06/04/2021 02:45, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the arm-soc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
> drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   102 |   if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
>       |       ^
> 
> Exposed by commit
> 
>   cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks")
>   552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)")
> 

Thanks Stephen. This is a result of compile testing and was already
fixed via clk tree. You should not have the warning after all the merges.

https://lore.kernel.org/lkml/20210314110709.32599-1-krzysztof.kozlowski@canonical.com/

Best regards,
Krzysztof

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing:2: WARNING: Inline emphasis start-string without end-string.

Introduced by commit

  c6807970c3bc ("soc: aspeed: Add UART routing support")

The problem is (probably) the '*'s on the previous line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the arm-soc tree

[Joel Stanley]

On Mon, 25 Oct 2021 at 23:39, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing:2: WARNING: Inline emphasis start-string without end-string.
>
> Introduced by commit
>
>   c6807970c3bc ("soc: aspeed: Add UART routing support")
>
> The problem is (probably) the '*'s on the previous line.

Chai-Wei, are you able to send a fix for this issue?

Re: linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Hi all,

On Tue, 26 Oct 2021 06:15:29 +0000 Joel Stanley <joel@jms.id.au> wrote:
>
> On Mon, 25 Oct 2021 at 23:39, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the arm-soc tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing:2: WARNING: Inline emphasis start-string without end-string.
> >
> > Introduced by commit
> >
> >   c6807970c3bc ("soc: aspeed: Add UART routing support")
> >
> > The problem is (probably) the '*'s on the previous line.  
> 
> Chai-Wei, are you able to send a fix for this issue?

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the arm-soc tree

[ChiaWei Wang]

Hi Stephen & Joel,

I am sorry for missing this email.
Will fix this ASAP and submit a patch for your review.

Thanks,
Chiawei

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Thursday, January 20, 2022 11:22 AM
> 
> Hi all,
> 
> On Tue, 26 Oct 2021 06:15:29 +0000 Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Mon, 25 Oct 2021 at 23:39, Stephen Rothwell <sfr@canb.auug.org.au>
> wrote:
> > >
> > > After merging the arm-soc tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > >
> > > Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing:2: WARNING:
> Inline emphasis start-string without end-string.
> > >
> > > Introduced by commit
> > >
> > >   c6807970c3bc ("soc: aspeed: Add UART routing support")
> > >
> > > The problem is (probably) the '*'s on the previous line.
> >
> > Chai-Wei, are you able to send a fix for this issue?
> 
> I am still getting this warning.
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value

Maybe introduced by commit

  3d2d52a0d183 ("ARM: dts: BCM5301X: define RTL8365MB switch on Asus RT-AC88U")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the arm-soc tree

[Arnd Bergmann]

On Wed, Dec 22, 2021 at 10:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
>
> Maybe introduced by commit
>
>   3d2d52a0d183 ("ARM: dts: BCM5301X: define RTL8365MB switch on Asus RT-AC88U")

Confirmed, and now reverted as I'm already tagging the final pull requests.

Arınç, Florian: Feel free to resubmit a fixed version for the "late"
branch that Olof
may still pick up when I'm out of office, in case this is an important
change. Otherwise
I guess we can leave it for 5.18

        Arnd

Re: linux-next: build warning after merge of the arm-soc tree

[Florian Fainelli]

On 12/22/21 3:22 PM, Arnd Bergmann wrote:
> On Wed, Dec 22, 2021 at 10:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the arm-soc tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
>>
>> Maybe introduced by commit
>>
>>   3d2d52a0d183 ("ARM: dts: BCM5301X: define RTL8365MB switch on Asus RT-AC88U")
> 
> Confirmed, and now reverted as I'm already tagging the final pull requests.
> 
> Arınç, Florian: Feel free to resubmit a fixed version for the "late"
> branch that Olof
> may still pick up when I'm out of office, in case this is an important
> change. Otherwise
> I guess we can leave it for 5.18

Will do, thanks and sorry about not catching this earlier, I did not see
it it in the build log somehow.
-- 
Florian

Re: linux-next: build warning after merge of the arm-soc tree

[Arınç ÜNAL]

Hey Florian.

I'm not sure I understand what's going wrong here. I did everything 
according to the documentation here:
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt#L158

On 23/12/2021 02:58, Florian Fainelli wrote:
> On 12/22/21 3:22 PM, Arnd Bergmann wrote:
>> On Wed, Dec 22, 2021 at 10:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> Hi all,
>>>
>>> After merging the arm-soc tree, today's linux-next build (arm
>>> multi_v7_defconfig) produced this warning:
>>>
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value
>>> arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value
>>>
>>> Maybe introduced by commit
>>>
>>>    3d2d52a0d183 ("ARM: dts: BCM5301X: define RTL8365MB switch on Asus RT-AC88U")
>>
>> Confirmed, and now reverted as I'm already tagging the final pull requests.
>>
>> Arınç, Florian: Feel free to resubmit a fixed version for the "late"
>> branch that Olof
>> may still pick up when I'm out of office, in case this is an important
>> change. Otherwise
>> I guess we can leave it for 5.18
> 
> Will do, thanks and sorry about not catching this earlier, I did not see
> it it in the build log somehow.

Re: linux-next: build warning after merge of the arm-soc tree

[Florian Fainelli]

On 12/23/2021 12:50 AM, Arınç ÜNAL wrote:
> Hey Florian.
> 
> I'm not sure I understand what's going wrong here. I did everything 
> according to the documentation here:
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt#L158 

The problem is that there is a 'reg' property for the 'ports' node when 
this node is just a "container" for additional sub-node. This is because 
the example you rightfully followed to the letter was wrong to begin 
with. Should be fixed with:

https://lore.kernel.org/netdev/20211223181741.3999-1-f.fainelli@gmail.com/

And you would need to make a matching change to 
arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts.

Thanks!
-- 
Florian

linux-next: build warning after merge of the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format error, expected "0"

I am not sure why this has only shown up now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the arm-soc tree

[Arnd Bergmann]

On Thu, Jun 22, 2023, at 02:48, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning 
> (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format 
> error, expected "0"
>
> I am not sure why this has only shown up now.

Thanks for the report, I also just ran into the same thing.
It's probably instroduced by 89e73afc3f540 ("ARM: dts: marvell:
align SPI NOR node name with dtschema"), but I don't know why
there was no warning before.

Added the fixup patch now.

    Arnd

---
commit 7dc3be1745d05c1ed7d385487238ec06a07f4f29
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Jun 22 10:14:02 2023 +0200

    ARM: mvebu: fix unit address on armada-390-db flash
    
    The unit address needs to be changed to match the reg property:
    
    arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format error, expected "0"
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/arch/arm/boot/dts/marvell/armada-390-db.dts b/arch/arm/boot/dts/marvell/armada-390-db.dts
index 792d0a0184e82..20f518dbac971 100644
--- a/arch/arm/boot/dts/marvell/armada-390-db.dts
+++ b/arch/arm/boot/dts/marvell/armada-390-db.dts
@@ -81,7 +81,7 @@ &spi1 {
 	pinctrl-0 = <&spi1_pins>;
 	pinctrl-names = "default";
 
-	flash@1 {
+	flash@0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "n25q128a13",

Re: linux-next: build warning after merge of the arm-soc tree

[Krzysztof Kozlowski]

On 22/06/2023 10:19, Arnd Bergmann wrote:
> On Thu, Jun 22, 2023, at 02:48, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the arm-soc tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning 
>> (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format 
>> error, expected "0"
>>
>> I am not sure why this has only shown up now.
> 
> Thanks for the report, I also just ran into the same thing.
> It's probably instroduced by 89e73afc3f540 ("ARM: dts: marvell:
> align SPI NOR node name with dtschema"), but I don't know why
> there was no warning before.
> 
> Added the fixup patch now.

The unit/reg mismatch was there before my commit. Maybe something
changed in default flags for dtc compiler, thus the warning appeared?

> 
>     Arnd
> 
> ---
> commit 7dc3be1745d05c1ed7d385487238ec06a07f4f29
> Author: Arnd Bergmann <arnd@arndb.de>
> Date:   Thu Jun 22 10:14:02 2023 +0200
> 
>     ARM: mvebu: fix unit address on armada-390-db flash
>     
>     The unit address needs to be changed to match the reg property:
>     
>     arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format error, expected "0"
>     
>     Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>     Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: linux-next: build warning after merge of the arm-soc tree

[Rob Herring]

On Thu, Jun 22, 2023 at 2:19 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jun 22, 2023, at 02:48, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the arm-soc tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning
> > (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format
> > error, expected "0"
> >
> > I am not sure why this has only shown up now.
>
> Thanks for the report, I also just ran into the same thing.
> It's probably instroduced by 89e73afc3f540 ("ARM: dts: marvell:
> align SPI NOR node name with dtschema"), but I don't know why
> there was no warning before.

The dts file was not getting built before. It is enabled in commit
86684c2481b6 ("ARM: dts: Add .dts files missing from the build").

Rob