From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Jade Bilkey <herself@thefumon.com>,
Guenter Roeck <linux@roeck-us.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: linux-next: build failure after merge of the wireless-next tree
Date: Wed, 10 Sep 2014 09:28:19 +1000 [thread overview]
Message-ID: <20140910092819.7b0b0ae7@canb.auug.org.au> (raw)
In-Reply-To: <20140908184253.74ff5470@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]
Hi Dave,
On Mon, 8 Sep 2014 18:42:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/wireless/ath/ath5k/debug.c: In function 'open_file_eeprom':
> drivers/net/wireless/ath/ath5k/debug.c:933:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
> buf = vmalloc(eesize);
> ^
> drivers/net/wireless/ath/ath5k/debug.c:933:6: warning: assignment makes pointer from integer without a cast
> buf = vmalloc(eesize);
> ^
> drivers/net/wireless/ath/ath5k/debug.c:960:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(buf);
> ^
>
> Caused by commit db906eb2101b ("ath5k: added debugfs file for dumping
> eeprom"). Also reported by Guenter Roeck.
>
> I have used Geert Uytterhoeven's suggested fix of including vmalloc.h
> and so added this patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 8 Sep 2014 18:39:23 +1000
> Subject: [PATCH] ath5k: fix debugfs addition
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/net/wireless/ath/ath5k/debug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 30e4e1fd4b04..399728618fb9 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -62,6 +62,7 @@
>
> #include <linux/export.h>
> #include <linux/moduleparam.h>
> +#include <linux/vmalloc.h>
>
> #include <linux/seq_file.h>
> #include <linux/list.h>
> --
> 2.1.0
This fix patch is now needed in the net-next tree ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-09 23:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:42 linux-next: build failure after merge of the wireless-next tree Stephen Rothwell
2014-09-09 23:28 ` Stephen Rothwell [this message]
2014-09-09 23:37 ` David Miller
2014-09-10 17:46 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2014-07-16 3:28 Stephen Rothwell
2014-07-16 14:09 ` John W. Linville
2014-04-23 3:47 Stephen Rothwell
2014-04-23 20:54 ` Bing Zhao
2014-03-06 2:43 Stephen Rothwell
2014-03-06 8:53 ` Arend van Spriel
2014-03-06 2:24 Stephen Rothwell
2014-02-25 2:35 Stephen Rothwell
2014-02-25 19:07 ` John W. Linville
2014-02-25 20:47 ` Stephen Rothwell
2014-03-04 23:16 ` Stephen Rothwell
2014-03-04 23:21 ` Stephen Rothwell
2014-03-04 23:49 ` Greg KH
2014-02-13 2:19 Stephen Rothwell
2014-02-13 2:22 ` Stephen Rothwell
2014-02-13 17:31 ` Paul Gortmaker
2014-02-13 18:22 ` Paul Gortmaker
2014-02-13 18:28 ` Greg KH
2013-07-23 1:32 Stephen Rothwell
2013-07-23 7:24 ` Hauke Mehrtens
2013-04-02 2:34 Stephen Rothwell
2013-04-02 3:07 ` Larry Finger
2013-04-02 3:31 ` Stephen Rothwell
2013-04-02 4:07 ` Larry Finger
2012-04-12 2:24 Stephen Rothwell
2011-12-20 2:18 Stephen Rothwell
2011-12-20 2:42 ` Luis R. Rodriguez
2011-12-20 2:57 ` Stephen Rothwell
2011-12-20 3:24 ` Luis R. Rodriguez
2011-11-22 3:35 Stephen Rothwell
2011-11-22 8:03 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910092819.7b0b0ae7@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=herself@thefumon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).