linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bing Zhao <bzhao@marvell.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	"John W. Linville" <linville@tuxdriver.com>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Amitkumar Karwar <akarwar@marvell.com>
Subject: RE: linux-next: build failure after merge of the wireless-next tree
Date: Wed, 23 Apr 2014 13:54:27 -0700	[thread overview]
Message-ID: <477F20668A386D41ADCC57781B1F70430F70A2A9C2@SC-VEXCH1.marvell.com> (raw)
In-Reply-To: <20140423134753.4731f16efe32ee9f20925757@canb.auug.org.au>

Hi Stephen,

> Hi John,
> 
> After merging the wireless-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work':
> drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of function 'vmalloc' [-
> Werror=implicit-function-declaration]
>    entry->mem_ptr = vmalloc(memory_size + 1);
>    ^
> drivers/net/wireless/mwifiex/pcie.c:2290:18: warning: assignment makes pointer from integer without a
> cast [enabled by default]
>    entry->mem_ptr = vmalloc(memory_size + 1);
>                   ^
> drivers/net/wireless/mwifiex/pcie.c:2361:4: error: implicit declaration of function 'vfree' [-
> Werror=implicit-function-declaration]
>     vfree(entry->mem_ptr);
>     ^
> 
> Caused by commit e050c76fcf49 ("mwifiex: add firmware dump feature for
> PCIe").
> 
> I have applied this patch for today:


Sorry for the trouble and thanks a lot for the fix.

Regards,
Bing


> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 23 Apr 2014 13:44:59 +1000
> Subject: [PATCH] mwifiex: using vmallog requires including vmalloc.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/wireless/mwifiex/pcie.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
> index 51989b31137a..9c1f42754bbe 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -17,6 +17,7 @@
>   * this warranty disclaimer.
>   */
> 
> +#include <linux/vmalloc.h>
>  #include <linux/firmware.h>
> 
>  #include "decl.h"
> --
> 1.9.2
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

  reply	other threads:[~2014-04-23 20:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  3:47 linux-next: build failure after merge of the wireless-next tree Stephen Rothwell
2014-04-23 20:54 ` Bing Zhao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-08  8:42 Stephen Rothwell
2014-09-09 23:28 ` Stephen Rothwell
2014-09-09 23:37   ` David Miller
2014-09-10 17:46     ` John W. Linville
2014-07-16  3:28 Stephen Rothwell
2014-07-16 14:09 ` John W. Linville
2014-03-06  2:43 Stephen Rothwell
2014-03-06  8:53 ` Arend van Spriel
2014-03-06  2:24 Stephen Rothwell
2014-02-25  2:35 Stephen Rothwell
2014-02-25 19:07 ` John W. Linville
2014-02-25 20:47   ` Stephen Rothwell
2014-03-04 23:16     ` Stephen Rothwell
2014-03-04 23:21       ` Stephen Rothwell
2014-03-04 23:49         ` Greg KH
2014-02-13  2:19 Stephen Rothwell
2014-02-13  2:22 ` Stephen Rothwell
2014-02-13 17:31 ` Paul Gortmaker
2014-02-13 18:22   ` Paul Gortmaker
2014-02-13 18:28     ` Greg KH
2013-07-23  1:32 Stephen Rothwell
2013-07-23  7:24 ` Hauke Mehrtens
2013-04-02  2:34 Stephen Rothwell
2013-04-02  3:07 ` Larry Finger
2013-04-02  3:31   ` Stephen Rothwell
2013-04-02  4:07     ` Larry Finger
2012-04-12  2:24 Stephen Rothwell
2011-12-20  2:18 Stephen Rothwell
2011-12-20  2:42 ` Luis R. Rodriguez
2011-12-20  2:57   ` Stephen Rothwell
2011-12-20  3:24     ` Luis R. Rodriguez
2011-11-22  3:35 Stephen Rothwell
2011-11-22  8:03 ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477F20668A386D41ADCC57781B1F70430F70A2A9C2@SC-VEXCH1.marvell.com \
    --to=bzhao@marvell.com \
    --cc=akarwar@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).