linux-next: build failure after merge of the ipmi tree

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hi Corey,

After merging the ipmi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user':
drivers/char/ipmi/ipmi_msghandler.c:1268:2: error: implicit declaration of function 'cleanup_srcu_struct_quiesced'; did you mean 'cleanup_srcu_struct'? [-Werror=implicit-function-declaration]
  cleanup_srcu_struct_quiesced(&user->release_barrier);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cleanup_srcu_struct

Caused by commit

  487ecb21fa66 ("ipmi: fix sleep-in-atomic in free_user at cleanup SRCU user->release_barrier")

interacting with commit

  f5ad3991493c ("srcu: Remove cleanup_srcu_struct_quiesced()")

from the rcu tree.

Based on the comments in the rcu tree commit, I have reverted the impi
tree commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On Wed, Apr 03, 2019 at 02:33:23PM +1100, Stephen Rothwell wrote:
> Hi Corey,
> 
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Paul, any opinions on this?  Is just running this in a workqueue
the best idea?

-corey

> 
> drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user':
> drivers/char/ipmi/ipmi_msghandler.c:1268:2: error: implicit declaration of function 'cleanup_srcu_struct_quiesced'; did you mean 'cleanup_srcu_struct'? [-Werror=implicit-function-declaration]
>   cleanup_srcu_struct_quiesced(&user->release_barrier);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   cleanup_srcu_struct
> 
> Caused by commit
> 
>   487ecb21fa66 ("ipmi: fix sleep-in-atomic in free_user at cleanup SRCU user->release_barrier")
> 
> interacting with commit
> 
>   f5ad3991493c ("srcu: Remove cleanup_srcu_struct_quiesced()")
> 
> from the rcu tree.
> 
> Based on the comments in the rcu tree commit, I have reverted the impi
> tree commit for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On Wed, Apr 03, 2019 at 03:27:29PM -0500, Corey Minyard wrote:
> On Wed, Apr 03, 2019 at 02:33:23PM +1100, Stephen Rothwell wrote:
> > Hi Corey,
> > 
> > After merging the ipmi tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> Paul, any opinions on this?  Is just running this in a workqueue
> the best idea?

Well, I just that patch using a work item and pushed it up.  Seems
to work ok.  That was already done for other things in the driver.

> 
> -corey
> 
> > 
> > drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user':
> > drivers/char/ipmi/ipmi_msghandler.c:1268:2: error: implicit declaration of function 'cleanup_srcu_struct_quiesced'; did you mean 'cleanup_srcu_struct'? [-Werror=implicit-function-declaration]
> >   cleanup_srcu_struct_quiesced(&user->release_barrier);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   cleanup_srcu_struct
> > 
> > Caused by commit
> > 
> >   487ecb21fa66 ("ipmi: fix sleep-in-atomic in free_user at cleanup SRCU user->release_barrier")
> > 
> > interacting with commit
> > 
> >   f5ad3991493c ("srcu: Remove cleanup_srcu_struct_quiesced()")
> > 
> > from the rcu tree.
> > 
> > Based on the comments in the rcu tree commit, I have reverted the impi
> > tree commit for today.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> 

Re: linux-next: build failure after merge of the ipmi tree

[Paul E. McKenney]

On Wed, Apr 03, 2019 at 04:12:12PM -0500, Corey Minyard wrote:
> On Wed, Apr 03, 2019 at 03:27:29PM -0500, Corey Minyard wrote:
> > On Wed, Apr 03, 2019 at 02:33:23PM +1100, Stephen Rothwell wrote:
> > > Hi Corey,
> > > 
> > > After merging the ipmi tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > 
> > Paul, any opinions on this?  Is just running this in a workqueue
> > the best idea?
> 
> Well, I just that patch using a work item and pushed it up.  Seems
> to work ok.  That was already done for other things in the driver.

Sounds good to me, apologies for the slow response.

							Thanx, Paul

> > -corey
> > 
> > > 
> > > drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user':
> > > drivers/char/ipmi/ipmi_msghandler.c:1268:2: error: implicit declaration of function 'cleanup_srcu_struct_quiesced'; did you mean 'cleanup_srcu_struct'? [-Werror=implicit-function-declaration]
> > >   cleanup_srcu_struct_quiesced(&user->release_barrier);
> > >   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >   cleanup_srcu_struct
> > > 
> > > Caused by commit
> > > 
> > >   487ecb21fa66 ("ipmi: fix sleep-in-atomic in free_user at cleanup SRCU user->release_barrier")
> > > 
> > > interacting with commit
> > > 
> > >   f5ad3991493c ("srcu: Remove cleanup_srcu_struct_quiesced()")
> > > 
> > > from the rcu tree.
> > > 
> > > Based on the comments in the rcu tree commit, I have reverted the impi
> > > tree commit for today.
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> > 
> > 
> 

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Hi all,

After merging the ipmi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
 1276 |         del_timer_shutdown(&ssif_info->watch_timer);
      |         ^~~~~~~~~~~~~~~~~~
      |         device_shutdown
cc1: all warnings being treated as errors
drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
 5547 |                 del_timer_shutdown(&ipmi_timer);
      |                 ^~~~~~~~~~~~~~~~~~
      |                 device_shutdown
cc1: all warnings being treated as errors

Caused by commit

  306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")

I have used the ipmi tree from next-20221103 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On Fri, Nov 04, 2022 at 12:48:40PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
> drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
>  1276 |         del_timer_shutdown(&ssif_info->watch_timer);
>       |         ^~~~~~~~~~~~~~~~~~
>       |         device_shutdown
> cc1: all warnings being treated as errors
> drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
> drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
>  5547 |                 del_timer_shutdown(&ipmi_timer);
>       |                 ^~~~~~~~~~~~~~~~~~
>       |                 device_shutdown
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")
> 
> I have used the ipmi tree from next-20221103 for today.

That patch shouldn't have gone it, it's fixed now.

Thanks,

-corey

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi all,

After merging the ipmi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ipmi/ipmi_msghandler.c: In function 'bmc_device_id_handler':
drivers/char/ipmi/ipmi_msghandler.c:2376:3: error: label 'out' used but not defined
 2376 |   goto out;
      |   ^~~~

Caused by commit

  2d7a6d8467f9 ("ipmi: Check error code before processing BMC response")

I have used the ipmi tree from next-20210930 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On Fri, Oct 01, 2021 at 12:52:48PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/char/ipmi/ipmi_msghandler.c: In function 'bmc_device_id_handler':
> drivers/char/ipmi/ipmi_msghandler.c:2376:3: error: label 'out' used but not defined
>  2376 |   goto out;
>       |   ^~~~

I botched a cherry pick, it should be fixed now.  Sorry about that.

Thanks for the work you do.

-corey

> 
> Caused by commit
> 
>   2d7a6d8467f9 ("ipmi: Check error code before processing BMC response")
> 
> I have used the ipmi tree from next-20210930 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

Hi all,

After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user_work':
drivers/char/ipmi/ipmi_msghandler.c:1156:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
 1156 |  vfree(user);
      |  ^~~~~
      |  kvfree
drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_create_user':
drivers/char/ipmi/ipmi_msghandler.c:1188:13: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
 1188 |  new_user = vzalloc(sizeof(*new_user));
      |             ^~~~~~~
      |             kvzalloc
drivers/char/ipmi/ipmi_msghandler.c:1188:11: warning: assignment to 'struct ipmi_user *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1188 |  new_user = vzalloc(sizeof(*new_user));
      |           ^

Caused by commit

  d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Apr 2020 13:03:29 +1000
Subject: [PATCH] ipmi: vzalloc use requires vmallo.h inclusion

Fixes: d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/ipmi/ipmi_msghandler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 96f157323646..9afd220cd824 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -33,6 +33,7 @@
 #include <linux/workqueue.h>
 #include <linux/uuid.h>
 #include <linux/nospec.h>
+#include <linux/vmalloc.h>
 
 #define IPMI_DRIVER_VERSION "39.2"
 
-- 
2.25.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the ipmi tree

[Feng Tang]

On Mon, Apr 20, 2020 at 01:09:59PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ipmi tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user_work':
> drivers/char/ipmi/ipmi_msghandler.c:1156:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
>  1156 |  vfree(user);
>       |  ^~~~~
>       |  kvfree
> drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_create_user':
> drivers/char/ipmi/ipmi_msghandler.c:1188:13: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
>  1188 |  new_user = vzalloc(sizeof(*new_user));
>       |             ^~~~~~~
>       |             kvzalloc
> drivers/char/ipmi/ipmi_msghandler.c:1188:11: warning: assignment to 'struct ipmi_user *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>  1188 |  new_user = vzalloc(sizeof(*new_user));
>       |           ^
> 
> Caused by commit
> 
>   d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")
> 
> I have applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 20 Apr 2020 13:03:29 +1000
> Subject: [PATCH] ipmi: vzalloc use requires vmallo.h inclusion
> 
> Fixes: d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 96f157323646..9afd220cd824 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -33,6 +33,7 @@
>  #include <linux/workqueue.h>
>  #include <linux/uuid.h>
>  #include <linux/nospec.h>
> +#include <linux/vmalloc.h>

Thanks for the fix! I just compiled and tested the patch on x86 platforms.

Hi Corey,

Will you folder it into your tree, or you prefer me to send a v2? 

Anyway, I prepared a v2 here:

Thanks,
Feng


From b39b962a49efd6d7a6ea70f0a2ec8828a1d01768 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Fri, 17 Apr 2020 12:48:28 +0800
Subject: [PATCH] ipmi: use vzalloc instead of kmalloc for user creation

We met mulitple times of failure of staring bmc-watchdog,
due to the runtime memory allocation failure of order 4.

     bmc-watchdog: page allocation failure: order:4, mode:0x40cc0(GFP_KERNEL|__GFP_COMP), nodemask=(null),cpuset=/,mems_allowed=0-1
     CPU: 1 PID: 2571 Comm: bmc-watchdog Not tainted 5.5.0-00045-g7d6bb61d6188c #1
     Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.00.01.0015.110720180833 11/07/2018
     Call Trace:
      dump_stack+0x66/0x8b
      warn_alloc+0xfe/0x160
      __alloc_pages_slowpath+0xd3e/0xd80
      __alloc_pages_nodemask+0x2f0/0x340
      kmalloc_order+0x18/0x70
      kmalloc_order_trace+0x1d/0xb0
      ipmi_create_user+0x55/0x2c0 [ipmi_msghandler]
      ipmi_open+0x72/0x110 [ipmi_devintf]
      chrdev_open+0xcb/0x1e0
      do_dentry_open+0x1ce/0x380
      path_openat+0x305/0x14f0
      do_filp_open+0x9b/0x110
      do_sys_open+0x1bd/0x250
      do_syscall_64+0x5b/0x1f0
      entry_SYSCALL_64_after_hwframe+0x44/0xa9

Using vzalloc/vfree for creating ipmi_user heals the
problem

Thanks to Stephen Rothwell for finding the vmalloc.h
inclusion issue.

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
  v2:
     * explicitely include vmalloc.h, otherwise there
       will be compilation error as found by Stephen
       Rothwell  
 
 drivers/char/ipmi/ipmi_msghandler.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index c48d8f0..9afd220 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -33,6 +33,7 @@
 #include <linux/workqueue.h>
 #include <linux/uuid.h>
 #include <linux/nospec.h>
+#include <linux/vmalloc.h>
 
 #define IPMI_DRIVER_VERSION "39.2"
 
@@ -1153,7 +1154,7 @@ static void free_user_work(struct work_struct *work)
 					      remove_work);
 
 	cleanup_srcu_struct(&user->release_barrier);
-	kfree(user);
+	vfree(user);
 }
 
 int ipmi_create_user(unsigned int          if_num,
@@ -1185,7 +1186,7 @@ int ipmi_create_user(unsigned int          if_num,
 	if (rv)
 		return rv;
 
-	new_user = kmalloc(sizeof(*new_user), GFP_KERNEL);
+	new_user = vzalloc(sizeof(*new_user));
 	if (!new_user)
 		return -ENOMEM;
 
@@ -1232,7 +1233,7 @@ int ipmi_create_user(unsigned int          if_num,
 
 out_kfree:
 	srcu_read_unlock(&ipmi_interfaces_srcu, index);
-	kfree(new_user);
+	vfree(new_user);
 	return rv;
 }
 EXPORT_SYMBOL(ipmi_create_user);
-- 
2.7.4

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

Hi Corey,

After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, of_ipmi_match);
 ^
drivers/char/ipmi/ipmi_si_platform.c:360:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: parameter names (without types) in function declaration
drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(pci, ipmi_pci_devices);
 ^
drivers/char/ipmi/ipmi_si_pci.c:142:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: parameter names (without types) in function declaration

Caused by commits

  a3f3086dd508 ("ipmi_si: Move platform device handling to another file")
  fb5d20a966cf ("ipmi_si: Move PCI setup to another file

Probably missing include files.

I have added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Sep 2017 14:40:49 +1000
Subject: [PATCH] ipmi_si: MODULE_DEVICE_TABLE needs module.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/ipmi/ipmi_si_pci.c      | 2 +-
 drivers/char/ipmi/ipmi_si_platform.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
index ad0b7b6ad250..99771f5cad07 100644
--- a/drivers/char/ipmi/ipmi_si_pci.c
+++ b/drivers/char/ipmi/ipmi_si_pci.c
@@ -3,7 +3,7 @@
  *
  * Handling for IPMI devices on the PCI bus.
  */
-#include <linux/moduleparam.h>
+#include <linux/module.h>
 #include <linux/pci.h>
 #include "ipmi_si.h"
 
diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
index 0e7ff0a4a151..9573f1116450 100644
--- a/drivers/char/ipmi/ipmi_si_platform.c
+++ b/drivers/char/ipmi/ipmi_si_platform.c
@@ -5,7 +5,7 @@
  * coming from the platform.
  */
 #include <linux/types.h>
-#include <linux/moduleparam.h>
+#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
-- 
2.14.1

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On 09/27/2017 11:45 PM, Stephen Rothwell wrote:
> Hi Corey,
>
> After merging the ipmi tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: data definition has no type or storage class
>   MODULE_DEVICE_TABLE(of, of_ipmi_match);
>   ^
> drivers/char/ipmi/ipmi_si_platform.c:360:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: parameter names (without types) in function declaration
> drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: data definition has no type or storage class
>   MODULE_DEVICE_TABLE(pci, ipmi_pci_devices);
>   ^
> drivers/char/ipmi/ipmi_si_pci.c:142:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: parameter names (without types) in function declaration
>
> Caused by commits
>
>    a3f3086dd508 ("ipmi_si: Move platform device handling to another file")
>    fb5d20a966cf ("ipmi_si: Move PCI setup to another file
>
> Probably missing include files.
>
> I have added this patch for today:

Hmm, I'm wondering how this got missed.  I compile tested it, of course,
and lots of things compile my master rebase branch that this came from,
but nothing found this.  Oh well.

Thanks for handling this.  I have the fixes in and ready for next time.

-corey

>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 28 Sep 2017 14:40:49 +1000
> Subject: [PATCH] ipmi_si: MODULE_DEVICE_TABLE needs module.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>   drivers/char/ipmi/ipmi_si_pci.c      | 2 +-
>   drivers/char/ipmi/ipmi_si_platform.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index ad0b7b6ad250..99771f5cad07 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -3,7 +3,7 @@
>    *
>    * Handling for IPMI devices on the PCI bus.
>    */
> -#include <linux/moduleparam.h>
> +#include <linux/module.h>
>   #include <linux/pci.h>
>   #include "ipmi_si.h"
>   
> diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
> index 0e7ff0a4a151..9573f1116450 100644
> --- a/drivers/char/ipmi/ipmi_si_platform.c
> +++ b/drivers/char/ipmi/ipmi_si_platform.c
> @@ -5,7 +5,7 @@
>    * coming from the platform.
>    */
>   #include <linux/types.h>
> -#include <linux/moduleparam.h>
> +#include <linux/module.h>
>   #include <linux/of_device.h>
>   #include <linux/of_platform.h>
>   #include <linux/of_address.h>

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi Corey,

After merging the ipmi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ipmi/ipmi_ssif.c:55:26: fatal error: linux/ctypes.h: No such file or directory
 #include <linux/ctypes.h>
                          ^

Caused by commit 707096b4dd41 ("ipmi: Fix compile issue with isspace()").

I have used the ipmi tree from next-20141216 for today.

Also, you seem to have rebased your tree and thus duplicated a whole
series of commits that are now in Linus' tree :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the ipmi tree

[Corey Minyard]

On 12/16/2014 09:03 PM, Stephen Rothwell wrote:
> Hi Corey,
>
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/char/ipmi/ipmi_ssif.c:55:26: fatal error: linux/ctypes.h: No such file or directory
>  #include <linux/ctypes.h>
>                           ^
>
> Caused by commit 707096b4dd41 ("ipmi: Fix compile issue with isspace()").
>
> I have used the ipmi tree from next-20141216 for today.
>
> Also, you seem to have rebased your tree and thus duplicated a whole
> series of commits that are now in Linus' tree :-(

These should be fixed now.  I'm still learning the finer points of git for
this type of work.

Thanks,

-corey

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

Hi Corey,

After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:


drivers/char/ipmi/ipmi_ssif.c: In function 'ssif_probe':
drivers/char/ipmi/ipmi_ssif.c:1377:23: error: 'union ipmi_smi_info_union' has no member named 'acpi_info'
   ssif_info->addr_info.acpi_info.acpi_handle = acpi_handle;
                       ^

Caused by commit 66a4d9633da8 ("ipmi: Add SMBus interface driver (SSIF)").

I have reverted that commit (and the following 1c99788eebd9 "ipmi:
Handle I2C parms in the SSIF driver") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the ipmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi Corey,

After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:

make[3]: *** No rule to make target `drivers/char/ipmi/ipmi_powernv.o', needed by `drivers/char/ipmi/built-in.o'.

Caused by commit e6d873424d62 ("drivers/char/ipmi: Add powernv IPMI
driver").  Presumable a forgotten "git add" for the new file ...

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]