Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the scsi-fixes tree
@ 2020-06-24  7:07 Stephen Rothwell
  2020-06-24  7:14 ` SeongJae Park
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2020-06-24  7:07 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, SeongJae Park


[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()")

Fixes tag

  Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2020-06-24  7:07 linux-next: Fixes tag needs some work in the scsi-fixes tree Stephen Rothwell
@ 2020-06-24  7:14 ` SeongJae Park
  2020-06-24  7:17   ` [PATCH v2] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset() SeongJae Park
  2020-06-24  7:23   ` linux-next: Fixes tag needs some work in the scsi-fixes tree Stephen Rothwell
  0 siblings, 2 replies; 12+ messages in thread
From: SeongJae Park @ 2020-06-24  7:14 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, SeongJae Park

On Wed, 24 Jun 2020 17:07:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> 
> [-- Attachment #1: Type: text/plain, Size: 385 bytes --]
> 
> Hi all,
> 
> In commit
> 
>   46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()")
> 
> Fixes tag
> 
>   Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Oops, sorry for the mistake.  I will send the fixed version in reply to this.


Thanks,
SeongJae Park

> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()
  2020-06-24  7:14 ` SeongJae Park
@ 2020-06-24  7:17   ` SeongJae Park
  2020-06-24  7:23   ` linux-next: Fixes tag needs some work in the scsi-fixes tree Stephen Rothwell
  1 sibling, 0 replies; 12+ messages in thread
From: SeongJae Park @ 2020-06-24  7:17 UTC (permalink / raw)
  To: sfr; +Cc: martin.petersen, linux-next, linux-kernel, SeongJae Park

From: SeongJae Park <sjpark@amazon.de>

Commit cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp
with general hdw_queues per cpu") has introduced static checker warnings
for potential null dereferences in 'lpfc_sli4_hba_unset()' and
commit 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in
lpfc_sli4_hba_unset") has tried to fix it.  However, yet another
potential null dereference is remaining.  This commit fixes it.

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in lpfc_sli4_hba_unset")
Fixes: cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu")
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
 drivers/scsi/lpfc/lpfc_init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 69a5249e007a..6637f84a3d1b 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)
 	lpfc_sli4_xri_exchange_busy_wait(phba);
 
 	/* per-phba callback de-registration for hotplug event */
-	lpfc_cpuhp_remove(phba);
+	if (phba->pport)
+		lpfc_cpuhp_remove(phba);
 
 	/* Disable PCI subsystem interrupt */
 	lpfc_sli4_disable_intr(phba);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2020-06-24  7:14 ` SeongJae Park
  2020-06-24  7:17   ` [PATCH v2] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset() SeongJae Park
@ 2020-06-24  7:23   ` Stephen Rothwell
  1 sibling, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2020-06-24  7:23 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, SeongJae Park


[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi SeongJae,

On Wed, 24 Jun 2020 09:14:47 +0200 SeongJae Park <sjpark@amazon.com> wrote:
>
> Oops, sorry for the mistake.  I will send the fixed version in reply to this.

Unless Martin says otherwise, I am not sure it is worth fixing.  Just
remember for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2020-05-08 11:33 Stephen Rothwell
@ 2020-05-11 23:54 ` Martin K. Petersen
  0 siblings, 0 replies; 12+ messages in thread
From: Martin K. Petersen @ 2020-05-11 23:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List, Ewan D. Milne


Stephen,

>   Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long

I'm pretty good at spotting 8-digit SHAs but the 11 digits tripped me up
in this case.

I refined the SHA validation logic in my commit hook script to ensure 12
digits going forward.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-fixes tree
@ 2020-05-08 11:33 Stephen Rothwell
  2020-05-11 23:54 ` Martin K. Petersen
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2020-05-08 11:33 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ewan D. Milne


[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi all,

In commit

  0f3b2f3fb5dc ("scsi: qla2xxx: Do not log message when reading port speed via sysfs")

Fixes tag

  Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2019-02-06  3:55 ` Vaibhav Jain
  2019-02-06  4:34   ` Stephen Rothwell
@ 2019-02-06 13:03   ` Martin K. Petersen
  1 sibling, 0 replies; 12+ messages in thread
From: Martin K. Petersen @ 2019-02-06 13:03 UTC (permalink / raw)
  To: Vaibhav Jain
  Cc: Stephen Rothwell, Martin K. Petersen, Linux Next Mailing List,
	Linux Kernel Mailing List


Vaibhav,

> Martin, should I resend the patch with this fixed ?

No need, I fixed it up yesterday.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2019-02-06  3:55 ` Vaibhav Jain
@ 2019-02-06  4:34   ` Stephen Rothwell
  2019-02-06 13:03   ` Martin K. Petersen
  1 sibling, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2019-02-06  4:34 UTC (permalink / raw)
  To: Vaibhav Jain
  Cc: Martin K. Petersen, Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi Vaibhav,

On Wed, 06 Feb 2019 09:25:12 +0530 Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>
> Martin, should I resend the patch with this fixed ?

I wouldn't bother, it is a really picky report (I almost didn't send
it) :-)

Consider it just a reminder for next time.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: Fixes tag needs some work in the scsi-fixes tree
  2019-02-05 20:20 Stephen Rothwell
@ 2019-02-06  3:55 ` Vaibhav Jain
  2019-02-06  4:34   ` Stephen Rothwell
  2019-02-06 13:03   ` Martin K. Petersen
  0 siblings, 2 replies; 12+ messages in thread
From: Vaibhav Jain @ 2019-02-06  3:55 UTC (permalink / raw)
  To: Stephen Rothwell, Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Martin,
>
> In commit
>
>   bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails")
>
> Fixes tag
>
>   Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter")
>
> has these problem(s):
>
>   - missing space between the SHA1 and the subject
Thanks for catching this Stephen. I am surprised that the checkpatch.pl
script didnt catch this.

Martin, should I resend the patch with this fixed ?

Thanks,
-- 
Vaibhav Jain <vaibhav@linux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-fixes tree
@ 2019-02-05 20:20 Stephen Rothwell
  2019-02-06  3:55 ` Vaibhav Jain
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2019-02-05 20:20 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vaibhav Jain


[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi Martin,

In commit

  bb61b843ffd4 ("scsi: cxlflash: Prevent deadlock when adapter probe fails")

Fixes tag

  Fixes: c21e0bbfc485("cxlflash: Base support for IBM CXL Flash Adapter")

has these problem(s):

  - missing space between the SHA1 and the subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-fixes tree
@ 2019-01-29 20:53 Stephen Rothwell
  0 siblings, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2019-01-29 20:53 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Steffen Maier


[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

Hi all,

In commit

  b63195698dea ("scsi: zfcp: fix sysfs block queue limit output for max_segment_size")

Fixes tag

  Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters")

has these problem(s):

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: Fixes tag needs some work in the scsi-fixes tree
@ 2019-01-23  5:34 Stephen Rothwell
  0 siblings, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2019-01-23  5:34 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig


[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Hi Martin,

In commit

  a8cf59a6692c ("scsi: communicate max segment size to the DMA mapping code")

Fixes tag

  Fixes: 50c2e9107f ("scsi: introduce a max_segment_size host_template parameters")

has these problem(s):

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, back to index

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24  7:07 linux-next: Fixes tag needs some work in the scsi-fixes tree Stephen Rothwell
2020-06-24  7:14 ` SeongJae Park
2020-06-24  7:17   ` [PATCH v2] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset() SeongJae Park
2020-06-24  7:23   ` linux-next: Fixes tag needs some work in the scsi-fixes tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-05-08 11:33 Stephen Rothwell
2020-05-11 23:54 ` Martin K. Petersen
2019-02-05 20:20 Stephen Rothwell
2019-02-06  3:55 ` Vaibhav Jain
2019-02-06  4:34   ` Stephen Rothwell
2019-02-06 13:03   ` Martin K. Petersen
2019-01-29 20:53 Stephen Rothwell
2019-01-23  5:34 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git